On Thu, Apr 9, 2020 at 4:21 AM Segher Boessenkool <seg...@kernel.crashing.org> wrote: > > Hi! > > On Mon, Apr 06, 2020 at 06:09:20PM +1000, Jordan Niethe wrote: > > +static inline int ppc_inst_opcode(u32 x) > > +{ > > + return x >> 26; > > +} > > Maybe you should have "primary opcode" in this function name? Thanks, that is a good idea. > > > Segher
- Re: [PATCH v5 03/21] powerpc: Change calli... Balamuruhan S
- [PATCH v5 04/21] powerpc: Use a macro for creating inst... Jordan Niethe
- Re: [PATCH v5 04/21] powerpc: Use a macro for crea... Balamuruhan S
- Re: [PATCH v5 04/21] powerpc: Use a macro for ... Jordan Niethe
- [PATCH v5 05/21] powerpc: Use a function for getting th... Jordan Niethe
- Re: [PATCH v5 05/21] powerpc: Use a function for g... Christophe Leroy
- Re: [PATCH v5 05/21] powerpc: Use a function f... Jordan Niethe
- Re: [PATCH v5 05/21] powerpc: Use a function for g... Balamuruhan S
- Re: [PATCH v5 05/21] powerpc: Use a function f... Jordan Niethe
- Re: [PATCH v5 05/21] powerpc: Use a function for g... Segher Boessenkool
- Re: [PATCH v5 05/21] powerpc: Use a function f... Jordan Niethe
- [PATCH v5 06/21] powerpc: Use an accessor for instructi... Jordan Niethe
- [PATCH v5 07/21] powerpc: Use a function for byte swapp... Jordan Niethe
- Re: [PATCH v5 07/21] powerpc: Use a function for b... Balamuruhan S
- [PATCH v5 08/21] powerpc: Introduce functions for instr... Jordan Niethe
- Re: [PATCH v5 08/21] powerpc: Introduce functions ... Balamuruhan S
- [PATCH v5 09/21] powerpc: Use a datatype for instructio... Jordan Niethe
- Re: [PATCH v5 09/21] powerpc: Use a datatype for i... kbuild test robot
- Re: [PATCH v5 09/21] powerpc: Use a datatype for i... kbuild test robot
- Re: [PATCH v5 09/21] powerpc: Use a datatype for i... Balamuruhan S
- Re: [PATCH v5 09/21] powerpc: Use a datatype f... Jordan Niethe