Re: [PATCH 1/3] dma-direct: unify the dma_capable definitions

2019-11-14 Thread Michael Ellerman
Christoph Hellwig writes: > Currently each architectures that wants to override dma_to_phys and > phys_to_dma also has to provide dma_capable. But there isn't really > any good reason for that. powerpc and mips just have copies of the > generic one minus the latests fix, and the arm one was the

Re: [PATCH 3/3] powerpc: remove support for NULL dev in __phys_to_dma / __dma_to_phys

2019-11-14 Thread Michael Ellerman
Christoph Hellwig writes: > Support for calling the DMA API functions without a valid device pointer > was removed a while ago, so remove the stale support for that from the > powerpc __phys_to_dma / __dma_to_phys helpers. > > Signed-off-by: Christoph Hellwig > --- > arch/powerpc/include/asm/dma

Re: [PATCH v4 04/47] soc: fsl: qe: introduce qe_io{read,write}* wrappers

2019-11-14 Thread Rasmus Villemoes
On 14/11/2019 06.08, Timur Tabi wrote: > On 11/12/19 1:14 AM, Rasmus Villemoes wrote: >> but that's because readl and writel by definition work on little-endian >> registers. I.e., on a BE platform, the readl and writel implementation >> must themselves contain a swab, so the above would end up doi

Re: [PATCH v4 30/47] serial: ucc_uart: factor out soft_uart initialization

2019-11-14 Thread Rasmus Villemoes
On 14/11/2019 06.14, Timur Tabi wrote: > On Fri, Nov 8, 2019 at 7:03 AM Rasmus Villemoes > wrote: >> >> - /* >> -* Determine if we need Soft-UART mode >> -*/ >> if (of_find_property(np, "soft-uart", NULL)) { >> dev_dbg(&ofdev->dev, "using Soft-UART mod

Re: [PATCH] Fix wrong message when RFI Flush is disable

2019-11-14 Thread Michael Ellerman
On Thu, 2019-05-02 at 21:09:07 UTC, Gustavo Walbon wrote: > From: "Gustavo L. F. Walbon" > > The issue was showing "Mitigation" message via sysfs whatever the state of > "RFI Flush", but it should show "Vulnerable" when it is disabled. > > If you have "L1D private" feature enabled and not "RFI F

Re: [PATCH net-next] defconfigs: remove obsolete CONFIG_INET_XFRM_MODE_* and CONFIG_INET6_XFRM_MODE_*

2019-11-14 Thread Michael Ellerman
On Wed, 2019-06-12 at 07:19:01 UTC, YueHaibing wrote: > These Kconfig options has been removed in > commit 4c145dce2601 ("xfrm: make xfrm modes builtin") > So there is no point to keep it in defconfigs any longer. > > Signed-off-by: YueHaibing Applied to powerpc next, thanks. https://git.kernel

Re: [PATCH -next] powerpc/powernv: Make some sysbols static

2019-11-14 Thread Michael Ellerman
On Tue, 2019-07-02 at 13:17:33 UTC, YueHaibing wrote: > Fix sparse warnings: > > arch/powerpc/platforms/powernv/opal-psr.c:20:1: > warning: symbol 'psr_mutex' was not declared. Should it be static? > arch/powerpc/platforms/powernv/opal-psr.c:27:3: > warning: symbol 'psr_attrs' was not declared.

Re: [PATCH -next] powerpc/powernv/ioda: using kfree_rcu() to simplify the code

2019-11-14 Thread Michael Ellerman
On Thu, 2019-07-11 at 14:18:18 UTC, YueHaibing wrote: > The callback function of call_rcu() just calls a kfree(), so we > can use kfree_rcu() instead of call_rcu() + callback function. > > Signed-off-by: YueHaibing Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/c312d14e19bb7c

Re: [PATCH v2] powerpc/book3s/mm: Update Oops message to print the correct translation in use

2019-11-14 Thread Michael Ellerman
On Thu, 2019-07-11 at 14:58:14 UTC, "Aneesh Kumar K.V" wrote: > Avoids confusion when printing Oops message like below > > Faulting instruction address: 0xc008bdb4 > Oops: Kernel access of bad area, sig: 11 [#1] > LE PAGE_SIZE=64K MMU=Radix MMU=Hash SMP NR_CPUS=2048 NUMA PowerNV > > Th

Re: [PATCH v3] powerpc: Support CMDLINE_EXTEND

2019-11-14 Thread Michael Ellerman
On Thu, 2019-08-01 at 22:50:06 UTC, Chris Packham wrote: > Bring powerpc in line with other architectures that support extending or > overriding the bootloader provided command line. > > The current behaviour is most like CMDLINE_FROM_BOOTLOADER where the > bootloader command line is preferred but

Re: [PATCH] powerpc: use

2019-11-14 Thread Michael Ellerman
On Wed, 2019-08-07 at 15:07:52 UTC, Christoph Hellwig wrote: > The powerpc version of dma-mapping.h only contains a version of > get_arch_dma_ops that always return NULL. Replace it with the > asm-generic version that does the same. > > Signed-off-by: Christoph Hellwig Applied to powerpc next,

Re: [PATCH v2 1/1] powerpc/pseries/hotplug-memory.c: Change rc variable to bool

2019-11-14 Thread Michael Ellerman
On Fri, 2019-08-02 at 13:39:15 UTC, Leonardo Bras wrote: > Changes the return variable to bool (as the return value) and > avoids doing a ternary operation before returning. > > Signed-off-by: Leonardo Bras Series applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/b948aaaf3e39cc4

Re: [PATCH] powerpc: Replace GPL boilerplate with SPDX identifiers

2019-11-14 Thread Michael Ellerman
On Wed, 2019-08-28 at 06:07:37 UTC, Thomas Huth wrote: > The FSF does not reside in "675 Mass Ave, Cambridge" anymore... > let's simply use proper SPDX identifiers instead. > > Signed-off-by: Thomas Huth Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/bbbd7f112c7b0af32f7b3c725

Re: [PATCH] powerpc/perf: remove current_is_64bit()

2019-11-14 Thread Michael Ellerman
On Thu, 2019-09-12 at 19:46:33 UTC, Michal Suchanek wrote: > Since commit ed1cd6deb013 ("powerpc: Activate CONFIG_THREAD_INFO_IN_TASK") > current_is_64bit() is quivalent to !is_32bit_task(). > Remove the redundant function. > > Link: https://github.com/linuxppc/issues/issues/275 > Link: https://lk

Re: [PATCH] powerpc/book3s64/hash: Add cond_resched to avoid soft lockup warning

2019-11-14 Thread Michael Ellerman
On Tue, 2019-10-01 at 08:46:56 UTC, "Aneesh Kumar K.V" wrote: > With large memory (8TB and more) hotplug, we can get soft lockup warnings > as below. These were caused by a long loop without any explicit cond_resched > which is a problem for !PREEMPT kernels. > > Avoid the using cond_resched() whi

Re: [PATCH] sysfs: Fixes __BIN_ATTR_WO() macro

2019-11-14 Thread Michael Ellerman
On Tue, 2019-10-01 at 23:37:18 UTC, Nayna Jain wrote: > This patch fixes the size and write parameter for the macro > __BIN_ATTR_WO(). > > Fixes: 7f905761e15a8 ("sysfs: add BIN_ATTR_WO() macro") > Signed-off-by: Nayna Jain Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/39a963

Re: [PATCH v2 1/2] powerpc/pseries: address checkpatch warnings in dlpar_offline_cpu

2019-11-14 Thread Michael Ellerman
On Wed, 2019-10-16 at 18:36:10 UTC, Nathan Lynch wrote: > Remove some stray blank lines, convert a printk to pr_warn, and > address a line length violation. > > One functional change: use WARN_ON instead of BUG_ON in case H_PROD of > a ceded thread yields an unexpected result from the platform. We

Re: [PATCH 1/1] powerpc/eeh: differentiate duplicate detection message

2019-11-14 Thread Michael Ellerman
On Thu, 2019-10-17 at 04:59:37 UTC, Sam Bobroff wrote: > Currently when an EEH error is detected, the system log receives the > same (or almost the same) message twice: > > EEH: PHB#0 failure detected, location: N/A > EEH: PHB#0 failure detected, location: N/A > or > EEH: eeh_dev_check_failure: Fr

Re: [PATCH v6 1/7] Powerpc/Watchpoint: Introduce macros for watchpoint length

2019-11-14 Thread Michael Ellerman
On Thu, 2019-10-17 at 09:31:58 UTC, Ravi Bangoria wrote: > We are hadrcoding length everywhere in the watchpoint code. > Introduce macros for the length and use them. > > Signed-off-by: Ravi Bangoria Series applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/b811be615cb78c90fca42b

Re: [PATCH] powerpc/security: Fix debugfs data leak on 32-bit

2019-11-14 Thread Michael Ellerman
On Mon, 2019-10-21 at 14:23:09 UTC, Geert Uytterhoeven wrote: > "powerpc_security_features" is "unsigned long", i.e. 32-bit or 64-bit, > depending on the platform (PPC_FSL_BOOK3E or PPC_BOOK3S_64). Hence > casting its address to "u64 *", and calling debugfs_create_x64() is > wrong, and leaks 32-bi

Re: [PATCH] powerpc/64s/exception: Fix kaup -> kuap typo

2019-11-14 Thread Michael Ellerman
On Tue, 2019-10-22 at 06:06:03 UTC, Andrew Donnellan wrote: > It's KUAP, not KAUP. Fix typo in INT_COMMON macro. > > Signed-off-by: Andrew Donnellan Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/1db550f44ab672b5ded14a94e092b9a9a2d29c8c cheers

Re: [PATCH -next] powerpc/spufs: remove set but not used variable 'ctx'

2019-11-14 Thread Michael Ellerman
On Wed, 2019-10-23 at 13:44:23 UTC, YueHaibing wrote: > arch/powerpc/platforms/cell/spufs/inode.c:201:22: > warning: variable ctx set but not used [-Wunused-but-set-variable] > > It is not used since commit 67cba9fd6456 ("move > spu_forget() into spufs_rmdir()") > > Signed-off-by: YueHaibing A

Re: [RESEND][PATCH] powerpc/pseries: Use correct event modifier in rtas_parse_epow_errlog()

2019-11-14 Thread Michael Ellerman
On Wed, 2019-10-23 at 13:48:38 UTC, YueHaibing wrote: > rtas_parse_epow_errlog() should pass 'modifier' to > handle_system_shutdown, because event modifier only use > bottom 4 bits. > > Reviewed-by: Tyrel Datwyler > Signed-off-by: YueHaibing Applied to powerpc next, thanks. https://git.kernel.

Re: [PATCH v1 1/3] mm/powerpc/book3s64/radix: Remove unused code.

2019-11-14 Thread Michael Ellerman
On Thu, 2019-10-24 at 07:57:59 UTC, "Aneesh Kumar K.V" wrote: > mm_tlb_flush_nested change was added in the mmu gather tlb flush to handle > the case of parallel pte invalidate happening with mmap_sem held in read > mode. This fix was done by commit: 02390f66bd23 ("powerpc/64s/radix: Fix > MADV_[FR

Re: [PATCH] L1TF support in PowerPC SYSFS.

2019-11-14 Thread Michael Ellerman
On Tue, 2019-10-29 at 19:07:59 UTC, asteinhau...@google.com wrote: > From: Anthony Steinhauser > > PowerPC CPUs are vulnerable to L1TF to the same extent as to Meltdown. > It is also mitigated by flushing the L1D on privilege transition. > Currently the SYSFS gives a false negative on L1TF on CPU

Re: [PATCH v10 2/9] powerpc/ima: add support to initialize ima policy rules

2019-11-14 Thread Michael Ellerman
On Thu, 2019-10-31 at 03:31:27 UTC, Mimi Zohar wrote: > From: Nayna Jain > > PowerNV systems use a Linux-based bootloader, which rely on the IMA > subsystem to enforce different secure boot modes. Since the verification > policy may differ based on the secure boot mode of the system, the > polic

Re: [PATCH v10 4/9] powerpc/ima: define trusted boot policy

2019-11-14 Thread Michael Ellerman
On Thu, 2019-10-31 at 03:31:29 UTC, Mimi Zohar wrote: > From: Nayna Jain > > This patch defines an arch-specific trusted boot only policy and a > combined secure and trusted boot policy. > > Signed-off-by: Nayna Jain > Signed-off-by: Mimi Zohar Applied to powerpc next, thanks. https://git.ke

Re: [PATCH v10 5/9] ima: make process_buffer_measurement() generic

2019-11-14 Thread Michael Ellerman
On Thu, 2019-10-31 at 03:31:30 UTC, Mimi Zohar wrote: > From: Nayna Jain > > process_buffer_measurement() is limited to measuring the kexec boot > command line. This patch makes process_buffer_measurement() more > generic, allowing it to measure other types of buffer data (e.g. > blacklisted bina

Re: [PATCH v10 6/9] certs: add wrapper function to check blacklisted binary hash

2019-11-14 Thread Michael Ellerman
On Thu, 2019-10-31 at 03:31:31 UTC, Mimi Zohar wrote: > From: Nayna Jain > > The -EKEYREJECTED error returned by existing is_hash_blacklisted() is > misleading when called for checking against blacklisted hash of a > binary. > > This patch adds a wrapper function is_binary_blacklisted() to retur

Re: [PATCH v10 7/9] ima: check against blacklisted hashes for files with modsig

2019-11-14 Thread Michael Ellerman
On Thu, 2019-10-31 at 03:31:32 UTC, Mimi Zohar wrote: > From: Nayna Jain > > Asymmetric private keys are used to sign multiple files. The kernel > currently supports checking against blacklisted keys. However, if the > public key is blacklisted, any file signed by the blacklisted key will > aut

Re: [PATCH v10 8/9] powerpc/ima: update ima arch policy to check for blacklist

2019-11-14 Thread Michael Ellerman
On Thu, 2019-10-31 at 03:31:33 UTC, Mimi Zohar wrote: > From: Nayna Jain > > This patch updates the arch-specific policies for PowerNV system to make > sure that the binary hash is not blacklisted. > > Signed-off-by: Nayna Jain > Cc: Jessica Yu > Signed-off-by: Mimi Zohar Applied to powerpc

Re: [PATCH] powerpc/xive: Prevent page fault issues in the machine crash handler

2019-11-14 Thread Michael Ellerman
On Thu, 2019-10-31 at 06:31:00 UTC, =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= wrote: > When the machine crash handler is invoked, all interrupts are masked > but interrupts which have not been started yet do not have an ESB page > mapped in the Linux address space. This crashes the 'crash kexec' > sequ

Re: [RFC PATCH v10 9/9] powerpc/ima: indicate kernel modules appended signatures are enforced

2019-11-14 Thread Michael Ellerman
On Thu, 2019-10-31 at 03:31:34 UTC, Mimi Zohar wrote: > The arch specific kernel module policy rule requires kernel modules to > be signed, either as an IMA signature, stored as an xattr, or as an > appended signature. As a result, kernel modules appended signatures > could be enforced without "si

Re: [PATCH 1/1] powerpc/crypto: Add cond_resched() in crc-vpmsum self-test

2019-11-14 Thread Michael Ellerman
On Sun, 2019-11-03 at 23:33:56 UTC, Chris Smart wrote: > The stress test for vpmsum implementations executes a long for loop in > the kernel. This blocks the scheduler, which prevents other tasks from > running, resulting in a warning. > > This fix adds a call to cond_reshed() at the end of each l

Re: [PATCH v1 01/12] powerpc/pseries: CMM: Implement release() function for sysfs device

2019-11-14 Thread Michael Ellerman
On Thu, 2019-10-31 at 14:29:22 UTC, David Hildenbrand wrote: > When unloading the module, one gets > [ 548.188594] [ cut here ] > [ 548.188596] Device 'cmm0' does not have a release() function, it is brok= > en and must be fixed. See Documentation/kobject.txt. > [ 548.188

Re: [PATCH v5 1/6] powerpc: Allow flush_icache_range to work across ranges >4GB

2019-11-14 Thread Michael Ellerman
On Mon, 2019-11-04 at 02:32:53 UTC, "Alastair D'Silva" wrote: > From: Alastair D'Silva > > When calling flush_icache_range with a size >4GB, we were masking > off the upper 32 bits, so we would incorrectly flush a range smaller > than intended. > > This patch replaces the 32 bit shifts with 64 b

Re: [PATCH] selftests/powerpc: Skip tm-signal-sigreturn-nt if TM not available

2019-11-14 Thread Michael Ellerman
On Mon, 2019-11-04 at 23:35:24 UTC, Michael Ellerman wrote: > On systems where TM (Transactional Memory) is disabled the > tm-signal-sigreturn-nt test causes a SIGILL: > > test: tm_signal_sigreturn_nt > tags: git_version:7c202575ef63 > !! child died by signal 4 > failure: tm_signal_sigretu

Re: [PATCH v3] powerpc/fadump: when fadump is supported register the fadump sysfs files.

2019-11-14 Thread Michael Ellerman
On Thu, 2019-11-07 at 16:47:57 UTC, Michal Suchanek wrote: > Currently it is not possible to distinguish the case when fadump is > supported by firmware and disabled in kernel and completely unsupported > using the kernel sysfs interface. User can investigate the devicetree > but it is more reasona

Re: [PATCH] powerpc/64s: Always disable branch profiling for prom_init.o

2019-11-14 Thread Michael Ellerman
On Wed, 2019-11-06 at 05:11:29 UTC, Michael Ellerman wrote: > Otherwise the build fails because prom_init is calling symbols it's > not allowed to, eg: > > Error: External symbol 'ftrace_likely_update' referenced from prom_init.c > make[3]: *** [arch/powerpc/kernel/Makefile:197: > arch/powerp

Re: [PATCH v2 1/9] powerpc/pseries: Fix bad drc_index_start value parsing of drc-info entry

2019-11-14 Thread Michael Ellerman
On Mon, 2019-11-11 at 05:21:28 UTC, Tyrel Datwyler wrote: > The ibm,drc-info property is an array property that contains drc-info > entries such that each entry is made up of 2 string encoded elements > followed by 5 int encoded elements. The of_read_drc_info_cell() > helper contains comments that

Re: [PATCH v10a 3/9] powerpc: detect the trusted boot state of the system

2019-11-14 Thread Michael Ellerman
On Tue, 2019-11-05 at 23:02:07 UTC, Eric Richter wrote: > From: Nayna Jain > > While secure boot permits only properly verified signed kernels to be > booted, trusted boot calculates the file hash of the kernel image and > stores the measurement prior to boot, that can be subsequently compared >

Re: [PATCH v10a 1/9] powerpc: detect the secure boot mode of the system

2019-11-14 Thread Michael Ellerman
On Tue, 2019-11-05 at 23:00:22 UTC, Eric Richter wrote: > From: Nayna Jain > > This patch defines a function to detect the secure boot state of a > PowerNV system. > > The PPC_SECURE_BOOT config represents the base enablement of secure boot > for powerpc. > > Signed-off-by: Nayna Jain > Signed

Re: [PATCH v9 1/4] powerpc/powernv: Add OPAL API interface to access secure variable

2019-11-14 Thread Michael Ellerman
On Mon, 2019-11-11 at 03:10:33 UTC, Nayna Jain wrote: > The X.509 certificates trusted by the platform and required to secure boot > the OS kernel are wrapped in secure variables, which are controlled by > OPAL. > > This patch adds firmware/kernel interface to read and write OPAL secure > variable

Re: [PATCH -next] powerpc/powernv/npu: Fix debugfs_simple_attr.cocci warnings

2019-11-14 Thread Michael Ellerman
On Tue, 2018-12-25 at 02:44:36 UTC, YueHaibing wrote: > Use DEFINE_DEBUGFS_ATTRIBUTE rather than DEFINE_SIMPLE_ATTRIBUTE > for debugfs files. > > Semantic patch information: > Rationale: DEFINE_SIMPLE_ATTRIBUTE + debugfs_create_file() > imposes some significant overhead as compared to > DEFINE_DEB

Re: [PATCH -next] powerpc/64s: Fix debugfs_simple_attr.cocci warnings

2019-11-14 Thread Michael Ellerman
On Thu, 2018-11-29 at 13:35:18 UTC, YueHaibing wrote: > Use DEFINE_DEBUGFS_ATTRIBUTE rather than DEFINE_SIMPLE_ATTRIBUTE > for debugfs files. > > Semantic patch information: > Rationale: DEFINE_SIMPLE_ATTRIBUTE + debugfs_create_file() > imposes some significant overhead as compared to > DEFINE_DEB

Re: [PATCH] macintosh: ans-lcd: make anslcd_logo static and __initconst

2019-11-14 Thread Michael Ellerman
On Fri, 2018-11-02 at 21:17:06 UTC, Rasmus Villemoes wrote: > This variable has no reason to have external linkage, and since it is > only used in an __init function, it might as well be made __initconst > also. > > Signed-off-by: Rasmus Villemoes Applied to powerpc next, thanks. https://git.ke

Re: [PATCH v2 -next] powerpc/pseries: Fix platform_no_drv_owner.cocci warnings

2019-11-14 Thread Michael Ellerman
On Mon, 2019-02-18 at 13:39:50 UTC, YueHaibing wrote: > Remove .owner field if calls are used which set it automatically > Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci > > Signed-off-by: YueHaibing Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/42974f357db

Re: [PATCH -next] powerpc/pseries: Drop pointless static qualifier in vpa_debugfs_init()

2019-11-14 Thread Michael Ellerman
On Mon, 2019-02-18 at 12:56:44 UTC, YueHaibing wrote: > There is no need to have the 'struct dentry *vpa_dir' variable static > since new value always be assigned before use it. > > Signed-off-by: YueHaibing Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/11dd34f3eae5a468013bb

Re: [PATCH 2/2] powerpc/hw_breakpoints: Rewrite 8xx breakpoints to allow any address range size.

2019-11-14 Thread Michael Ellerman
Christophe Leroy writes: > Unlike standard powerpc, Powerpc 8xx doesn't have SPRN_DABR, but > it has a breakpoint support based on a set of comparators which > allow more flexibility. > > Commit 4ad8622dc548 ("powerpc/8xx: Implement hw_breakpoint") > implemented breakpoints by emulating the DABR b

Re: [PATCH] Fix wrong message when RFI Flush is disable

2019-11-14 Thread Michal Suchánek
On Thu, Nov 14, 2019 at 08:07:35PM +1100, Michael Ellerman wrote: > On Thu, 2019-05-02 at 21:09:07 UTC, Gustavo Walbon wrote: > > From: "Gustavo L. F. Walbon" > > > > The issue was showing "Mitigation" message via sysfs whatever the state of > > "RFI Flush", but it should show "Vulnerable" when i

Re: [PATCH] dma-mapping: treat dev->bus_dma_mask as a DMA limit

2019-11-14 Thread Nicolas Saenz Julienne
On Wed, 2019-11-13 at 20:34 +, Robin Murphy wrote: > On 13/11/2019 4:13 pm, Nicolas Saenz Julienne wrote: > > Using a mask to represent bus DMA constraints has a set of limitations. > > The biggest one being it can only hold a power of two (minus one). The > > DMA mapping code is already aware

Re: [PATCH] sysfs: Fixes __BIN_ATTR_WO() macro

2019-11-14 Thread Greg Kroah-Hartman
On Thu, Nov 14, 2019 at 08:07:49PM +1100, Michael Ellerman wrote: > On Tue, 2019-10-01 at 23:37:18 UTC, Nayna Jain wrote: > > This patch fixes the size and write parameter for the macro > > __BIN_ATTR_WO(). > > > > Fixes: 7f905761e15a8 ("sysfs: add BIN_ATTR_WO() macro") > > Signed-off-by: Nayna Ja

[PATCH] random: Make RANDOM_TRUST_CPU depend on ARCH_RANDOM

2019-11-14 Thread richard . henderson
From: Richard Henderson Listing the set of host architectures does not scale. Depend instead on the existance of the architecture rng. Signed-off-by: Richard Henderson --- drivers/char/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/char/Kconfig b/driver

Re: [PATCH v1 01/12] powerpc/pseries: CMM: Implement release() function for sysfs device

2019-11-14 Thread David Hildenbrand
On 14.11.19 10:08, Michael Ellerman wrote: On Thu, 2019-10-31 at 14:29:22 UTC, David Hildenbrand wrote: When unloading the module, one gets [ 548.188594] [ cut here ] [ 548.188596] Device 'cmm0' does not have a release() function, it is brok= en and must be fixed. See D

[PATCH v2 0/2] mm: remove the memory isolate notifier

2019-11-14 Thread David Hildenbrand
This is the MM part of https://lkml.org/lkml/2019/10/31/487 "We can get rid of the memory isolate notifier by switching to balloon compaction in powerpc's CMM (Collaborative Memory Management). The memory isolate notifier was only necessary to allow to offline memory blocks that contain in

[PATCH v2 1/2] mm: remove the memory isolate notifier

2019-11-14 Thread David Hildenbrand
Luckily, we have no users left, so we can get rid of it. Cleanup set_migratetype_isolate() a little bit. Cc: Greg Kroah-Hartman Cc: "Rafael J. Wysocki" Cc: Andrew Morton Cc: Pavel Tatashin Cc: Michal Hocko Cc: Dan Williams Cc: Oscar Salvador Cc: Qian Cai Cc: Anshuman Khandual Cc: Pingfan

[PATCH v2 2/2] mm: remove "count" parameter from has_unmovable_pages()

2019-11-14 Thread David Hildenbrand
Now that the memory isolate notifier is gone, the parameter is always 0. Drop it and cleanup has_unmovable_pages(). Cc: Michal Hocko Cc: Andrew Morton Cc: Oscar Salvador Cc: Anshuman Khandual Cc: Qian Cai Cc: Pingfan Liu Cc: Stephen Rothwell Cc: Dan Williams Cc: Pavel Tatashin Cc: Vlastim

Re: [PATCH v15 3/9] namei: LOOKUP_NO_XDEV: block mountpoint crossing

2019-11-14 Thread Aleksa Sarai
On 2019-11-14, Al Viro wrote: > On Thu, Nov 14, 2019 at 03:49:45PM +1100, Aleksa Sarai wrote: > > On 2019-11-13, Al Viro wrote: > > > On Tue, Nov 05, 2019 at 08:05:47PM +1100, Aleksa Sarai wrote: > > > > > > > @@ -862,6 +870,8 @@ static int nd_jump_root(struct nameidata *nd) > > > > void nd_jum

Re: [PATCH] powerpc/powernv: Disable native PCIe port management

2019-11-14 Thread Oliver O'Halloran
On Thu, Nov 14, 2019 at 1:31 AM Bjorn Helgaas wrote: > > This is fine, but it feels like sort of a blunt instrument. Is there > any practical way to clear pci_host_bridge.native_pcie_hotplug (and > native_aer if appropriate) for the PHBs in question? That would also > prevent pciehp from binding.

Re: [PATCH] powerpc/powernv: Disable native PCIe port management

2019-11-14 Thread Oliver O'Halloran
On Thu, Nov 14, 2019 at 7:39 AM Tyrel Datwyler wrote: > > Nothing but pedantic spelling and grammar nits of the commit log follow. > > -Tyrel Thanks. My speeling is bad even on a good day and it was not a good day.

Re: [PATCH 08/10] nvdimm: Add driver for OpenCAPI Storage Class Memory

2019-11-14 Thread Frederic Barrat
Hi Alastair, The patch is huge and could/should probably be split in smaller pieces to ease the review. However, having sinned on that same topic in the past, I made a first pass anyway. I haven't covered everything but tried to focus on the general setup of the driver for now. Since the patch

Re: [PATCH] powerpc/powernv: Disable native PCIe port management

2019-11-14 Thread Bjorn Helgaas
On Fri, Nov 15, 2019 at 12:34:50AM +1100, Oliver O'Halloran wrote: > On Thu, Nov 14, 2019 at 1:31 AM Bjorn Helgaas wrote: > > > > This is fine, but it feels like sort of a blunt instrument. Is there > > any practical way to clear pci_host_bridge.native_pcie_hotplug (and > > native_aer if appropri

Re: [PATCH v4 32/47] serial: ucc_uart: use of_property_read_u32() in ucc_uart_probe()

2019-11-14 Thread Timur Tabi
On Fri, Nov 8, 2019 at 7:03 AM Rasmus Villemoes wrote: > > - if (*iprop) > - qe_port->port.uartclk = *iprop; > + if (val) > + qe_port->port.uartclk = val; > else { > /* > * Older versions of U-Boot do not initialize t

Re: [PATCH 08/10] nvdimm: Add driver for OpenCAPI Storage Class Memory

2019-11-14 Thread Dan Williams
Some quick feedback on your intro concerns... On Thu, Nov 14, 2019 at 5:41 AM Frederic Barrat wrote: > > Hi Alastair, > > The patch is huge and could/should probably be split in smaller pieces Yeah, it's a must. Split the minimum viable infrastructure by topic and then follow on with per-feature

WARN_ONCE does not warn once

2019-11-14 Thread Michal Suchánek
Hello, on powernv with 5.3.8 kernel I get flood of messages on boot. The messages match WARN_ONCE(1, "opal: OPAL_CONSOLE_FLUSH missing.\n"); [ cut here ] opal: OPAL_CONSOLE_FLUSH missing. WARNING: CPU: 0 PID: 0 at ../arch/powerpc/platforms/powernv/opal.c:435 __opal_flush

Re: [PATCH 2/2] powerpc/hw_breakpoints: Rewrite 8xx breakpoints to allow any address range size.

2019-11-14 Thread Christophe Leroy
Michael Ellerman a écrit : Christophe Leroy writes: Unlike standard powerpc, Powerpc 8xx doesn't have SPRN_DABR, but it has a breakpoint support based on a set of comparators which allow more flexibility. Commit 4ad8622dc548 ("powerpc/8xx: Implement hw_breakpoint") implemented breakpoints by

Re: [PATCH v2 1/1] powerpc/pseries/hotplug-memory.c: Change rc variable to bool

2019-11-14 Thread Leonardo Bras
On Thu, 2019-11-14 at 20:07 +1100, Michael Ellerman wrote: > On Fri, 2019-08-02 at 13:39:15 UTC, Leonardo Bras wrote: > > Changes the return variable to bool (as the return value) and > > avoids doing a ternary operation before returning. > > > > Signed-off-by: Leonardo Bras > > Series applied t

Re: [PATCH v2 1/4] powerpc/kvm/book3s: Fixes possible 'use after release' of kvm

2019-11-14 Thread Leonardo Bras
On Tue, 2019-11-12 at 15:57 +1100, Michael Ellerman wrote: > Hi Leonardo, Hello Micheal, thanks for the feedback! > > Leonardo Bras writes: > > Fixes a possible 'use after free' of kvm variable in > > kvm_vm_ioctl_create_spapr_tce, where it does a mutex_unlock(&kvm- > > >lock) > > after a kvm_p

Re: [PATCH v2 1/2] mm: remove the memory isolate notifier

2019-11-14 Thread Michal Hocko
On Thu 14-11-19 14:19:10, David Hildenbrand wrote: > Luckily, we have no users left, so we can get rid of it. Cleanup > set_migratetype_isolate() a little bit. > > Cc: Greg Kroah-Hartman > Cc: "Rafael J. Wysocki" > Cc: Andrew Morton > Cc: Pavel Tatashin > Cc: Michal Hocko > Cc: Dan Williams

Re: [PATCH v2 2/2] mm: remove "count" parameter from has_unmovable_pages()

2019-11-14 Thread Michal Hocko
On Thu 14-11-19 14:19:11, David Hildenbrand wrote: > Now that the memory isolate notifier is gone, the parameter is always 0. > Drop it and cleanup has_unmovable_pages(). > > Cc: Michal Hocko > Cc: Andrew Morton > Cc: Oscar Salvador > Cc: Anshuman Khandual > Cc: Qian Cai > Cc: Pingfan Liu >

Re: WARN_ONCE does not warn once

2019-11-14 Thread Michal Suchánek
On Thu, Nov 14, 2019 at 05:46:55PM +0100, Michal Suchánek wrote: > Hello, > > on powernv with 5.3.8 kernel I get flood of messages on boot. > > The messages match WARN_ONCE(1, "opal: OPAL_CONSOLE_FLUSH missing.\n"); Asking around it was pointed out that WARN_ONCE warns up to as many times as you

Re: [PATCH v4 0/3] Append new variables to vmcoreinfo (TCR_EL1.T1SZ for arm64 and MAX_PHYSMEM_BITS for all archs)

2019-11-14 Thread Bhupesh Sharma
Hi Akashi, On Wed, Nov 13, 2019 at 12:11 PM AKASHI Takahiro wrote: > > Hi Bhupesh, > > Do you have a corresponding patch for userspace tools, > including crash util and/or makedumpfile? > Otherwise, we can't verify that a generated core file is > correctly handled. Sure. I am still working on th

[PATCH] of: unittest: fix memory leak in attach_node_and_children

2019-11-14 Thread Erhard Furtner
In attach_node_and_children memory is allocated for full_name via kasprintf. If the condition of the 1st if is not met the function returns early without freeing the memory. Add a kfree() to fix that. Signed-off-by: Erhard Furtner --- drivers/of/unittest.c | 4 +++- 1 file changed, 3 insertions(

Re: [PATCH v2 1/2] kasan: support instrumented bitops combined with generic bitops

2019-11-14 Thread Marco Elver
On Mon, 28 Oct 2019 at 14:56, Daniel Axtens wrote: > > Hi all, > > Would it be possible to get an Ack from a KASAN maintainter? mpe is > happy to take this through powerpc but would like an ack first. > > Regards, > Daniel > > >> Currently bitops-instrumented.h assumes that the architecture provid

Re: [PATCH V3 1/2] ASoC: dt-bindings: fsl_asrc: add compatible string for imx8qm

2019-11-14 Thread Rob Herring
On Mon, Nov 11, 2019 at 05:18:22PM +0800, Shengjiu Wang wrote: > Add compatible string "fsl,imx8qm-asrc" for imx8qm platform. > > There are two asrc modules in imx8qm, the clock mapping is > different for each other, so add new property "fsl,asrc-clk-map" > to distinguish them. What's the clock m

Re: [PATCH v3 36/36] soc: fsl: qe: remove PPC32 dependency from CONFIG_QUICC_ENGINE

2019-11-14 Thread kbuild test robot
Hi Rasmus, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v5.4-rc7 next-20191114] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '-

[RFC PATCH] soc: fsl: qe: qe_uart_set_mctrl() can be static

2019-11-14 Thread kbuild test robot
Fixes: 116af8542b17 ("soc: fsl: qe: remove PPC32 dependency from CONFIG_QUICC_ENGINE") Signed-off-by: kbuild test robot --- ucc_uart.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/ucc_uart.c b/drivers/tty/serial/ucc_uart.c index a5330582b6103..58891

Re: [PATCH 00/50] Add log level to show_stack()

2019-11-14 Thread Sergey Senozhatsky
On (19/11/13 16:40), Dmitry Safonov wrote: > It's also not very fun for me to create those patches. > But they fix console_loglevel issues (I hope we could un-export it in > the end) and also I need it for my other patches those will produce > warnings with debug loglevel when configured through sy

Re: [PATCH v4 0/3] Append new variables to vmcoreinfo (TCR_EL1.T1SZ for arm64 and MAX_PHYSMEM_BITS for all archs)

2019-11-14 Thread AKASHI Takahiro
Bhupesh, On Fri, Nov 15, 2019 at 01:24:17AM +0530, Bhupesh Sharma wrote: > Hi Akashi, > > On Wed, Nov 13, 2019 at 12:11 PM AKASHI Takahiro > wrote: > > > > Hi Bhupesh, > > > > Do you have a corresponding patch for userspace tools, > > including crash util and/or makedumpfile? > > Otherwise, we c

Re: [alsa-devel] [PATCH V3 1/2] ASoC: dt-bindings: fsl_asrc: add compatible string for imx8qm

2019-11-14 Thread Shengjiu Wang
Hi Rob On Fri, Nov 15, 2019 at 5:14 AM Rob Herring wrote: > > On Mon, Nov 11, 2019 at 05:18:22PM +0800, Shengjiu Wang wrote: > > Add compatible string "fsl,imx8qm-asrc" for imx8qm platform. > > > > There are two asrc modules in imx8qm, the clock mapping is > > different for each other, so add new

Re: [PATCH v2 1/2] mm: remove the memory isolate notifier

2019-11-14 Thread Greg Kroah-Hartman
On Thu, Nov 14, 2019 at 02:19:10PM +0100, David Hildenbrand wrote: > Luckily, we have no users left, so we can get rid of it. Cleanup > set_migratetype_isolate() a little bit. > > Cc: Greg Kroah-Hartman > Cc: "Rafael J. Wysocki" > Cc: Andrew Morton > Cc: Pavel Tatashin > Cc: Michal Hocko > Cc

Re: [PATCH 00/50] Add log level to show_stack()

2019-11-14 Thread Sergey Senozhatsky
On (19/11/13 10:39), Steven Rostedt wrote: [..] > > void show_stack(struct task_struct *task, unsigned long *sp, int log_level) > > { > > printk_emergency_enter(log_level); > > __show_stack(task, sp); > > printk_emergency_exit(); > > } > > // - - - - - - - - - - - - - - - - - - - - - -

Re: [PATCH v4 32/47] serial: ucc_uart: use of_property_read_u32() in ucc_uart_probe()

2019-11-14 Thread Timur Tabi
On Fri, Nov 8, 2019 at 7:03 AM Rasmus Villemoes wrote: > > + if (of_property_read_u32(np, "cell-index", &val) && > + of_property_read_u32(np, "device-id", &val)) { I know that this is technically correct, but it's obfuscated IMHO. 'val' is set correctly only when of_property_read_

Re: [PATCH] powerpc/powernv: Disable native PCIe port management

2019-11-14 Thread Michael Ellerman
Tyrel Datwyler writes: > Nothing but pedantic spelling and grammar nits of the commit log follow. Thanks, they were annoying me :) cheers > On 11/13/19 1:40 AM, Oliver O'Halloran wrote: >> On PowerNV the PCIe topology is (currently) managed the powernv platform > > s/the powernv/by the powernv

Re: [PATCH 02/10] nvdimm: remove prototypes for nonexistent functions

2019-11-14 Thread Dan Williams
On Thu, Oct 24, 2019 at 9:49 PM Alastair D'Silva wrote: > > From: Alastair D'Silva > > These functions don't exist, so remove the prototypes for them. > > Signed-off-by: Alastair D'Silva Looks good, applied.

Re: [PATCH v4 46/47] net: ethernet: freescale: make UCC_GETH explicitly depend on PPC32

2019-11-14 Thread Timur Tabi
On Fri, Nov 8, 2019 at 7:04 AM Rasmus Villemoes wrote: > > Currently, QUICC_ENGINE depends on PPC32, so this in itself does not > change anything. In order to allow removing the PPC32 dependency from > QUICC_ENGINE and avoid allmodconfig build failures, add this explicit > dependency. Can you add

Re: [PATCH v4 45/47] net/wan/fsl_ucc_hdlc: reject muram offsets above 64K

2019-11-14 Thread Timur Tabi
On Fri, Nov 8, 2019 at 7:04 AM Rasmus Villemoes wrote: > diff --git a/drivers/net/wan/fsl_ucc_hdlc.c b/drivers/net/wan/fsl_ucc_hdlc.c > index 8d13586bb774..f029eaa7cfc0 100644 > --- a/drivers/net/wan/fsl_ucc_hdlc.c > +++ b/drivers/net/wan/fsl_ucc_hdlc.c > @@ -245,6 +245,11 @@ static int uhdlc_ini

Re: WARN_ONCE does not warn once

2019-11-14 Thread Michael Ellerman
Michal Suchánek writes: > On Thu, Nov 14, 2019 at 05:46:55PM +0100, Michal Suchánek wrote: >> Hello, >> >> on powernv with 5.3.8 kernel I get flood of messages on boot. >> >> The messages match WARN_ONCE(1, "opal: OPAL_CONSOLE_FLUSH missing.\n"); > > Asking around it was pointed out that WARN_ON

Re: [PATCH v4 07/47] soc: fsl: qe: qe.c: guard use of pvr_version_is() with CONFIG_PPC32

2019-11-14 Thread Timur Tabi
On Fri, Nov 8, 2019 at 7:04 AM Rasmus Villemoes wrote: > > +static bool qe_general4_errata(void) > +{ > +#ifdef CONFIG_PPC32 > + return pvr_version_is(PVR_VER_836x) || pvr_version_is(PVR_VER_832x); > +#endif > + return false; > +} > + > /* Program the BRG to the given sampling rate an

[4.14] Backport request: powerpc/perf: Fix IMC_MAX_PMU macro

2019-11-14 Thread Andrew Donnellan
Dear stable team Please backport the following patch. Commit: 7029d1eb0c2c7ee093dc625c679fc277c8eb623b ("powerpc/perf: Fix IMC_MAX_PMU macro") Stable tree targeted: 4.14 (applies cleanly) Justification: This fixes some Oopses observed on boot on one of our POWER9 boxes. Fix was identi

Re: [4.14] Backport request: powerpc/perf: Fix IMC_MAX_PMU macro

2019-11-14 Thread Andrew Donnellan
On 15/11/19 4:37 pm, Andrew Donnellan wrote: Dear stable team Please backport the following patch. Commit: 7029d1eb0c2c7ee093dc625c679fc277c8eb623b ("powerpc/perf: Fix IMC_MAX_PMU macro") Whoops, this was a local SHA - I meant 73ce9aec65b17433e18163d07eb5cb6bf114bd6c. There's also 110

Re: [PATCH v4 46/47] net: ethernet: freescale: make UCC_GETH explicitly depend on PPC32

2019-11-14 Thread Li Yang
On Thu, Nov 14, 2019 at 10:37 PM Timur Tabi wrote: > > On Fri, Nov 8, 2019 at 7:04 AM Rasmus Villemoes > wrote: > > > > Currently, QUICC_ENGINE depends on PPC32, so this in itself does not > > change anything. In order to allow removing the PPC32 dependency from > > QUICC_ENGINE and avoid allmodc

[PATCH v5 09/24] vfio, mm: fix get_user_pages_remote() and FOLL_LONGTERM

2019-11-14 Thread John Hubbard
As it says in the updated comment in gup.c: current FOLL_LONGTERM behavior is incompatible with FAULT_FLAG_ALLOW_RETRY because of the FS DAX check requirement on vmas. However, the corresponding restriction in get_user_pages_remote() was slightly stricter than is actually required: it forbade all

[PATCH v5 19/24] vfio, mm: pin_user_pages (FOLL_PIN) and put_user_page() conversion

2019-11-14 Thread John Hubbard
1. Change vfio from get_user_pages_remote(), to pin_user_pages_remote(). 2. Because all FOLL_PIN-acquired pages must be released via put_user_page(), also convert the put_page() call over to put_user_pages_dirty_lock(). Note that this effectively changes the code's behavior in vfio_iommu_type1.c:

[PATCH v5 18/24] media/v4l2-core: pin_user_pages (FOLL_PIN) and put_user_page() conversion

2019-11-14 Thread John Hubbard
1. Change v4l2 from get_user_pages() to pin_user_pages(). 2. Because all FOLL_PIN-acquired pages must be released via put_user_page(), also convert the put_page() call over to put_user_pages_dirty_lock(). Acked-by: Hans Verkuil Cc: Ira Weiny Signed-off-by: John Hubbard --- drivers/media/v4l2-

[PATCH v5 16/24] net/xdp: set FOLL_PIN via pin_user_pages()

2019-11-14 Thread John Hubbard
Convert net/xdp to use the new pin_longterm_pages() call, which sets FOLL_PIN. Setting FOLL_PIN is now required for code that requires tracking of pinned pages. In partial anticipation of this work, the net/xdp code was already calling put_user_page() instead of put_page(). Therefore, in order to

[PATCH v5 04/24] mm: Cleanup __put_devmap_managed_page() vs ->page_free()

2019-11-14 Thread John Hubbard
From: Dan Williams After the removal of the device-public infrastructure there are only 2 ->page_free() call backs in the kernel. One of those is a device-private callback in the nouveau driver, the other is a generic wakeup needed in the DAX case. In the hopes that all ->page_free() callbacks ca

[PATCH v5 06/24] goldish_pipe: rename local pin_user_pages() routine

2019-11-14 Thread John Hubbard
1. Avoid naming conflicts: rename local static function from "pin_user_pages()" to "pin_goldfish_pages()". An upcoming patch will introduce a global pin_user_pages() function. Reviewed-by: Jérôme Glisse Reviewed-by: Ira Weiny Signed-off-by: John Hubbard --- drivers/platform/goldfish/goldfish_

[PATCH v5 01/24] mm/gup: pass flags arg to __gup_device_* functions

2019-11-14 Thread John Hubbard
A subsequent patch requires access to gup flags, so pass the flags argument through to the __gup_device_* functions. Also placate checkpatch.pl by shortening a nearby line. Reviewed-by: Jan Kara Reviewed-by: Jérôme Glisse Reviewed-by: Ira Weiny Cc: Kirill A. Shutemov Signed-off-by: John Hubba

[PATCH v5 02/24] mm/gup: factor out duplicate code from four routines

2019-11-14 Thread John Hubbard
There are four locations in gup.c that have a fair amount of code duplication. This means that changing one requires making the same changes in four places, not to mention reading the same code four times, and wondering if there are subtle differences. Factor out the common code into static functi

  1   2   >