On Fri, Nov 8, 2019 at 7:04 AM Rasmus Villemoes <li...@rasmusvillemoes.dk> wrote: > > +static bool qe_general4_errata(void) > +{ > +#ifdef CONFIG_PPC32 > + return pvr_version_is(PVR_VER_836x) || pvr_version_is(PVR_VER_832x); > +#endif > + return false; > +} > + > /* Program the BRG to the given sampling rate and multiplier > * > * @brg: the BRG, QE_BRG1 - QE_BRG16 > @@ -223,7 +231,7 @@ int qe_setbrg(enum qe_clock brg, unsigned int rate, > unsigned int multiplier) > /* Errata QE_General4, which affects some MPC832x and MPC836x SOCs, > says > that the BRG divisor must be even if you're not using divide-by-16 > mode. */
Can you also move this comment (and fix the comment formatting so that it's a proper function comment) to qe_general4_errata()?