Re: [PATCH v2 1/8] seq_file: introduce seq_open_data helper

2018-08-19 Thread Andy Shevchenko
On Sat, Aug 18, 2018 at 4:26 PM Rasmus Villemoes wrote: > > There are quite a few callers of seq_open that could be simplified by > setting the ->private member via the seq_open call instead of fetching > file->private_data afterwards. > I like this series, Reviewed-by: Andy Shevchenko P.S. ...

[PATCH v8 0/5] powerpc/pseries: Machine check handler improvements.

2018-08-19 Thread Mahesh J Salgaonkar
This patch series includes some improvement to Machine check handler for pSeries. First 3 patches from v7 revision are already in powerpc next. Posting rest of the patches with review comments. This patch series drops the sysctl knob patch that was proposed in v7. The SLB recovery code now uses flu

[PATCH v8 1/5] powerpc/pseries: Define MCE error event section.

2018-08-19 Thread Mahesh J Salgaonkar
From: Mahesh Salgaonkar On pseries, the machine check error details are part of RTAS extended event log passed under Machine check exception section. This patch adds the definition of rtas MCE event section and related helper functions. Signed-off-by: Mahesh Salgaonkar --- Change in V8: - Move

[PATCH v8 2/5] powerpc/pseries: flush SLB contents on SLB MCE errors.

2018-08-19 Thread Mahesh J Salgaonkar
From: Mahesh Salgaonkar On pseries, as of today system crashes if we get a machine check exceptions due to SLB errors. These are soft errors and can be fixed by flushing the SLBs so the kernel can continue to function instead of system crash. We do this in real mode before turning on MMU. Otherwi

[PATCH v8 3/5] powerpc/pseries: Display machine check error details.

2018-08-19 Thread Mahesh J Salgaonkar
From: Mahesh Salgaonkar Extract the MCE error details from RTAS extended log and display it to console. With this patch you should now see mce logs like below: [ 142.371818] Severe Machine check interrupt [Recovered] [ 142.371822] NIP [dca301b8]: init_module+0x1b8/0x338 [bork_kernel

[PATCH v8 4/5] powerpc/pseries: Dump the SLB contents on SLB MCE errors.

2018-08-19 Thread Mahesh J Salgaonkar
From: Mahesh Salgaonkar If we get a machine check exceptions due to SLB errors then dump the current SLB contents which will be very much helpful in debugging the root cause of SLB errors. Introduce an exclusive buffer per cpu to hold faulty SLB entries. In real mode mce handler saves the old SLB

[PATCH v8 5/5] powernv/pseries: consolidate code for mce early handling.

2018-08-19 Thread Mahesh J Salgaonkar
From: Mahesh Salgaonkar Now that other platforms also implements real mode mce handler, lets consolidate the code by sharing existing powernv machine check early code. Rename machine_check_powernv_early to machine_check_common_early and reuse the code. Signed-off-by: Mahesh Salgaonkar --- arch

[PATCH 7/9] PCI: hotplug: Drop hotplug_slot_info

2018-08-19 Thread Lukas Wunner
Ever since the PCI hotplug core was introduced in 2002, drivers had to allocate and register a struct hotplug_slot_info for every slot: https://git.kernel.org/tglx/history/c/a8a2069f432c Apparently the idea was that drivers furnish the hotplug core with an up-to-date card presence status, power st

[PATCH 6/9] PCI: hotplug: Constify hotplug_slot_ops

2018-08-19 Thread Lukas Wunner
Hotplug drivers cannot declare their hotplug_slot_ops const, making them attractive targets for attackers, because upon registration of a hotplug slot, __pci_hp_initialize() writes to the "owner" and "mod_name" members in that struct. Fix by moving these members to struct hotplug_slot and constify

[PATCH 8/9] PCI: hotplug: Embed hotplug_slot

2018-08-19 Thread Lukas Wunner
When the PCI hotplug core and its first user, cpqphp, were introduced in February 2002 with historic commit a8a2069f432c, cpqphp allocated a slot struct for its internal use plus a hotplug_slot struct to be registered with the hotplug core and linked the two with pointers: https://git.kernel.org/tg

[PATCH 0/9] PCI hotplug diet

2018-08-19 Thread Lukas Wunner
Here's PCI hotplug material I've prepared for v4.20: Patches [1/9] to [8/9] reduce the code by 488 lines. There should be no loss of functionality and no new features, just less and simpler code. Patch [9/9] collects TODOs for hotplug drivers to spur contributions. I've assumed that my patch "

[PATCH NEXT v2 2/4] powerpc/pasemi: Add Nemo board IRQ initroutine

2018-08-19 Thread Darren Stevens
Add a IRQ init routine for the Nemo board which inits and attatches the i8259 found in the SB600, and a cascade routine to dispatch the interrupts. Signed-off-by: Darren Stevens --- diff --git a/arch/powerpc/platforms/pasemi/setup.c b/arch/powerpc/platforms/pasemi/setup.c index 9a6eb04..fad5280

[PATCH NEXT v2 1/4] powerpc/pasemi: Add PCI initialisation for Nemo board.

2018-08-19 Thread Darren Stevens
The A-Eon Amigaone X1000's Nemo motherboard has an AMD SB600 connected to one of the PCI-e root ports on its PaSemi Pwrficient 1628M SoC. Normally the SB600 southbridge would be connected to a hidden PCI-e port on the system's northbridge, and as a result doesn't fully comply with the PCI-e spec.

[PATCH NEXT v2 3/4] powerpc/pasemi: Add Nemo board device init code.

2018-08-19 Thread Darren Stevens
Add routines for Nemo specific devices to init at boot time, these being board level power-off and SB600's rtc. Also add a run time variable to prevent these being activated if we boot on a reference board. Signed-off-by: Darren Stevens --- Changes made: v2: Merged some #ifdef blocksd

[PATCH NEXT v2 4/4] powerpc/pasemi: Connect Nemo boot code.

2018-08-19 Thread Darren Stevens
The previous 3 commits added support code for the Nemo motherbard as used in the Amigaone X1000, now wire them up so the board can be detected and initalised at boot time. Signed-off-by: Darren Stevens --- Changes made: v2: Changed init code to be empty when NEMO=n rather than using #i

[PATCH] powerpc: configs: Update skiroot defconfig

2018-08-19 Thread Joel Stanley
Disable new features from recent releases, and clean out some other unused options: - Enable EXPERT, so we can disable some things - Disable non-powerpc BPF decoders - Disable TASKSTATS - Disable unused syscalls - Set more things to be modules - Turn off unused network vendors Signed-off-by

[PATCH v7 0/2] powerpc: Detection and scheduler optimization for POWER9 bigcore

2018-08-19 Thread Gautham R. Shenoy
From: "Gautham R. Shenoy" Hi, This is the seventh iteration of the patchset to add support for big-core on POWER9. This patch also optimizes the task placement on such big-core systems. The previous versions can be found here: v6: https://lkml.org/lkml/2018/8/9/119 v5: https://lkml.org/lkml/20

[PATCH v7 1/2] powerpc: Detect the presence of big-cores via "ibm, thread-groups"

2018-08-19 Thread Gautham R. Shenoy
From: "Gautham R. Shenoy" On IBM POWER9, the device tree exposes a property array identifed by "ibm,thread-groups" which will indicate which groups of threads share a particular set of resources. As of today we only have one form of grouping identifying the group of threads in the core that shar

[PATCH v7 2/2] powerpc: Use cpu_smallcore_sibling_mask at SMT level on bigcores

2018-08-19 Thread Gautham R. Shenoy
From: "Gautham R. Shenoy" Each of the SMT4 cores forming a big-core are more or less independent units. Thus when multiple tasks are scheduled to run on the fused core, we get the best performance when the tasks are spread across the pair of SMT4 cores. This patch achieves this by setting the SM

Re: [PATCH 3/3] powerpc/mm/ Add proper pte access check helper

2018-08-19 Thread Christophe LEROY
Le 17/08/2018 à 17:12, Christophe LEROY a écrit : Le 04/12/2017 à 03:19, Aneesh Kumar K.V a écrit : pte_access_premitted get called in get_user_pages_fast path. If we have marked the pte PROT_NONE, we should not allow a read access on the address. With the current implementation we are not

Re: [PATCH 1/3] arch/powerpc/hugetlb: Use pte_access_permitted for hugetlb access check

2018-08-19 Thread Christophe LEROY
Le 04/12/2017 à 03:19, Aneesh Kumar K.V a écrit : No functional change in this patch. This update gup_hugepte to use the helper. This will help later when we add memory keys. Signed-off-by: Aneesh Kumar K.V --- arch/powerpc/mm/hugetlbpage.c | 4 +--- 1 file changed, 1 insertion(+), 3 dele

Re: [PATCH v6 00/11] hugetlb: Factorize hugetlb architecture primitives

2018-08-19 Thread Alexandre Ghiti
Hi Michal, This patchset got acked, tested and reviewed by quite a few people, and it has been suggested that it should be included in -mm tree: could you tell me if something else needs to be done for its inclusion ? Thanks for your time, Alex On 08/06/2018 07:57 PM, Alexandre Ghiti wrote