Re: [patch] ppc/cell: missing error code in spufs_mkgang()

2016-08-04 Thread Arnd Bergmann
On Thursday, August 4, 2016 8:37:03 AM CEST Dan Carpenter wrote: > We should return -ENOMEM if alloc_spu_gang() fails. > > Signed-off-by: Dan Carpenter > Acked-by: Arnd Bergmann

Re: [PATCH v2] powernv: Simplify searching for compatible device nodes

2016-08-04 Thread Cyril Bur
On Wed, 3 Aug 2016 12:18:00 -0500 Jack Miller wrote: > (rebased on powerpc/next) > > This condenses the opal node searching into a single function that finds > all compatible nodes, instead of just searching the ibm,opal children, > for ipmi, flash, and prd similar to how opal-i2c nodes are fou

Re: [PATCH] powerpc: Align hot loops of memset() and backwards_memcpy()

2016-08-04 Thread Christophe Leroy
Le 04/08/2016 à 08:53, Anton Blanchard a écrit : From: Anton Blanchard Align the hot loops in our assembly implementation of memset() and backwards_memcpy(). backwards_memcpy() is called from tcp_v4_rcv(), so we might want to optimise this a little more. Signed-off-by: Anton Blanchard Sho

Re: [PATCH] powerpc/book3s: Fix MCE console messages for unrecoverable MCE.

2016-08-04 Thread Greg KH
On Thu, Aug 04, 2016 at 10:16:48AM +0530, Mahesh J Salgaonkar wrote: > From: Mahesh Salgaonkar > > When machine check occurs with MSR(RI=0), it means MC interrupt is > unrecoverable and kernel goes down to panic path. But the console > message still shows it as recovered. This patch fixes the MCE

Re: [PATCH v13 06/30] powerpc/ptrace: Adapt gpr32_get, gpr32_set functions for transaction

2016-08-04 Thread Michael Ellerman
Daniel Axtens writes: > [ Unknown signature status ] > Hi all, > > This is causing cppcheck warnings (having just landed in next): > > [arch/powerpc/kernel/ptrace.c:2062]: (error) Uninitialized variable: ckpt_regs > [arch/powerpc/kernel/ptrace.c:2130]: (error) Uninitialized variable: ckpt_regs S

Re: [PATCH] crypto: crc32c-vpmsum - Convert to CPU feature based module autoloading

2016-08-04 Thread Michael Ellerman
Anton Blanchard writes: > From: Anton Blanchard > > This patch utilises the GENERIC_CPU_AUTOPROBE infrastructure > to automatically load the crc32c-vpmsum module if the CPU supports > it. > > Signed-off-by: Anton Blanchard > --- > arch/powerpc/crypto/crc32c-vpmsum_glue.c | 3 ++- > 1 file chan

Re: [PATCH v2] powernv: Simplify searching for compatible device nodes

2016-08-04 Thread Michael Ellerman
Cyril Bur writes: > On Wed, 3 Aug 2016 12:18:00 -0500 > Jack Miller wrote: > >> (rebased on powerpc/next) >> >> This condenses the opal node searching into a single function that finds >> all compatible nodes, instead of just searching the ibm,opal children, >> for ipmi, flash, and prd similar

Re: [PATCH v2 3/3] powernv: Fix MCE handler to avoid trashing CR0/CR1 registers.

2016-08-04 Thread Mahesh Jagannath Salgaonkar
On 08/04/2016 09:44 AM, Stewart Smith wrote: > Mahesh J Salgaonkar writes: >> From: Mahesh Salgaonkar >> >> The current implementation of MCE early handling modifies CR0/1 registers >> without saving its old values. Fix this by moving early check for >> powersaving mode to machine_check_handle_ea

Re: [PATCH] powerpc/book3s: Fix MCE console messages for unrecoverable MCE.

2016-08-04 Thread Mahesh Jagannath Salgaonkar
On 08/04/2016 01:35 PM, Greg KH wrote: > On Thu, Aug 04, 2016 at 10:16:48AM +0530, Mahesh J Salgaonkar wrote: >> From: Mahesh Salgaonkar >> >> When machine check occurs with MSR(RI=0), it means MC interrupt is >> unrecoverable and kernel goes down to panic path. But the console >> message still sh

Re: powerpc allyesconfig / allmodconfig linux-next next-20160729 - next-20160729 build failures

2016-08-04 Thread Arnd Bergmann
On Thursday, August 4, 2016 10:10:51 AM CEST Stephen Rothwell wrote: > Hi Arnd, > > On Wed, 03 Aug 2016 20:52:48 +0200 Arnd Bergmann wrote: > > > > Most of the difference appears to be in branch trampolines (634 added, > > 559 removed, 14837 unchanged) as you suspect, but I also see a couple > >

Re: [RESEND][PATCH v2 1/2] kexec: refactor code parsing size based on memory range

2016-08-04 Thread Dave Young
Hi Hari, On 08/04/16 at 01:03am, Hari Bathini wrote: > crashkernel parameter supports different syntaxes to specify the amount > of memory to be reserved for kdump kernel. Below is one of the supported > syntaxes that needs parsing to find the memory size to reserve, based on > memory range: > >

mm: Initialise per_cpu_nodestats for all online pgdats at boot

2016-08-04 Thread Mel Gorman
Paul Mackerras and Reza Arbab reported that machines with memoryless nodes fails when vmstats are refreshed. Paul reported an oops as follows [1.713998] Unable to handle kernel paging request for data at address 0xff7a1 [1.714164] Faulting instruction address: 0xc0270cd0 [

Re: [PATCH] powerpc/xics: Properly set Edge/Level type and enable resend

2016-08-04 Thread Benjamin Herrenschmidt
On Thu, 2016-08-04 at 14:40 +1000, Michael Ellerman wrote: > > Finally now that edge interrupts are properly identified, we can enable > > CONFIG_HARDIRQS_SW_RESEND which will make the core re-send them if > > they occur while masked, which some drivers rely upon. > > > > This fixes issues with los

Re: [RESEND][PATCH v2 2/2] powerpc/fadump: parse fadump reserve memory size based on memory range

2016-08-04 Thread Michael Ellerman
Hari Bathini writes: ... > /** > * fadump_calculate_reserve_size(): reserve variable boot area 5% of System > RAM > * > @@ -212,12 +262,17 @@ static inline unsigned long > fadump_calculate_reserve_size(void) > { > unsigned long size; > > + /* sets fw_dump.reserve_bootvar */ > +

Re: [PATCH] powerpc/book3s: Fix MCE console messages for unrecoverable MCE.

2016-08-04 Thread Michael Ellerman
Mahesh Jagannath Salgaonkar writes: > On 08/04/2016 01:35 PM, Greg KH wrote: >> On Thu, Aug 04, 2016 at 10:16:48AM +0530, Mahesh J Salgaonkar wrote: >>> From: Mahesh Salgaonkar >>> >>> When machine check occurs with MSR(RI=0), it means MC interrupt is >>> unrecoverable and kernel goes down to pa

Re: [PATCH] powerpc/book3s: Fix MCE console messages for unrecoverable MCE.

2016-08-04 Thread Michael Ellerman
Mahesh J Salgaonkar writes: > From: Mahesh Salgaonkar > > When machine check occurs with MSR(RI=0), it means MC interrupt is > unrecoverable and kernel goes down to panic path. But the console > message still shows it as recovered. This patch fixes the MCE console > messages. > > Signed-off-by:

Re: [PATCH v2 3/3] powernv: Fix MCE handler to avoid trashing CR0/CR1 registers.

2016-08-04 Thread Michael Ellerman
Mahesh Jagannath Salgaonkar writes: > On 08/04/2016 09:44 AM, Stewart Smith wrote: >> Mahesh J Salgaonkar writes: >>> From: Mahesh Salgaonkar >>> >>> The current implementation of MCE early handling modifies CR0/1 registers >>> without saving its old values. Fix this by moving early check for >

Re: [Patch v2 01/10] driver/edac/mpc85xx_edac: Fix compiling error

2016-08-04 Thread Borislav Petkov
On Thu, Jul 28, 2016 at 03:30:55PM -0700, York Sun wrote: > Two symbols are missing if mpc85xx_edac driver is compiled as module. > > Signed-off-by: York Sun > --- > Change log > v2: no change > > arch/powerpc/kernel/pci-common.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arc

Re: [PATCH] crypto: crc32c-vpmsum - Convert to CPU feature based module autoloading

2016-08-04 Thread Anton Blanchard
Hi Michael, > Is VEC_CRYPTO the right feature? > > That's new power8 crypto stuff. The vpmsum* instructions are part of the same pipeline as the vcipher* instructions, introduced in POWER8. > I thought this only used VMX? (but I haven't looked closely) Yes, vcipher* and vpmsum* are VMX instruc

Re: [PATCH] powerpc: Align hot loops of memset() and backwards_memcpy()

2016-08-04 Thread Anton Blanchard
Hi Christophe, > > Align the hot loops in our assembly implementation of memset() > > and backwards_memcpy(). > > > > backwards_memcpy() is called from tcp_v4_rcv(), so we might > > want to optimise this a little more. > > > > Signed-off-by: Anton Blanchard > > Shouldn't this patch be titled p

Re: powerpc allyesconfig / allmodconfig linux-next next-20160729 - next-20160729 build failures

2016-08-04 Thread Arnd Bergmann
On Thursday, August 4, 2016 11:00:49 AM CEST Arnd Bergmann wrote: > I tried this > > diff --git a/scripts/link-vmlinux.sh b/scripts/link-vmlinux.sh > index b5e40ed86e60..89bca1a25916 100755 > --- a/scripts/link-vmlinux.sh > +++ b/scripts/link-vmlinux.sh > @@ -44,7 +44,7 @@ modpost_link() >

Re: powerpc allyesconfig / allmodconfig linux-next next-20160729 - next-20160729 build failures

2016-08-04 Thread Nicholas Piggin
On Thu, 04 Aug 2016 12:37:41 +0200 Arnd Bergmann wrote: > On Thursday, August 4, 2016 11:00:49 AM CEST Arnd Bergmann wrote: > > I tried this > > > > diff --git a/scripts/link-vmlinux.sh b/scripts/link-vmlinux.sh > > index b5e40ed86e60..89bca1a25916 100755 > > --- a/scripts/link-vmlinux.sh > > ++

Re: [PATCH] powerpc/book3s: Fix MCE console messages for unrecoverable MCE.

2016-08-04 Thread Mahesh Jagannath Salgaonkar
On 08/04/2016 03:27 PM, Michael Ellerman wrote: > Mahesh J Salgaonkar writes: > >> From: Mahesh Salgaonkar >> >> When machine check occurs with MSR(RI=0), it means MC interrupt is >> unrecoverable and kernel goes down to panic path. But the console >> message still shows it as recovered. This pa

Re: powerpc allyesconfig / allmodconfig linux-next next-20160729 - next-20160729 build failures

2016-08-04 Thread Arnd Bergmann
On Thursday, August 4, 2016 9:47:13 PM CEST Nicholas Piggin wrote: > On Thu, 04 Aug 2016 12:37:41 +0200 Arnd Bergmann wrote: > > On Thursday, August 4, 2016 11:00:49 AM CEST Arnd Bergmann wrote: > > > I tried this > > > > > > diff --git a/scripts/link-vmlinux.sh b/scripts/link-vmlinux.sh > > > in

[PATCH 0/7] ima: carry the measurement list across kexec

2016-08-04 Thread Mimi Zohar
The TPM PCRs are only reset on a hard reboot. In order to validate a TPM's quote after a soft reboot (eg. kexec -e), the IMA measurement list of the running kernel must be saved and then restored on the subsequent boot. The existing securityfs binary_runtime_measurements file conveniently provide

[PATCH 1/7] ima: on soft reboot, restore the measurement list

2016-08-04 Thread Mimi Zohar
The TPM PCRs are only reset on a hard reboot. In order to validate a TPM's quote after a soft reboot (eg. kexec -e), the IMA measurement list of the running kernel must be saved and restored on boot. This patch restores the measurement list. Changelog: - call ima_load_kexec_buffer() (Thiago) Si

[PATCH 2/7] ima: permit duplicate measurement list entries

2016-08-04 Thread Mimi Zohar
Measurements carried across kexec need to be added to the IMA measurement list, but should not prevent measurements of the newly booted kernel from being added to the measurement list. This patch adds support for allowing duplicate measurements. The "boot_aggregate" measurement entry is the delimi

[PATCH 3/7] ima: maintain memory size needed for serializing the measurement list

2016-08-04 Thread Mimi Zohar
In preparation for serializing the binary_runtime_measurements, this patch maintains the amount of memory required. Signed-off-by: Mimi Zohar --- security/integrity/ima/Kconfig | 12 ++ security/integrity/ima/ima.h | 1 + security/integrity/ima/ima_queue.c | 49 +++

[PATCH 4/7] ima: serialize the binary_runtime_measurements

2016-08-04 Thread Mimi Zohar
The TPM PCRs are only reset on a hard reboot. In order to validate a TPM's quote after a soft reboot (eg. kexec -e), the IMA measurement list of the running kernel must be saved and restored on boot. This patch serializes the IMA measurement list in the binary_runtime_measurements format. Signed

[PATCH 5/7] ima: on soft reboot, save the measurement list

2016-08-04 Thread Mimi Zohar
From: Thiago Jung Bauermann This patch uses the kexec buffer passing mechanism to pass the serialized IMA binary_runtime_measurements to the next kernel. Changelog: - updated to call IMA functions (Mimi) - move code from ima_template.c to ima_kexec.c (Mimi) Signed-off-by: Thiago Jung Bauermann

[PATCH 6/7] ima: store the builtin/custom template definitions in a list

2016-08-04 Thread Mimi Zohar
The builtin and single custom templates are currently stored in an array. In preparation for being able to restore a measurement list containing multiple builtin/custom templates, this patch stores the builtin and custom templates as a linked list. This will permit defining more than one custom t

[PATCH 7/7] ima: support restoring multiple template formats

2016-08-04 Thread Mimi Zohar
The configured IMA measurement list template format can be replaced at runtime on the boot command line, including a custom template format. This patch adds support for restoring a measuremement list containing multiple builtin/custom template formats. Signed-off-by: Mimi Zohar --- security/inte

Re: powerpc allyesconfig / allmodconfig linux-next next-20160729 - next-20160729 build failures

2016-08-04 Thread Nicholas Piggin
On Thu, 04 Aug 2016 14:09:02 +0200 Arnd Bergmann wrote: > On Thursday, August 4, 2016 9:47:13 PM CEST Nicholas Piggin wrote: > > On Thu, 04 Aug 2016 12:37:41 +0200 Arnd Bergmann wrote: > > > On Thursday, August 4, 2016 11:00:49 AM CEST Arnd Bergmann wrote: > > > > I tried this > > > > > > >

Re: [PATCH] powerpc/book3s: Fix MCE console messages for unrecoverable MCE.

2016-08-04 Thread Nicholas Piggin
On Thu, 4 Aug 2016 17:35:45 +0530 Mahesh Jagannath Salgaonkar wrote: > On 08/04/2016 03:27 PM, Michael Ellerman wrote: > > Mahesh J Salgaonkar writes: > > > >> From: Mahesh Salgaonkar > >> > >> When machine check occurs with MSR(RI=0), it means MC interrupt is > >> unrecoverable and kernel g

[pasemi] Radeon HD graphics card not recognised after the powerpc-4.8-1 commit

2016-08-04 Thread Christian Zigotzky
Hi All, I figured out that the Git kernel (4.8) successfully detected my Radeon HD6870 but Xorg can't access it. The reason is, that the BusID has changed between the kernel 4.7 and 4.8. Kernel 4.7: 01:00.0 VGA compatible controller: Advanced Micro Devices, Inc. [AMD/ATI] Barts XT [Radeon H

Re: powerpc allyesconfig / allmodconfig linux-next next-20160729 - next-20160729 build failures

2016-08-04 Thread Nicholas Piggin
On Thu, 4 Aug 2016 22:31:39 +1000 Nicholas Piggin wrote: > On Thu, 04 Aug 2016 14:09:02 +0200 > Arnd Bergmann wrote: > > Nicolas Pitre has done some related work, adding him to Cc. IIRC we have > > actually had multiple implementations of -ffunction-sections/--gc-sections > > in the past that peo

[PATCH] cxl: Use fixed width predefined types in data structure.

2016-08-04 Thread Philippe Bergheaud
This patch fixes a regression introduced by commit b810253. It substitutes the type __u8 to u8 in the uapi header cxl.h, because the latter is not always defined in userland build environments, in particular when cross-compiling libcxl on x86_64 linux machines (RHEL6.7 and Ubuntu 16.04). It also m

[PATCH] fadump: Register the memory reserved by fadump

2016-08-04 Thread Srikar Dronamraju
Fadump kernel reserves large chunks of memory even before the pages are initialized. This could mean memory that corresponds to several nodes might fall in memblock reserved regions. Kernels compiled with CONFIG_DEFERRED_STRUCT_PAGE_INIT will initialize only certain size memory per node. The certa

Re: [PATCH] fadump: Register the memory reserved by fadump

2016-08-04 Thread Mel Gorman
On Thu, Aug 04, 2016 at 07:12:45PM +0530, Srikar Dronamraju wrote: > Fadump kernel reserves large chunks of memory even before the pages are > initialized. This could mean memory that corresponds to several nodes might > fall in memblock reserved regions. > > Kernels compiled with CONFIG_DEFERRED_

RE: [PATCH] cxl: Use fixed width predefined types in data structure.

2016-08-04 Thread David Laight
From: Philippe Bergheaud > Sent: 04 August 2016 14:56 > This patch fixes a regression introduced by commit b810253. > It substitutes the type __u8 to u8 in the uapi header cxl.h, > because the latter is not always defined in userland build > environments, in particular when cross-compiling libcxl o

Re: [PATCH] fadump: Register the memory reserved by fadump

2016-08-04 Thread Srikar Dronamraju
* Mel Gorman [2016-08-04 15:09:34]: > > > > Suggested-by: Mel Gorman > > I didn't suggest this specifically. While it happens to be safe on ppc64, > it potentially overwrites any future caller of set_dma_reserve. While the > only other one is for the e820 map, it may be better to change the AP

[PATCH] cpufreq: powernv: Fix crash in gpstate_timer_handler

2016-08-04 Thread Akshay Adiga
'commit 09ca4c9b5958 ("cpufreq: powernv: Replacing pstate_id with frequency table index")' changes calc_global_pstate() to use cpufreq_table index instead of pstate_id. But in gpstate_timer_handler() pstate_id was being passed instead of cpufreq_table index, which caused the index_to_pstate() to a

Re: powerpc allyesconfig / allmodconfig linux-next next-20160729 - next-20160729 build failures

2016-08-04 Thread Arnd Bergmann
On Thursday, August 4, 2016 11:54:18 PM CEST Nicholas Piggin wrote: > On Thu, 4 Aug 2016 22:31:39 +1000 > Nicholas Piggin wrote: > > On Thu, 04 Aug 2016 14:09:02 +0200 > > Arnd Bergmann wrote: > > > Nicolas Pitre has done some related work, adding him to Cc. IIRC we have > > > actually had multip

Re: mm: Initialise per_cpu_nodestats for all online pgdats at boot

2016-08-04 Thread Reza Arbab
On Thu, Aug 04, 2016 at 10:24:04AM +0100, Mel Gorman wrote: This has been compile-tested and boot-tested on a 32-bit KVM only. A memoryless system was not available to test the patch with. A confirmation from Paul and Reza that it resolves their problem is welcome. Works for me. Thanks, Mel! T

Re: [PATCH v2] powernv: Simplify searching for compatible device nodes

2016-08-04 Thread Jack Miller
On Thu, Aug 04, 2016 at 06:39:24PM +1000, Michael Ellerman wrote: > Cyril Bur writes: > > > On Wed, 3 Aug 2016 12:18:00 -0500 > > Jack Miller wrote: > > > >> (rebased on powerpc/next) > >> > >> This condenses the opal node searching into a single function that finds > >> all compatible nodes,

Re: powerpc allyesconfig / allmodconfig linux-next next-20160729 - next-20160729 build failures

2016-08-04 Thread Arnd Bergmann
On Thursday, August 4, 2016 9:47:13 PM CEST Nicholas Piggin wrote: > + __used \ > + __attribute__((section("___kentry" "+" #sym ",\"a\",@note #"), used)) \ I've just started testing this, but the first problem I ran into is that @ and # ar

Re: [PATCH] cpufreq: powernv: Fix crash in gpstate_timer_handler

2016-08-04 Thread Viresh Kumar
On 04-08-16, 20:59, Akshay Adiga wrote: > 'commit 09ca4c9b5958 ("cpufreq: powernv: Replacing pstate_id with > frequency table index")' changes calc_global_pstate() to use > cpufreq_table index instead of pstate_id. > > But in gpstate_timer_handler() pstate_id was being passed instead > of cpufreq_

[v5.1] ucc_fast: Fix to avoid IS_ERR_VALUE abuses and dead code on 64bit systems.

2016-08-04 Thread Arvind Yadav
IS_ERR_VALUE() assumes that parameter is an unsigned long. It can not be used to check if 'unsigned int' is passed insted. Which tends to reflect an error. In 64bit architectures sizeof (int) == 4 && sizeof (long) == 8. IS_ERR_VALUE(x) is ((x) >= (unsigned long)-4095). IS_ERR_VALUE() of 'unsigned i

Re: powerpc allyesconfig / allmodconfig linux-next next-20160729 - next-20160729 build failures

2016-08-04 Thread Segher Boessenkool
On Thu, Aug 04, 2016 at 06:10:57PM +0200, Arnd Bergmann wrote: > On Thursday, August 4, 2016 9:47:13 PM CEST Nicholas Piggin wrote: > > > + __used \ > > + __attribute__((section("___kentry" "+" #sym ",\"a\",@note #"), used)) \ > > > I've just

Re: [PATCH v3 1/5] powerpc/dts: add mcke-gpios for PM feature

2016-08-04 Thread Rob Herring
On Tue, Aug 02, 2016 at 07:58:44PM +0800, Chenhui Zhao wrote: > Signed-off-by: Chenhui Zhao > --- > Documentation/devicetree/bindings/soc/fsl/rcpm.txt | 13 + > arch/powerpc/boot/dts/fsl/t1040si-post.dtsi| 3 +++ > 2 files changed, 16 insertions(+) > > diff --git a/Documenta

[PATCH V2 2/2] fadump: Register the memory reserved by fadump

2016-08-04 Thread Srikar Dronamraju
Fadump kernel reserves large chunks of memory even before the pages are initialized. This could mean memory that corresponds to several nodes might fall in memblock reserved regions. Kernels compiled with CONFIG_DEFERRED_STRUCT_PAGE_INIT will initialize only certain size memory per node. The certa

[PATCH V2 1/2] mm/page_alloc: Replace set_dma_reserve to set_memory_reserve

2016-08-04 Thread Srikar Dronamraju
Expand the scope of the existing dma_reserve to accommodate other memory reserves too. Accordingly rename variable dma_reserve to nr_memory_reserve. set_memory_reserve also takes a new parameter that helps to identify if the current value needs to be incremented. Suggested-by: Mel Gorman Signed-

Re: [Patch v2 01/10] driver/edac/mpc85xx_edac: Fix compiling error

2016-08-04 Thread Bjorn Helgaas
On Thu, Aug 04, 2016 at 12:01:17PM +0200, Borislav Petkov wrote: > On Thu, Jul 28, 2016 at 03:30:55PM -0700, York Sun wrote: > > Two symbols are missing if mpc85xx_edac driver is compiled as module. > > > > Signed-off-by: York Sun > > --- > > Change log > > v2: no change > > > > arch/powerpc/

Re: [RESEND][PATCH v2 2/2] powerpc/fadump: parse fadump reserve memory size based on memory range

2016-08-04 Thread Hari Bathini
On Thursday 04 August 2016 03:15 PM, Michael Ellerman wrote: Hari Bathini writes: ... /** * fadump_calculate_reserve_size(): reserve variable boot area 5% of System RAM * @@ -212,12 +262,17 @@ static inline unsigned long fadump_calculate_reserve_size(void) { unsigned long s

Re: [RESEND][PATCH v2 1/2] kexec: refactor code parsing size based on memory range

2016-08-04 Thread Hari Bathini
Hi Dave Thanks for the review.. On Thursday 04 August 2016 02:56 PM, Dave Young wrote: Hi Hari, On 08/04/16 at 01:03am, Hari Bathini wrote: crashkernel parameter supports different syntaxes to specify the amount of memory to be reserved for kdump kernel. Below is one of the supported syntax

[PATCH -net] net/ethernet: tundra: fix dump_eth_one warning in tsi108_eth

2016-08-04 Thread Paul Gortmaker
The call site for this function appears as: #ifdef DEBUG data->msg_enable = DEBUG; dump_eth_one(dev); #endif ...leading to the following warning for !DEBUG builds: drivers/net/ethernet/tundra/tsi108_eth.c:169:13: warning: 'dump_eth_one' defined but not used [-Wunused-functio

Re: [patch] powerpc/fsl_rio: fix a missing error code

2016-08-04 Thread Andrew Morton
On Thu, 4 Aug 2016 08:35:25 +0300 Dan Carpenter wrote: > We should set the error code here. Otherwise static checkers complain. > hm. > --- a/arch/powerpc/sysdev/fsl_rio.c > +++ b/arch/powerpc/sysdev/fsl_rio.c > @@ -491,6 +491,7 @@ int fsl_rio_setup(struct platform_device *dev) > rmu_n

Re: [v5.1] ucc_fast: Fix to avoid IS_ERR_VALUE abuses and dead code on 64bit systems.

2016-08-04 Thread Arnd Bergmann
On Thursday, August 4, 2016 10:22:43 PM CEST Arvind Yadav wrote: > index df8ea79..ada9070 100644 > --- a/include/soc/fsl/qe/ucc_fast.h > +++ b/include/soc/fsl/qe/ucc_fast.h > @@ -165,10 +165,12 @@ struct ucc_fast_private { > int stopped_tx; /* Whether channel has been stopped for Tx

Re: [PATCH V2 2/2] fadump: Register the memory reserved by fadump

2016-08-04 Thread Andrew Morton
On Thu, 4 Aug 2016 22:42:09 +0530 Srikar Dronamraju wrote: > Fadump kernel reserves large chunks of memory even before the pages are > initialized. This could mean memory that corresponds to several nodes might > fall in memblock reserved regions. > > Kernels compiled with CONFIG_DEFERRED_STRU

Re: [Patch v3 01/11] arch/powerpc/pci: Fix compiling error for mpc85xx_edac

2016-08-04 Thread Andrew Donnellan
On 05/08/16 08:58, York Sun wrote: Two symbols are missing if mpc85xx_edac driver is compiled as module. Signed-off-by: York Sun Good catch! One comment below. Reviewed-by: Andrew Donnellan /* * Reads the interrupt pin to determine if interrupt is use by card. @@ -1585,6 +1586,7 @@ int

[Patch v3 01/11] arch/powerpc/pci: Fix compiling error for mpc85xx_edac

2016-08-04 Thread York Sun
Two symbols are missing if mpc85xx_edac driver is compiled as module. Signed-off-by: York Sun --- Change log v3: Change subject tag v2: no change arch/powerpc/kernel/pci-common.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/powerpc/kernel/pci-common.c b/arch/powerpc/kernel/pc

Re: [PATCH v13 06/30] powerpc/ptrace: Adapt gpr32_get, gpr32_set functions for transaction

2016-08-04 Thread Daniel Axtens
Michael Ellerman writes: >> Is there a nice simple fix we could deploy to squash this warning, or >> will we just live with it? > > This series has been nothing but pain. Given we're already at v13, and people > really want this support to go in, I'm going to leave it in the tree. > > Once it's

Re: mm: Initialise per_cpu_nodestats for all online pgdats at boot

2016-08-04 Thread Paul Mackerras
On Thu, Aug 04, 2016 at 10:24:04AM +0100, Mel Gorman wrote: > Paul Mackerras and Reza Arbab reported that machines with memoryless nodes > fails when vmstats are refreshed. Paul reported an oops as follows > > [1.713998] Unable to handle kernel paging request for data at address > 0xff7a1

Re: [PATCH] crypto: powerpc - CRYPT_CRC32C_VPMSUM should depend on ALTIVEC

2016-08-04 Thread Michael Ellerman
Anton Blanchard writes: > Hi Michael, > >> The optimised crc32c implementation depends on VMX (aka. Altivec) >> instructions, so the kernel must be built with Altivec support in >> order for the crc32c code to build. > > Thanks for that, looks good. > > Acked-by: Anton Blanchard Thanks. Herbert

Re: [Patch v3 01/11] arch/powerpc/pci: Fix compiling error for mpc85xx_edac

2016-08-04 Thread Michael Ellerman
York Sun writes: > Two symbols are missing if mpc85xx_edac driver is compiled as module. > > Signed-off-by: York Sun > > --- > Change log > v3: Change subject tag > v2: no change > > arch/powerpc/kernel/pci-common.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/powerpc/ker

Re: [Patch v3 01/11] arch/powerpc/pci: Fix compiling error for mpc85xx_edac

2016-08-04 Thread york sun
On 08/04/2016 08:43 PM, Michael Ellerman wrote: > York Sun writes: > >> Two symbols are missing if mpc85xx_edac driver is compiled as module. >> >> Signed-off-by: York Sun >> >> --- >> Change log >> v3: Change subject tag >> v2: no change >> >> arch/powerpc/kernel/pci-common.c | 2 ++ >> 1 f

[PATCH 1/2] powerpc/pseries: Use a helper to fixup nr_cores

2016-08-04 Thread Sukadev Bhattiprolu
>From d49b597623ac58fa1ab61ce0157470b6390e9a67 Mon Sep 17 00:00:00 2001 From: Sukadev Bhattiprolu Date: Fri, 5 Aug 2016 00:01:54 -0400 Subject: [PATCH 1/2] powerpc/pseries: Use a helper to fixup nr_cores. We have to fixup RMA size also, so using helpers will make it cleaner and consistent. Sign

[PATCH 2/2] powerpc/pseries: Dynamically increase RMA size

2016-08-04 Thread Sukadev Bhattiprolu
>From ddce2a5f439111f08969d66ccc0c7b4d9196b69d Mon Sep 17 00:00:00 2001 From: Sukadev Bhattiprolu Date: Thu, 4 Aug 2016 23:13:37 -0400 Subject: [PATCH 2/2] powerpc/pseries: Dynamically increase RMA size When booting a very large system with a large initrd we run out of space for the flattened de

[PATCH] powerpc/pci: Only do fixed PHB numbering on powernv

2016-08-04 Thread Michael Ellerman
The recent commit 63a72284b159 ("powerpc/pci: Assign fixed PHB number based on device-tree properties"), added code to read a 64-bit property from the device tree, and if not found read a 32-bit property (reg). There was a bug in the 32-bit case, on big endian machines, due to the use of the 64-bi

Re: [PATCH V2 1/2] mm/page_alloc: Replace set_dma_reserve to set_memory_reserve

2016-08-04 Thread Vlastimil Babka
On 08/04/2016 07:12 PM, Srikar Dronamraju wrote: Expand the scope of the existing dma_reserve to accommodate other memory reserves too. Accordingly rename variable dma_reserve to nr_memory_reserve. set_memory_reserve also takes a new parameter that helps to identify if the current value needs to

Re: [pasemi] Radeon HD graphics card not recognised after the powerpc-4.8-1 commit

2016-08-04 Thread Michael Ellerman
Christian Zigotzky writes: > Hi All, > > I figured out that the Git kernel (4.8) successfully detected my Radeon > HD6870 but Xorg can't access it. > > The reason is, that the BusID has changed between the kernel 4.7 and 4.8. This should fix it? https://patchwork.ozlabs.org/patch/656042/ mp

Re: [PATCH V2 1/2] mm/page_alloc: Replace set_dma_reserve to set_memory_reserve

2016-08-04 Thread Mel Gorman
On Thu, Aug 04, 2016 at 10:42:08PM +0530, Srikar Dronamraju wrote: > Expand the scope of the existing dma_reserve to accommodate other memory > reserves too. Accordingly rename variable dma_reserve to > nr_memory_reserve. > > set_memory_reserve also takes a new parameter that helps to identify if

Re: [PATCH] crypto: crc32c-vpmsum - Convert to CPU feature based module autoloading

2016-08-04 Thread Michael Ellerman
Anton Blanchard writes: > Hi Michael, > >> Is VEC_CRYPTO the right feature? >> >> That's new power8 crypto stuff. > > The vpmsum* instructions are part of the same pipeline as the vcipher* > instructions, introduced in POWER8. OK. >> I thought this only used VMX? (but I haven't looked closely)

Re: [PATCH] powerpc/xics: Properly set Edge/Level type and enable resend

2016-08-04 Thread Michael Ellerman
Benjamin Herrenschmidt writes: > On Thu, 2016-08-04 at 14:40 +1000, Michael Ellerman wrote: >> > Finally now that edge interrupts are properly identified, we can enable >> > CONFIG_HARDIRQS_SW_RESEND which will make the core re-send them if >> > they occur while masked, which some drivers rely up

Re: [PATCH v2] powerpc/32: fix csum_partial_copy_generic()

2016-08-04 Thread Michael Ellerman
Alessio Igor Bogani writes: > On 4 August 2016 at 05:53, Scott Wood wrote: >> On Tue, 2016-08-02 at 10:07 +0200, Christophe Leroy wrote: >>> commit 7aef4136566b0 ("powerpc32: rewrite csum_partial_copy_generic() >>> based on copy_tofrom_user()") introduced a bug when destination >>> address is odd