Re: [RFC PATCH powerpc] Set cpu sibling mask before online cpu

2013-06-11 Thread Benjamin Herrenschmidt
On Thu, 2013-05-16 at 18:20 +0800, Li Zhong wrote: > It seems following race is possible: > .../... > vdso_getcpu_init(); > #endif > - notify_cpu_starting(cpu); > - set_cpu_online(cpu, true); > /* Update sibling maps */ > base = cpu_first_thread_sibling(cpu); >

Re: [BUG] PCI related panic on powerpc based board with 3.10-rcX

2013-06-11 Thread Rojhalat Ibrahim
On Monday 10 June 2013 17:52:33 Scott Wood wrote: > On 06/10/2013 12:07:43 PM, Michael Guntsche wrote: > > Good evening, > > > > On Mon, Jun 10, 2013 at 1:41 PM, Rojhalat Ibrahim > > > > wrote: > > > Hi Mike, > > > > > > could you please try this patch: > > > https://lists.ozlabs.org/pipermail/

Re: [PATCH 15/27] powerpc/eeh: I/O chip EEH state retrieval

2013-06-11 Thread Benjamin Herrenschmidt
On Wed, 2013-06-05 at 15:34 +0800, Gavin Shan wrote: > The patch adds I/O chip backend to retrieve the state for the > indicated PE. While the PE state is temperarily unavailable, > we return the default wait time (1000ms). > > Signed-off-by: Gavin Shan > --- > arch/powerpc/platforms/powernv/eeh

Re: [PATCH 17/27] powerpc/eeh: I/O chip PE log and bridge setup

2013-06-11 Thread Benjamin Herrenschmidt
On Wed, 2013-06-05 at 15:34 +0800, Gavin Shan wrote: > The patch adds backends to retrieve error log and configure p2p > bridges for the indicated PE. > > Signed-off-by: Gavin Shan > --- > +/** > + * ioda_eeh_configure_bridge - Configure the PCI bridges for the indicated PE > + * @pe: EEH PE > +

Re: [PATCH v3 00/27] EEH Support for PowerNV platform

2013-06-11 Thread Benjamin Herrenschmidt
On Wed, 2013-06-05 at 15:34 +0800, Gavin Shan wrote: > Initially, the series of patches is built based on 3.10.RC1 and the patchset > doesn't intend to enable EEH functionality for PHB3 for now. Obviously, PHB3 > EEH support on PowerNV platform is something to do in future. One thing missing here

Re: [PATCH 21/27] powerpc/eeh: Process interrupts caused by EEH

2013-06-11 Thread Benjamin Herrenschmidt
On Wed, 2013-06-05 at 15:34 +0800, Gavin Shan wrote: > diff --git a/arch/powerpc/include/asm/eeh.h b/arch/powerpc/include/asm/eeh.h > index d1fd5d4..68ac408 100644 > --- a/arch/powerpc/include/asm/eeh.h > +++ b/arch/powerpc/include/asm/eeh.h > @@ -209,6 +209,12 @@ void eeh_add_device_tree_late(str

Re: [RFC PATCH powerpc] Set cpu sibling mask before online cpu

2013-06-11 Thread Srivatsa S. Bhat
On 06/11/2013 12:30 PM, Benjamin Herrenschmidt wrote: > On Thu, 2013-05-16 at 18:20 +0800, Li Zhong wrote: >> It seems following race is possible: >> > > .../... > >> vdso_getcpu_init(); >> #endif >> -notify_cpu_starting(cpu); >> -set_cpu_online(cpu, true); >> /* Update siblin

Re: [RFC PATCH powerpc] Set cpu sibling mask before online cpu

2013-06-11 Thread Srivatsa S. Bhat
On 05/16/2013 03:50 PM, Li Zhong wrote: > It seems following race is possible: > > cpu0cpux > smp_init->cpu_up->_cpu_up > __cpu_up > kick_cpu(1) > - >

Re: [RFC PATCH powerpc] Set cpu sibling mask before online cpu

2013-06-11 Thread Benjamin Herrenschmidt
On Tue, 2013-06-11 at 14:03 +0530, Srivatsa S. Bhat wrote: > > So I agree with Li Zhong's solution. > > [Arch-specific CPU hotplug code consolidation efforts such as [1] would > have weeded out such nasty bugs.. I guess we should revive that patchset > sometime soon.] Thanks ! Cheers, Ben. __

RE: [PATCH 0/2 v3] powerpc: Make ptrace work reliably

2013-06-11 Thread Bhushan Bharat-R65777
Hi Ben, Ping; Please review this patchset .. Thanks -Bharat > -Original Message- > From: Bhushan Bharat-R65777 > Sent: Wednesday, May 22, 2013 9:51 AM > To: ga...@kernel.crashing.org; b...@kernel.crashing.org; linuxppc- > d...@lists.ozlabs.org; Wood Scott-B07421; Yoder Stuart-B08248; Y

Re: [BUG] PCI related panic on powerpc based board with 3.10-rcX

2013-06-11 Thread Scott Wood
On 06/11/2013 02:24:28 AM, Rojhalat Ibrahim wrote: On Monday 10 June 2013 17:52:33 Scott Wood wrote: > On 06/10/2013 12:07:43 PM, Michael Guntsche wrote: > > Good evening, > > > > This patch does not fix the problem, during boot the kernel still > > panics. I had a closer look at the commit and t

Re: [BUG] PCI related panic on powerpc based board with 3.10-rcX

2013-06-11 Thread Michael Guntsche
On Tue, Jun 11, 2013 at 7:00 PM, Scott Wood wrote: > On 06/11/2013 02:24:28 AM, Rojhalat Ibrahim wrote: >> >> On Monday 10 June 2013 17:52:33 Scott Wood wrote: >> > On 06/10/2013 12:07:43 PM, Michael Guntsche wrote: >> > > Good evening, >> > > >> > > This patch does not fix the problem, during boo

Re: [BUG] PCI related panic on powerpc based board with 3.10-rcX

2013-06-11 Thread Scott Wood
On 06/11/2013 12:09:42 PM, Michael Guntsche wrote: On Tue, Jun 11, 2013 at 7:00 PM, Scott Wood wrote: > On 06/11/2013 02:24:28 AM, Rojhalat Ibrahim wrote: >> >> On Monday 10 June 2013 17:52:33 Scott Wood wrote: >> > On 06/10/2013 12:07:43 PM, Michael Guntsche wrote: >> > > Good evening, >> > >

Re: [PATCH -V7 09/18] powerpc: Switch 16GB and 16MB explicit hugepages to a different page table format

2013-06-11 Thread Scott Wood
On 06/08/2013 11:57:48 AM, Aneesh Kumar K.V wrote: With the config shared I am not finding anything wrong, but I can't test these configs. Also can you confirm what you bisect this to e2b3d202d1dba8f3546ed28224ce485bc50010be powerpc: Switch 16GB and 16MB explicit hugepages to a different page

Re: [PATCH] powerpc/iommu: Remove unused pci_iommu_init() and pci_direct_iommu_init()

2013-06-11 Thread Benjamin Herrenschmidt
On Tue, 2013-06-11 at 13:57 -0600, Bjorn Helgaas wrote: > pci_iommu_init() and pci_direct_iommu_init() are not referenced anywhere, > so remove them. Ah indeed, some old stuff... Thanks, Ben. > Signed-off-by: Bjorn Helgaas > --- > arch/powerpc/include/asm/iommu.h |7 --- > 1 file chang

Re: [PATCH -V7 09/18] powerpc: Switch 16GB and 16MB explicit hugepages to a different page table format

2013-06-11 Thread Scott Wood
On 06/11/2013 03:53:43 PM, Scott Wood wrote: On 06/08/2013 11:57:48 AM, Aneesh Kumar K.V wrote: With the config shared I am not finding anything wrong, but I can't test these configs. Also can you confirm what you bisect this to e2b3d202d1dba8f3546ed28224ce485bc50010be powerpc: Switch 16GB an

Re: [PATCH 23/27] powernv/opal: Notifier for OPAL events

2013-06-11 Thread Benjamin Herrenschmidt
On Wed, 2013-06-05 at 15:34 +0800, Gavin Shan wrote: > The patch intends to implement the notifier for variable OPAL events. > It's notable that the notifier can be disabled dynamically. Also, the > notifier could be fired upon incoming OPAL interrupts, or enabling > the OPAL notifier. "This patch

Re: [PATCH 0/4 v3] KVM: PPC: IOMMU in-kernel handling

2013-06-11 Thread Benjamin Herrenschmidt
On Wed, 2013-06-05 at 16:11 +1000, Alexey Kardashevskiy wrote: > Ben, ping! :) > > This series has tiny fixes (capability and ioctl numbers, > changed documentation, compile errors in some configuration). > More details are in the commit messages. > Rebased on v3.10-rc4. Alex, I assume you'll mer

Re: [PATCH 23/27] powernv/opal: Notifier for OPAL events

2013-06-11 Thread Gavin Shan
On Wed, Jun 12, 2013 at 10:32:29AM +1000, Benjamin Herrenschmidt wrote: >On Wed, 2013-06-05 at 15:34 +0800, Gavin Shan wrote: >> The patch intends to implement the notifier for variable OPAL events. >> It's notable that the notifier can be disabled dynamically. Also, the >> notifier could be fired

Re: [PATCH v3 00/27] EEH Support for PowerNV platform

2013-06-11 Thread Gavin Shan
On Tue, Jun 11, 2013 at 05:46:24PM +1000, Benjamin Herrenschmidt wrote: >On Wed, 2013-06-05 at 15:34 +0800, Gavin Shan wrote: >> Initially, the series of patches is built based on 3.10.RC1 and the patchset >> doesn't intend to enable EEH functionality for PHB3 for now. Obviously, PHB3 >> EEH suppor

Re: [PATCH] powerpc/sysfs: disable hotplug for the boot cpu

2013-06-11 Thread Benjamin Herrenschmidt
On Mon, 2013-06-03 at 18:43 +0800, Zhao Chenhui wrote: > On Sat, Jun 01, 2013 at 07:49:44AM +1000, Benjamin Herrenschmidt wrote: > > On Tue, 2013-05-28 at 15:59 +0800, Zhao Chenhui wrote: > > > Some features depend on the boot cpu, for instance, hibernate/suspend. > > > So disable hotplug for the b

Re: [PATCH 15/27] powerpc/eeh: I/O chip EEH state retrieval

2013-06-11 Thread Gavin Shan
On Tue, Jun 11, 2013 at 05:37:04PM +1000, Benjamin Herrenschmidt wrote: >On Wed, 2013-06-05 at 15:34 +0800, Gavin Shan wrote: >> The patch adds I/O chip backend to retrieve the state for the >> indicated PE. While the PE state is temperarily unavailable, >> we return the default wait time (1000ms).

Re: [PATCH 17/27] powerpc/eeh: I/O chip PE log and bridge setup

2013-06-11 Thread Gavin Shan
On Tue, Jun 11, 2013 at 05:37:59PM +1000, Benjamin Herrenschmidt wrote: >On Wed, 2013-06-05 at 15:34 +0800, Gavin Shan wrote: >> The patch adds backends to retrieve error log and configure p2p >> bridges for the indicated PE. >> >> Signed-off-by: Gavin Shan >> --- > >> +/** >> + * ioda_eeh_config

Re: [PATCH 15/27] powerpc/eeh: I/O chip EEH state retrieval

2013-06-11 Thread Benjamin Herrenschmidt
On Wed, 2013-06-12 at 11:32 +0800, Gavin Shan wrote: > >Same comments about "state" which is really "delay" and is probably > >not necessary at all ... > > > > We need the "delay" in future to support PowerKVM guest. If the > specified PE is being reset, we rely on the delay to hold the > powerkv

Re: [PATCH 1/5] ibmebus: convert of_platform_driver to platform_driver

2013-06-11 Thread Benjamin Herrenschmidt
On Wed, 2013-05-22 at 07:26 -0500, Rob Herring wrote: > > git://sources.calxeda.com/kernel/linux.git of-platform-removal > > Ben, > > Did you have a chance to test this? I want to get this into -next. I tested the one in for-next (sorry for the high latency). Works fine. Ack. Cheers, Ben. __

[PATCH] of: Fix locking vs. interrupts

2013-06-11 Thread Benjamin Herrenschmidt
The OF code uses irqsafe locks everywhere except in a handful of functions for no obvious reasons. Since the conversion from the old rwlocks, this now triggers lockdep warnings when used at interrupt time. At least one driver (ibmvscsi) seems to be doing that from softirq context. This converts th

Re: [PATCH -V7 09/18] powerpc: Switch 16GB and 16MB explicit hugepages to a different page table format

2013-06-11 Thread Aneesh Kumar K.V
Scott Wood writes: > On 06/11/2013 03:53:43 PM, Scott Wood wrote: >> On 06/08/2013 11:57:48 AM, Aneesh Kumar K.V wrote: >>> With the config shared I am not finding anything wrong, but I can't >>> test >>> these configs. Also can you confirm what you bisect this to >>> >>> e2b3d202d1dba8f3546ed