Re: Build regressions/improvements in v3.4-rc5

2012-05-02 Thread Geert Uytterhoeven
On Wed, 2 May 2012, Geert Uytterhoeven wrote: > Below is the list of build error/warning regressions/improvements in > v3.4-rc5[1] compared to v3.3[2]. > > Too make this mail fit in the lkml limit, I deleted > - 104 lines about __mcount_loc on sparc64 > - all warning improvements > > Summariz

[PATCH EDACv16 1/2] edac: Change internal representation to work with layers

2012-05-02 Thread Borislav Petkov
Starting a new thread because the old one grew too big and is out of my screen. Patch below is git-formatted from git://git.infradead.org/users/mchehab/edac.git > commit 447b7929e633027ffe131f2f8f246bba5690cee7 > Author: Mauro Carvalho Chehab > Date: Wed Apr 18 15:20:50 2012 -0300 > > edac

Re: [V2 5/5] powerpc: kernel: 16650 UART reg-shift support

2012-05-02 Thread Josh Boyer
On Mon, Apr 9, 2012 at 3:20 AM, Tanmay Inamdar wrote: > In APM8018X SOC, UART register address space has been relocated to 32-bit > data boundaries for APB bus implementation. > Current legacy_serial driver ignores the reg-shift property. This patch > modifies legacy_serial.c and udbg_16550.c to w

Re: [V2 2/5] powerpc: 40x: Add AHB, APB of_device_ids

2012-05-02 Thread Josh Boyer
On Mon, Apr 9, 2012 at 3:20 AM, Tanmay Inamdar wrote: > Adding of_device_id's for AHB and APB buses used in klondike (APM8018X) in > platforms/40x/ppc40x_simple.c file > > Signed-off-by: Tanmay Inamdar You should probably combine the first 3 patches in this series into one patch. Otherwise you

Please pull 'next' branch of 4xx tree

2012-05-02 Thread Josh Boyer
Hi Ben, A few patches from Suzie for 47x kexec/kdump support, and some MSI patches from Mai La. josh The following changes since commit ec34a6814988f17506733c1e8b058ce46602591d: powerpc: Remove old powerpc specific ptrace getregs/setregs calls (2012-04-30 15:37:28 +1000) are available in the

Re: linux-next ppc64: RCU mods cause __might_sleep BUGs

2012-05-02 Thread Hugh Dickins
On Tue, 1 May 2012, Paul E. McKenney wrote: > > > > > On Mon, 2012-04-30 at 15:37 -0700, Hugh Dickins wrote: > > > > > > > > > > > > BUG: sleeping function called from invalid context at > > > > > > include/linux/pagemap.h:354 > > > > > > in_atomic(): 0, irqs_disabled(): 0, pid: 6886, name: cc1 >

Re: linux-next ppc64: RCU mods cause __might_sleep BUGs

2012-05-02 Thread Paul E. McKenney
On Wed, May 02, 2012 at 01:25:30PM -0700, Hugh Dickins wrote: > On Tue, 1 May 2012, Paul E. McKenney wrote: > > > > > > On Mon, 2012-04-30 at 15:37 -0700, Hugh Dickins wrote: > > > > > > > > > > > > > > BUG: sleeping function called from invalid context at > > > > > > > include/linux/pagemap.h:35

Re: linux-next ppc64: RCU mods cause __might_sleep BUGs

2012-05-02 Thread Benjamin Herrenschmidt
On Wed, 2012-05-02 at 13:25 -0700, Hugh Dickins wrote: > Got it at last. Embarrassingly obvious. __rcu_read_lock() and > __rcu_read_unlock() are not safe to be using __this_cpu operations, > the cpu may change in between the rmw's read and write: they should > be using this_cpu operations (or, I

Re: linux-next ppc64: RCU mods cause __might_sleep BUGs

2012-05-02 Thread Paul E. McKenney
On Wed, May 02, 2012 at 01:49:54PM -0700, Paul E. McKenney wrote: > On Wed, May 02, 2012 at 01:25:30PM -0700, Hugh Dickins wrote: > > On Tue, 1 May 2012, Paul E. McKenney wrote: > > > > > > > On Mon, 2012-04-30 at 15:37 -0700, Hugh Dickins wrote: > > > > > > > > > > > > > > > > BUG: sleeping funct

Re: linux-next ppc64: RCU mods cause __might_sleep BUGs

2012-05-02 Thread Paul E. McKenney
On Wed, May 02, 2012 at 02:32:38PM -0700, Paul E. McKenney wrote: > On Wed, May 02, 2012 at 01:49:54PM -0700, Paul E. McKenney wrote: > > On Wed, May 02, 2012 at 01:25:30PM -0700, Hugh Dickins wrote: > > > On Tue, 1 May 2012, Paul E. McKenney wrote: > > > > > > > > On Mon, 2012-04-30 at 15:37 -0700

Re: linux-next ppc64: RCU mods cause __might_sleep BUGs

2012-05-02 Thread Paul E. McKenney
On Thu, May 03, 2012 at 07:20:15AM +1000, Benjamin Herrenschmidt wrote: > On Wed, 2012-05-02 at 13:25 -0700, Hugh Dickins wrote: > > Got it at last. Embarrassingly obvious. __rcu_read_lock() and > > __rcu_read_unlock() are not safe to be using __this_cpu operations, > > the cpu may change in betw

Re: linux-next ppc64: RCU mods cause __might_sleep BUGs

2012-05-02 Thread Hugh Dickins
On Wed, May 2, 2012 at 2:54 PM, Paul E. McKenney wrote: > On Thu, May 03, 2012 at 07:20:15AM +1000, Benjamin Herrenschmidt wrote: >> On Wed, 2012-05-02 at 13:25 -0700, Hugh Dickins wrote: >> > Got it at last.  Embarrassingly obvious.  __rcu_read_lock() and >> > __rcu_read_unlock() are not safe to

Re: linux-next ppc64: RCU mods cause __might_sleep BUGs

2012-05-02 Thread Paul E. McKenney
On Wed, May 02, 2012 at 03:54:24PM -0700, Hugh Dickins wrote: > On Wed, May 2, 2012 at 2:54 PM, Paul E. McKenney > wrote: > > On Thu, May 03, 2012 at 07:20:15AM +1000, Benjamin Herrenschmidt wrote: > >> On Wed, 2012-05-02 at 13:25 -0700, Hugh Dickins wrote: > >> > Got it at last.  Embarrassingly o

Re: linux-next ppc64: RCU mods cause __might_sleep BUGs

2012-05-02 Thread Hugh Dickins
On Wed, 2 May 2012, Paul E. McKenney wrote: > On Wed, May 02, 2012 at 03:54:24PM -0700, Hugh Dickins wrote: > > On Wed, May 2, 2012 at 2:54 PM, Paul E. McKenney > > wrote: > > > On Thu, May 03, 2012 at 07:20:15AM +1000, Benjamin Herrenschmidt wrote: > > >> On Wed, 2012-05-02 at 13:25 -0700, Hugh D

[PATCH] net/pasemi: fix compiler warning

2012-05-02 Thread Stephen Rothwell
Fix this compiler warning (on PowerPC) by not marking a parameter as const: drivers/net/ethernet/pasemi/pasemi_mac.c: In function 'pasemi_mac_replenish_rx_ring': drivers/net/ethernet/pasemi/pasemi_mac.c:646:3: warning: passing argument 1 of 'netdev_alloc_skb' discards qualifiers from pointer tar

Re: [PATCH] net/pasemi: fix compiler warning

2012-05-02 Thread David Miller
From: Stephen Rothwell Date: Thu, 3 May 2012 10:51:46 +1000 > Fix this compiler warning (on PowerPC) by not marking a parameter as > const: > > drivers/net/ethernet/pasemi/pasemi_mac.c: In function > 'pasemi_mac_replenish_rx_ring': > drivers/net/ethernet/pasemi/pasemi_mac.c:646:3: warning: pass

Re: [PATCH] powerpc: use local var instead of local_paca->irq_happened directly in __check_irq_replay

2012-05-02 Thread Benjamin Herrenschmidt
On Thu, 2012-05-03 at 09:53 +0800, Wang Sheng-Hui wrote: > local_paca->irq_happened may be changed asychronously. > > In my test env (IBM Power 9117-MMA), I installed the RHEL6.2 with the shipped > oprofile. Then I run into kernel v3.4-rc4, setup/start oprofile and start the > LTP test suite. >

[PATCH] powerpc: use local var instead of local_paca->irq_happened directly in __check_irq_replay

2012-05-02 Thread Wang Sheng-Hui
local_paca->irq_happened may be changed asychronously. In my test env (IBM Power 9117-MMA), I installed the RHEL6.2 with the shipped oprofile. Then I run into kernel v3.4-rc4, setup/start oprofile and start the LTP test suite. In a short while, the system would crash. Seems that oprofile may cha

Re: [PATCH] powerpc: use local var instead of local_paca->irq_happened directly in __check_irq_replay

2012-05-02 Thread Wang Sheng-Hui
On 2012年05月03日 10:15, Benjamin Herrenschmidt wrote: > On Thu, 2012-05-03 at 09:53 +0800, Wang Sheng-Hui wrote: >> local_paca->irq_happened may be changed asychronously. >> >> In my test env (IBM Power 9117-MMA), I installed the RHEL6.2 with the shipped >> oprofile. Then I run into kernel v3.4-rc4,

Re: [PATCH] powerpc: use local var instead of local_paca->irq_happened directly in __check_irq_replay

2012-05-02 Thread Wang Sheng-Hui
On 2012年05月03日 10:15, Benjamin Herrenschmidt wrote: > On Thu, 2012-05-03 at 09:53 +0800, Wang Sheng-Hui wrote: >> local_paca->irq_happened may be changed asychronously. >> >> In my test env (IBM Power 9117-MMA), I installed the RHEL6.2 with the shipped >> oprofile. Then I run into kernel v3.4-rc4,

Re: [PATCH] powerpc: use local var instead of local_paca->irq_happened directly in __check_irq_replay

2012-05-02 Thread Benjamin Herrenschmidt
> It should not as __check_irq_replay() should always be called > with interrupts hard disabled... Do you see any code path > where that is not the case ? More specifically, your backtrace seems to indicate that __check_irq_repay() was called from arch_local_irq_restore() which should have done t

Re: [PATCH] powerpc: use local var instead of local_paca->irq_happened directly in __check_irq_replay

2012-05-02 Thread Benjamin Herrenschmidt
On Thu, 2012-05-03 at 10:32 +0800, Wang Sheng-Hui wrote: > > It should not as __check_irq_replay() should always be called > > with interrupts hard disabled... Do you see any code path > > where that is not the case ? > > Since __check_irq_replay() should always be called with interrupts > hard di

[PATCH] powerpc/windfarm: fix compiler warning

2012-05-02 Thread Stephen Rothwell
Fixes this warning: drivers/macintosh/windfarm_pm91.c: In function 'wf_smu_cpu_fans_tick': drivers/macintosh/windfarm_pm91.c:237:2: warning: passing argument 1 of 'wf_sensor_get' from incompatible pointer type drivers/macintosh/windfarm.h:124:19: note: expected 'struct wf_sensor *' but argument

Re: [PATCH] powerpc: use local var instead of local_paca->irq_happened directly in __check_irq_replay

2012-05-02 Thread Wang Sheng-Hui
On 2012年05月03日 12:22, Benjamin Herrenschmidt wrote: > >> It should not as __check_irq_replay() should always be called >> with interrupts hard disabled... Do you see any code path >> where that is not the case ? > > More specifically, your backtrace seems to indicate that > __check_irq_repay() wa

[PATCH] powerpc/windfarm: don't pass const strings to snprintf

2012-05-02 Thread Stephen Rothwell
Fixes these build warnings: drivers/macintosh/windfarm_smu_sat.c: In function 'wf_sat_probe': drivers/macintosh/windfarm_smu_sat.c:290:3: warning: passing argument 1 of 'snprintf' discards qualifiers from pointer target type include/linux/kernel.h:323:5: note: expected 'char *' but argument is of

Re: [PATCH] powerpc: use local var instead of local_paca->irq_happened directly in __check_irq_replay

2012-05-02 Thread Wang Sheng-Hui
On 2012年05月03日 12:22, Benjamin Herrenschmidt wrote: > >> It should not as __check_irq_replay() should always be called >> with interrupts hard disabled... Do you see any code path >> where that is not the case ? > > More specifically, your backtrace seems to indicate that > __check_irq_repay() wa

Re: [PATCH] powerpc: use local var instead of local_paca->irq_happened directly in __check_irq_replay

2012-05-02 Thread Benjamin Herrenschmidt
On Thu, 2012-05-03 at 13:51 +0800, Wang Sheng-Hui wrote: > On 2012年05月03日 12:22, Benjamin Herrenschmidt wrote: > > > >> It should not as __check_irq_replay() should always be called > >> with interrupts hard disabled... Do you see any code path > >> where that is not the case ? > > > > More speci

Re: [PATCH] powerpc: use local var instead of local_paca->irq_happened directly in __check_irq_replay

2012-05-02 Thread Wang Sheng-Hui
On 2012年05月03日 14:33, Wang Sheng-Hui wrote: > if (unlikely(irq_happened != PACA_IRQ_HARD_DIS)) >> __hard_irq_disable(); I have commented out the 2 lines. FYI. thanks, ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://list