On Thu, 2012-05-03 at 10:32 +0800, Wang Sheng-Hui wrote: > > It should not as __check_irq_replay() should always be called > > with interrupts hard disabled... Do you see any code path > > where that is not the case ? > > Since __check_irq_replay() should always be called with interrupts > hard disabled, I think it's harmless to use local var here.
No, that would be papering over the real problem. All oprofile does is trigger perfmon interrupts (which act as some kind of NMI when soft-disabled but should be masked by MSR:EE when hard disabled). So there's a deeper issue here that we need to understand before we can propose a fix. IE. It should not have happened. Cheers, Ben. _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev