Re: [PATCH 00/17] mark const init data with __initconst instead of __initdata

2012-03-30 Thread Uwe Kleine-König
On Thu, Mar 29, 2012 at 11:11:31PM +0200, Uwe Kleine-König wrote: > Hello, > > this series fixes a common error to use __initdata to mark const > variables. Most of the time this works well enough to go unnoticed > (though I wonder why the linker doesn't warn about that). > Just try adding somethi

Re: powerpc/85xx: p2020rdb - move the NAND address.

2012-03-30 Thread Sebastian Andrzej Siewior
On 03/29/2012 03:10 PM, Kumar Gala wrote: - include/configs/P1_P2_RDB.h #ifndef CONFIG_NAND_SPL #define CONFIG_SYS_NAND_BASE0xffa0 #ifdef CONFIG_PHYS_64BIT #define CONFIG_SYS_NAND_BASE_PHYS 0xfffa0ull #else #define CONFIG_SYS_NAND_BASE_PHYS CONFIG_SYS_NAND_BASE #

Re: [PATCH] Bug fix in commit 178db7d3 triggered a bug in the SPI driver for MPC83XX (pdata is NULL).

2012-03-30 Thread Joakim Tjernlund
Kenth Eriksson wrote on 2012/03/30 17:05:30: > > After commit 178db7d3 devices are initialized as children of the bus master, > not children of the bus masters parent device. The pdata pointer used in > fsl_spi_chipselect must updated to reflect the changed initialization. > > Signed-off-by: Ken

Re: [REGRESSION][PATCH V4 1/3] bpf jit: Make the filter.c::__load_pointer helper non-static for the jits

2012-03-30 Thread Eric Dumazet
On Fri, 2012-03-30 at 17:08 +0200, Jan Seiffert wrote: > The function is renamed to make it a little more clear what it does. > It is not added to any .h because it is not for general consumption, only for > bpf internal use (and so by the jits). > > Signed-of-by: Jan Seiffert > Missing "---" l

[PATCH v2 10/15] powerpc: mark const init data with __initconst instead of __initdata

2012-03-30 Thread Uwe Kleine-König
As long as there is no other non-const variable marked __initdata in the same compilation unit it doesn't hurt. If there were one however compilation would fail with error: $variablename causes a section type conflict because a section containing const variables is marked read only and so

Re: kilauea compilation breaks with v3.3 kernel and ELDK 4.2

2012-03-30 Thread Frank Svendsbøe
On Mon, Mar 26, 2012 at 3:36 PM, Josh Boyer wrote: > On Sat, Mar 24, 2012 at 7:53 PM, Benjamin Herrenschmidt > wrote: >> On Wed, 2012-03-21 at 17:25 +0100, Wolfgang Denk wrote: >>> > > The problem is that for ppc-linux-gcc (GCC) 4.2.2 (which comes >>> with the >>> > > ELDK 4.2) this assembly inst

[PATCH] powerpc: fix fallout from system.h split up

2012-03-30 Thread Stephen Rothwell
Signed-off-by: Stephen Rothwell --- arch/powerpc/kernel/fadump.c |2 ++ arch/powerpc/kernel/kgdb.c |1 + 2 files changed, 3 insertions(+) Just a resend of what I sent yesterday - this is what I am using in linux-next. Linus, please apply. diff --git a/arch/powerpc/kernel/fadump.c b/

Re: kilauea compilation breaks with v3.3 kernel and ELDK 4.2

2012-03-30 Thread Benjamin Herrenschmidt
On Sat, 2012-03-31 at 00:53 +0200, Frank Svendsbøe wrote: > Hi Josh Boyer, > > just wanted to add that I'm experiencing the same problem that Robert > reported, but on 8xx instead of 4xx. The mpc8xx does not support the > mfdcrx instruction, so maybe it's more to it than just a binutils bug? The

[PATCH] Bug fix in commit 178db7d3 triggered a bug in the SPI driver for MPC83XX (pdata is NULL).

2012-03-30 Thread Kenth Eriksson
After commit 178db7d3 devices are initialized as children of the bus master, not children of the bus masters parent device. The pdata pointer used in fsl_spi_chipselect must updated to reflect the changed initialization. Signed-off-by: Kenth Eriksson --- drivers/spi/spi-fsl-spi.c |4 +++-

[REGRESSION][PATCH V4 3/3] bpf jit: Let the powerpc jit handle negative offsets

2012-03-30 Thread Jan Seiffert
Now the helper function from filter.c for negative offsets is exported, it can be used it in the jit to handle negative offsets. First modify the asm load helper functions to handle: - know positive offsets - know negative offsets - any offset then the compiler can be modified to explicitly use t

[REGRESSION][PATCH V4 1/3] bpf jit: Make the filter.c::__load_pointer helper non-static for the jits

2012-03-30 Thread Jan Seiffert
The function is renamed to make it a little more clear what it does. It is not added to any .h because it is not for general consumption, only for bpf internal use (and so by the jits). Signed-of-by: Jan Seiffert --- a/net/core/filter.c +++ b/net/core/filter.c @@ -40,8 +40,12 @@ #include #inc

[REGRESSION][PATCH V4 0/3] bpf jit drops the ball on negative memory references

2012-03-30 Thread Jan Seiffert
Consider the following test program: #include #include #include #include #include #define die(x) do {perror(x); return 1;} while (0) struct bpf_insn udp_filter[] = { /* 0 */ BPF_STMT(BPF_LDX|BPF_W|BPF_IMM, -1048576+(0)), /* leax net[0] */ /* 1 */ BPF_STMT(BPF_LD|B

[PATCH v2 00/15] mark const init data with __initconst instead of __initdata

2012-03-30 Thread Uwe Kleine-König
Hello, On Thu, Mar 29, 2012 at 11:11:31PM +0200, Uwe Kleine-König wrote: > this series fixes a common error to use __initdata to mark const > variables. Most of the time this works well enough to go unnoticed > (though I wonder why the linker doesn't warn about that). > Just try adding something l

Re: [PATCH] Bug fix in commit 178db7d3 triggered a bug in the SPI driver for MPC83XX (pdata is NULL).

2012-03-30 Thread Grant Likely
On Fri, 30 Mar 2012 17:05:30 +0200, Kenth Eriksson wrote: > After commit 178db7d3 devices are initialized as children of the bus master, > not children of the bus masters parent device. The pdata pointer used in > fsl_spi_chipselect must updated to reflect the changed initialization. > > Signe