Re: [PATCH 2/2] ucc_geth: Rework the TX logic.

2009-03-27 Thread David Miller
These patches don't apply to the current tree, could you please respin your final version against at the very least Linus's tree? Thanks. ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH v3 3/4] powerpc: NAND: FSL UPM: document new bindings

2009-03-27 Thread Wolfgang Grandegger
Grant Likely wrote: > On Thu, Mar 26, 2009 at 4:14 PM, Wolfgang Grandegger > wrote: >> Anton Vorontsov wrote: >>> On Thu, Mar 26, 2009 at 11:02:06AM -0600, Grant Likely wrote: In other words, this device is not register-level compatible with the fsl,upm-nand device. Give the node a new

ioremap_nocache on the nor flash, reading sporadically fails

2009-03-27 Thread DI BACCO ANTONIO - technolabs
I have an MPC880 with linux-2.6.19, I use a flash sector of my nor flash to store some parameters. In order to read them I mapped it with ioremap_nocache and most of the time the reading is working fine. Sporadically the read returns strange values... Could it be an hardware problem? Or mapping

Re: [PATCH 2/2] ucc_geth: Rework the TX logic.

2009-03-27 Thread Joakim Tjernlund
David Miller wrote on 27/03/2009 08:42:37: > > > These patches don't apply to the current tree, could you please > respin your final version against at the very least Linus's tree? That is strange, had a look at linus tree and I don't see any changes in his tree that touches the same area/funct

Re: [PATCH] ucc_geth: Rework the TX logic.

2009-03-27 Thread Li Yang
On Fri, Mar 27, 2009 at 1:44 AM, Joakim Tjernlund wrote: > The line: >  if ((bd == ugeth->txBd[txQ]) && (netif_queue_stopped(dev) == 0)) >       break; > in ucc_geth_tx() didn not make sense to me. Rework & cleanup > this logic to something understandable. > --- > > Reworked the patch according to

Re: [PATCH] ucc_geth: Rework the TX logic.

2009-03-27 Thread Joakim Tjernlund
pku@gmail.com wrote on 27/03/2009 10:45:12: > On Fri, Mar 27, 2009 at 1:44 AM, Joakim Tjernlund > wrote: > > The line: > > if ((bd == ugeth->txBd[txQ]) && (netif_queue_stopped(dev) == 0)) > > break; > > in ucc_geth_tx() didn not make sense to me. Rework & cleanup > > this logic to somet

Re: [PATCH] ucc_geth: Rework the TX logic.

2009-03-27 Thread Li Yang
On Fri, Mar 27, 2009 at 6:23 PM, Joakim Tjernlund wrote: > pku@gmail.com wrote on 27/03/2009 10:45:12: >> On Fri, Mar 27, 2009 at 1:44 AM, Joakim Tjernlund >> wrote: >> > The line: >> >  if ((bd == ugeth->txBd[txQ]) && (netif_queue_stopped(dev) == 0)) >> >       break; >> > in ucc_geth_tx() d

Re: [PATCH 1/2] ucc_geth: Move freeing of TX packets to NAPI context.

2009-03-27 Thread Li Yang
On Thu, Mar 26, 2009 at 8:54 PM, Joakim Tjernlund wrote: > Also set NAPI weight to 64 as this is a common value. > This will make the system alot more responsive while > ping flooding the ucc_geth ethernet interaface. > > Signed-off-by: Joakim Tjernlund > --- >  drivers/net/ucc_geth.c |   32

Re: [PATCH] ucc_geth: Rework the TX logic.

2009-03-27 Thread Joakim Tjernlund
pku@gmail.com wrote on 27/03/2009 11:39:07: > On Fri, Mar 27, 2009 at 6:23 PM, Joakim Tjernlund > >> > - /* We freed a buffer, so now we can restart > > transmission */ > >> > - if (netif_queue_stopped(dev)) > >> > - netif_wake_queue(dev); > >>

Re: [PATCH v2] powerpc/85xx: Add support for the "socrates" board (MPC8544).

2009-03-27 Thread Kumar Gala
On Mar 22, 2009, at 8:58 AM, Wolfgang Grandegger wrote: Supported are Ethernet, serial console, I2C, I2C-based RTC and temperature sensors, NOR and NAND flash, PCI, USB, CAN and Lime display controller. The multiplexing of FPGA interrupts onto PowerPC interrupt lines is supported through our o

Re: [PATCH v3] powerpc: clean up ssi.txt, add definition for fsl, ssi-asynchronous

2009-03-27 Thread Kumar Gala
On Mar 11, 2009, at 7:22 PM, Timur Tabi wrote: Add the definition of the fsl,ssi-asynchronous property to ssi.txt (documentation of the device tree bindings for the Freescale SSI device). Also tidy up the layout of ssi.txt. Signed-off-by: Timur Tabi --- v3: rebased v2: fixed typo, improv

Re: [PATCH 1/2] ucc_geth: Move freeing of TX packets to NAPI context.

2009-03-27 Thread Joakim Tjernlund
pku@gmail.com wrote on 27/03/2009 11:50:09: > > On Thu, Mar 26, 2009 at 8:54 PM, Joakim Tjernlund > wrote: > > Also set NAPI weight to 64 as this is a common value. > > This will make the system alot more responsive while > > ping flooding the ucc_geth ethernet interaface. > > > > Signed-off-

CONFIG_DEBUG_PAGEALLOC generates WARN_ON() in ppc32 hash

2009-03-27 Thread Kumar Gala
Ben, If we have CONFIG_DEBUG_PAGEALLOC enabled we end up hitting the WARN_ON() in set_pte_at() when we boot. This appears because we've already setup pte's via mapin_ram() after which we end up calling kernel_map_pages(). So I'm not sure if __change_page_attr() should be doing something

linux-next: tracing/powerpc tree build failure

2009-03-27 Thread Stephen Rothwell
Hi all, Today's linux-next build (powerpc allyesconfig) failed like this: arch/powerpc/kernel/ftrace.c: In function 'prepare_ftrace_return': arch/powerpc/kernel/ftrace.c:612: warning: passing argument 3 of 'ftrace_push_return_trace' makes pointer from integer without a cast arch/powerpc/kernel/f

Re: linux-next: tracing/powerpc tree build failure

2009-03-27 Thread Steven Rostedt
On Fri, 2009-03-27 at 23:08 +1100, Stephen Rothwell wrote: > Hi all, > > Today's linux-next build (powerpc allyesconfig) failed like this: > > arch/powerpc/kernel/ftrace.c: In function 'prepare_ftrace_return': > arch/powerpc/kernel/ftrace.c:612: warning: passing argument 3 of > 'ftrace_push_ret

Re: Q: define i2c nodes in device tree?

2009-03-27 Thread Albrecht Dre�
Hi Timur: > You need to have a "gpio I2C" device driver that registers the same name as > what's in the DTS, like this: Thanks, that did the trick; a proper naming is apparently pca8575:g...@20 { compatible = "nxp,pca8575"; device_type = "gpio"; reg = <0x20 1>; }; Now t

issue at the beginning of kernel booting

2009-03-27 Thread chmhou
there is something confused me, which is my kernel code is halt because of something wrong i have no hint about it. my bootloader is u-boot, version is 1.1.4, kernel version is 2.6.14.1, processor is MPC8247. u-boot have run on the board already. bootloader booting information as follow: U-Boot 1

Re: [PATCH] ucc_geth: Rework the TX logic.

2009-03-27 Thread Scott Wood
Joakim Tjernlund wrote: This is a bit better than the current type casts. Moving over to qe_bd accesses is a bigger cleanup that will have to be a seperate patch. I am not sure it is an all win as you probably loose the ability to read both status and len in one access. Not if you define the st

Re: linux-next: tracing/powerpc tree build failure

2009-03-27 Thread Stephen Rothwell
Hi Steve, On Fri, 27 Mar 2009 08:48:51 -0400 Steven Rostedt wrote: > > I knew this was going to break, but I needed to wait till powerpc merged > with tip before I could make the change. Yeah, a bit of a pain but we can live with it for a while. > This is exactly what I would have done. Thanks

DTC sources move

2009-03-27 Thread Michal Simek
Hi Ben, could you please move DTC to any generic location. I would like to use it for Microblaze cpu too. Thanks, Michal -- Michal Simek, Ing. (M.Eng) w: www.monstr.eu p: +42-0-721842854 ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https:/

Re: DTC sources move

2009-03-27 Thread Grant Likely
On Fri, Mar 27, 2009 at 8:16 AM, Michal Simek wrote: > Hi Ben, > > could you please move DTC to any generic location. I would like to use it for > Microblaze cpu too. Michal, David Gibson is the one responsible for the in-tree dtc source, not Ben, and you should prepare the patches yourself to

Re: issue at the beginning of kernel booting

2009-03-27 Thread Scott Wood
On Fri, Mar 27, 2009 at 04:36:28PM +0800, chmhou wrote: > there is something confused me, which is my kernel code is halt because of > something wrong i have no hint about it. > my bootloader is u-boot, version is 1.1.4, kernel version is 2.6.14.1, > processor is MPC8247. That is very old code;

RE: sata device failed to IDENTIFY...

2009-03-27 Thread Tirumala Reddy Marri
What PCI Sata card is this ? Is you device tree entrees are correct for PCI ? Especially the interrupt numbers etc ? Also check your ioremap() function in the SATA driver. Make sure that data type of physical address in the driver using is "unsigned long long" instead of "unsigned long" -

[PATCH] ucc_geth: Fix three oopses in PHY {de,}initialization code

2009-03-27 Thread Anton Vorontsov
When there are no free snums, UCC ethernet should gracefully fail, but currently it oopses this way: # ifconfig eth0 up fill_init_enet_entries: Can not get SNUM. ucc_geth_startup: Can not fill p_init_enet_param_shadow. eth0: Cannot configure net device, aborting. Unable to handle kernel

Re: [PATCH] ucc_geth: Convert to net_device_ops

2009-03-27 Thread Timur Tabi
On Tue, Mar 24, 2009 at 6:08 PM, Joakim Tjernlund wrote: > +       .ndo_change_mtu         = eth_change_mtu, I have an old patch for change_mtu support for ucc_geth which I've been meaning to push upstream. This patch uses this function instead of eth_change_mtu(): +static int ucc_geth_change_

Re: DTC sources move

2009-03-27 Thread Jon Loeliger
> On Fri, Mar 27, 2009 at 8:16 AM, Michal Simek wrote: > > Hi Ben, > > > > could you please move DTC to any generic location. I would like to use it f > or Microblaze cpu too. > > Michal, > > David Gibson is the one responsible for the in-tree dtc source, not > Ben, and you should prepare the pa

Re: [PATCH 1/2] ucc_geth: Move freeing of TX packets to NAPI context.

2009-03-27 Thread David Miller
From: Joakim Tjernlund Date: Fri, 27 Mar 2009 12:52:41 +0100 > pku@gmail.com wrote on 27/03/2009 11:50:09: > > It doesn't make sense to have larger napi budget than the size of RX > > BD ring. You can't have more BDs than RX_BD_RING_LEN in backlog for > > napi_poll to process. Increase the

Re: Q: define i2c nodes in device tree?

2009-03-27 Thread Timur Tabi
On Fri, Mar 27, 2009 at 8:05 AM, Albrecht Dreß wrote: > Now the driver is called, but complains that no platform data is present.   > Still have to figure out how to pass that... :-/ I believe there was code added recently to i2c-mpc.c to put DTS properties into the platform device, but I don'

Please pull from 'next' branch

2009-03-27 Thread Kumar Gala
Please pull from 'next' branch of master.kernel.org:/pub/scm/linux/kernel/git/galak/powerpc.git next to receive the following updates: Documentation/powerpc/dts-bindings/fsl/ssi.txt | 68 - arch/powerpc/boot/dts/asp834x-redboot.dts | 82 - arch/powerpc/boot/dts/gef_ppc9a.dts

Re: [PATCH] ucc_geth: Fix three oopses in PHY {de,}initialization code

2009-03-27 Thread David Miller
From: Anton Vorontsov Date: Fri, 27 Mar 2009 20:40:47 +0300 > When there are no free snums, UCC ethernet should gracefully fail, but > currently it oopses this way: ... > Also, when device tree specifies fixed-link, and CONFIG_FIXED_PHY > is disabled, we'll get this oops: ... > This patch fixes

Re: CONFIG_DEBUG_PAGEALLOC generates WARN_ON() in ppc32 hash

2009-03-27 Thread Benjamin Herrenschmidt
On Fri, 2009-03-27 at 06:56 -0500, Kumar Gala wrote: > Ben, > > If we have CONFIG_DEBUG_PAGEALLOC enabled we end up hitting the > WARN_ON() in set_pte_at() when we boot. This appears because we've > already setup pte's via mapin_ram() after which we end up calling > kernel_map_pages(). > >

Re: Q: define i2c nodes in device tree?

2009-03-27 Thread David Gibson
On Fri, Mar 27, 2009 at 02:05:04PM +0100, Albrecht Dre� wrote: > Hi Timur: > > > You need to have a "gpio I2C" device driver that registers the same name as > > what's in the DTS, like this: > > Thanks, that did the trick; a proper naming is apparently > > pca8575:g...@20 { > compatib

Re: DTC sources move

2009-03-27 Thread David Gibson
On Fri, Mar 27, 2009 at 09:57:25AM -0600, Grant Likely wrote: > On Fri, Mar 27, 2009 at 8:16 AM, Michal Simek wrote: > > Hi Ben, > > > > could you please move DTC to any generic location. I would like to use it > > for Microblaze cpu too. > > Michal, > > David Gibson is the one responsible for

Re: Chipselect in SPI binding with mpc5200-psc-spi

2009-03-27 Thread Yann Pelletier
I'm trying to do the same sort of thing On Fri, Feb 13, 2009 at 3:40 AM, Henk Stegeman https://ozlabs.org/mailman/listinfo/linuxppc-dev>> wrote: > I'm busy adding support for slave deviced behind mpc52xx-psc-spi. > One complication I have is that my SPI slave device has an interrupt output > to