Re: [PATCH] Miscellaneous for Taco

2008-01-05 Thread Stefan Roese
On Saturday 05 January 2008, Benjamin Herrenschmidt wrote: > > diff --git a/drivers/usb/Kconfig b/drivers/usb/Kconfig > > index 7580aa5..480580c 100644 > > --- a/drivers/usb/Kconfig > > +++ b/drivers/usb/Kconfig > > @@ -39,6 +39,7 @@ config USB_ARCH_HAS_OHCI > > # PPC: > > default y

Re: [PATCH] MTD for Taco

2008-01-05 Thread Stefan Roese
On Saturday 05 January 2008, Sean MacLennan wrote: > This patch adds the maps for the taco. It also gets the ndfc.c NAND > driver in a compilable state. The map is guaranteed to change since the > exact NOR/NAND flash configuration is in flux right now when we found > the 256M NAND flash won't boot

[PATCH] ibm_newemac: Increase number of default rx-/tx-buffers

2008-01-05 Thread Stefan Roese
Performance tests done by AMCC have shown that 256 buffer increase the performance of the Linux EMAC driver. So let's update the default values to match this setup. Signed-off-by: Stefan Roese <[EMAIL PROTECTED]> --- drivers/net/ibm_newemac/Kconfig |4 ++-- 1 files changed, 2 insertions(+), 2

Re: [PATCH] ibm_newemac: Increase number of default rx-/tx-buffers

2008-01-05 Thread Benjamin Herrenschmidt
On Sat, 2008-01-05 at 10:50 +0100, Stefan Roese wrote: > Performance tests done by AMCC have shown that 256 buffer increase the > performance of the Linux EMAC driver. So let's update the default > values to match this setup. > > Signed-off-by: Stefan Roese <[EMAIL PROTECTED]> > --- Do we have t

[PATCH v2] [POWERPC] Provide a way to protect 4k subpages when using 64k pages

2008-01-05 Thread Paul Mackerras
Using 64k pages on 64-bit PowerPC systems makes life difficult for emulators that are trying to emulate an ISA, such as x86, which use a smaller page size, since the emulator can no longer use the MMU and the normal system calls for controlling page protections. Of course, the emulator can emulate

Re: [PATCH 2/3] Look for include files in the directory of the including file.

2008-01-05 Thread David Gibson
On Thu, Jan 03, 2008 at 05:43:31PM -0600, Scott Wood wrote: > Looking in the diretory dtc is invoked from is not very useful behavior. > > As part of the code reorganization to implement this, I removed the > uniquifying of name storage -- it seemed a rather dubious optimization > given likely usa

Re: [PATCH 1/3] Add yyerrorf() for formatted error messages.

2008-01-05 Thread David Gibson
On Thu, Jan 03, 2008 at 05:43:29PM -0600, Scott Wood wrote: > Signed-off-by: Scott Wood <[EMAIL PROTECTED]> I don't really like adding any yy*() functions that aren't actually part of the fixed lex/yacc interface. But, despite that, let's merge this, and parth 2/3 because I think we should get in

Re: [PATCH] ASoC drivers for the Freescale MPC8610 SoC

2008-01-05 Thread David Gibson
On Thu, Jan 03, 2008 at 09:54:45AM -0500, Jon Smirl wrote: > On 1/2/08, David Gibson <[EMAIL PROTECTED]> wrote: [snip] > > Instantiating the fabric driver off any node is wrong, precisely > > because it is an abstraction. The fabric driver should be > > instantiated by the platform code. > > Inst

Re: [PATCH 3/3] Return a non-zero exit code if an error occurs during dts parsing.

2008-01-05 Thread David Gibson
On Thu, Jan 03, 2008 at 05:43:33PM -0600, Scott Wood wrote: > Previously, only failure to parse caused the reading of the tree to fail; > semantic errors that called yyerror() but not YYERROR only emitted a message, > without signalling make to stop the build. This one, however, I don't like. [sn

Re: [PATCH] i2c-ibm_iic driver

2008-01-05 Thread Arnd Bergmann
On Saturday 05 January 2008, Sean MacLennan wrote: > I converted the i2c-ibm_iic driver from an ocp driver to an of_platform > driver. Since this driver is in the kernel.org kernel, should I rename > it and keep the old one around? I notice this was done with the emac > network driver. The inte

Re: [patch 2/3] PS3: Add logical performance monitor device support

2008-01-05 Thread Arnd Bergmann
On Saturday 05 January 2008, Geoff Levand wrote: > + struct layout { > + struct ps3_system_bus_device dev; > + } *p; What's the point of this data structure? You don't use the struct anywhere, and it only has one member, so you could just declare that directly. > +  

Re: Enable RTC for Ebony and Walnut

2008-01-05 Thread David Gibson
On Fri, Dec 21, 2007 at 03:29:22PM -0600, Olof Johansson wrote: > Hi, > > On Fri, Dec 21, 2007 at 01:21:30PM +1100, David Gibson wrote: > > Index: working-2.6/arch/powerpc/platforms/Kconfig > > === > > --- working-2.6.orig/arch/powerp

Re: [patch 3/3] PS3: Add logical performance monitor driver support

2008-01-05 Thread Arnd Bergmann
On Saturday 05 January 2008, Geoff Levand wrote: > From: Takashi Yamamoto <[EMAIL PROTECTED]> > > Add PS3 logical performance monitor (lpm) device driver. > > The PS3's LV1 hypervisor provides a Logical Performance Monitor that > abstarcts the Cell processor's performance monitor features for use

Re: [PATCH v2] [POWERPC] Provide a way to protect 4k subpages when using 64k pages

2008-01-05 Thread Arnd Bergmann
On Saturday 05 January 2008, Paul Mackerras wrote: > This version allocates a new system call number for the subpage_prot > syscall. Ah, good. Thanks! > --- a/arch/powerpc/kernel/syscalls.c > +++ b/arch/powerpc/kernel/syscalls.c > @@ -328,3 +328,7 @@ void do_show_syscall_exit(unsigned long r3) >

Re: [PATCH] ibm_newemac: Increase number of default rx-/tx-buffers

2008-01-05 Thread Stefan Roese
On Saturday 05 January 2008, Benjamin Herrenschmidt wrote: > On Sat, 2008-01-05 at 10:50 +0100, Stefan Roese wrote: > > Performance tests done by AMCC have shown that 256 buffer increase the > > performance of the Linux EMAC driver. So let's update the default > > values to match this setup. > > >

Re: [PATCH] i2c-ibm_iic driver

2008-01-05 Thread Stefan Roese
On Saturday 05 January 2008, Arnd Bergmann wrote: > On Saturday 05 January 2008, Sean MacLennan wrote: > > I converted the i2c-ibm_iic driver from an ocp driver to an of_platform > > driver. Since this driver is in the kernel.org kernel, should I rename > > it and keep the old one around? I notice

Re: [PATCH] i2c-ibm_iic driver

2008-01-05 Thread Arnd Bergmann
On Saturday 05 January 2008, Stefan Roese wrote: > > > > This is probably not specific enough. I'm rather sure that someone at IBM > > has implemented an i2c chip that this driver doesn't support. Maybe > > > >   .compatible = "ibm,405-iic" > > > > or similar would be a better thing to check fo

Re: [PATCH] i2c-ibm_iic driver

2008-01-05 Thread Stefan Roese
On Saturday 05 January 2008, Arnd Bergmann wrote: > > > This is probably not specific enough. I'm rather sure that someone at > > > IBM has implemented an i2c chip that this driver doesn't support. Maybe > > > > > >   .compatible = "ibm,405-iic" > > > > > > or similar would be a better thing to

Re: [PATCH] MTD for Taco

2008-01-05 Thread Sean MacLennan
Stefan Roese wrote: > On Saturday 05 January 2008, Sean MacLennan wrote: > >> This patch adds the maps for the taco. It also gets the ndfc.c NAND >> driver in a compilable state. The map is guaranteed to change since the >> exact NOR/NAND flash configuration is in flux right now when we found >>

Re: [PATCH] Base Taco Platform support

2008-01-05 Thread Sean MacLennan
Benjamin Herrenschmidt wrote: > On Fri, 2008-01-04 at 23:49 -0500, Sean MacLennan wrote: > >> Here is a patch for the base taco platform. It is against for-2.6.25. It >> adds basically everything in the arch/powerpc. >> > > Care to tell us a bit more about what Taco is ? Even better is to

Re: [PATCH] Miscellaneous for Taco

2008-01-05 Thread Sean MacLennan
Stefan Roese wrote: > On Saturday 05 January 2008, Benjamin Herrenschmidt wrote: > >>> diff --git a/drivers/usb/Kconfig b/drivers/usb/Kconfig >>> index 7580aa5..480580c 100644 >>> --- a/drivers/usb/Kconfig >>> +++ b/drivers/usb/Kconfig >>> @@ -39,6 +39,7 @@ config USB_ARCH_HAS_OHCI >>> #

Re: [PATCH] Hwmon for Taco

2008-01-05 Thread Sean MacLennan
Benjamin Herrenschmidt wrote: >> +module_exit(ad7414_exit); >> --- /dev/null2005-11-20 22:22:37.0 -0500 >> +++ drivers/hwmon/taco-dtm.c 2008-01-05 00:06:21.0 -0500 >> @@ -0,0 +1,78 @@ >> +/* >> + * drivers/hwmon/taco-dtm.c >> + * >> + * Overview: On the Taco, the fpga cont

Re: [PATCH] i2c-ibm_iic driver

2008-01-05 Thread Sean MacLennan
Arnd Bergmann wrote: > On Saturday 05 January 2008, Stefan Roese wrote: > >>> This is probably not specific enough. I'm rather sure that someone at IBM >>> has implemented an i2c chip that this driver doesn't support. Maybe >>> >>> .compatible = "ibm,405-iic" >>> >>> or similar would be a

Re: [PATCH] i2c-ibm_iic driver

2008-01-05 Thread Sean MacLennan
Arnd Bergmann wrote: > On Saturday 05 January 2008, Sean MacLennan wrote: > >> I converted the i2c-ibm_iic driver from an ocp driver to an of_platform >> driver. Since this driver is in the kernel.org kernel, should I rename >> it and keep the old one around? I notice this was done with the em

Re: [PATCH] i2c-ibm_iic driver

2008-01-05 Thread Sean MacLennan
Stefan Roese wrote: > >> Otherwise, there are two options: >> >> 1. duplicate the driver like you suggested >> 2. make the same driver both a ocp and of_platform, depending on >> the configuration options. >> >> Since most of the driver is untouched by your patch, I'd lean to >> the second option,

Re: [PATCH] i2c-ibm_iic driver

2008-01-05 Thread Arnd Bergmann
On Saturday 05 January 2008, Sean MacLennan wrote: > > Ok. The 44x based .dts files do not list 405-iic, so would I think I > will add two compatibility matches, one for 405 and one for 440EP. That > way I do not break all the current .dts files. Everybody ok with that? > Sounds good. There ar

Re: [PATCH] MTD for Taco

2008-01-05 Thread Arnd Bergmann
On Saturday 05 January 2008, Sean MacLennan wrote: > > You do break arch/ppc support with this patch. We have to still support > > arch/ppc a few month, so please don't break this support for now. > >   > Gotcha. Is CONFIG_PPC_MERGED the right flag for things like this? Yes, but it it's spelled C

Re: [PATCH] ibm_newemac: Increase number of default rx-/tx-buffers

2008-01-05 Thread Benjamin Herrenschmidt
On Sat, 2008-01-05 at 13:38 +0100, Stefan Roese wrote: > On Saturday 05 January 2008, Benjamin Herrenschmidt wrote: > > On Sat, 2008-01-05 at 10:50 +0100, Stefan Roese wrote: > > > Performance tests done by AMCC have shown that 256 buffer increase the > > > performance of the Linux EMAC driver. So

Re: [PATCH] Miscellaneous for Taco

2008-01-05 Thread Benjamin Herrenschmidt
On Sat, 2008-01-05 at 13:22 -0500, Sean MacLennan wrote: > Ok. I thought of that, but most 440EP boards have PCI set and don't need > the special option. I was worried if I put 440EP someone down the road > might remove it as "extraneous". We are probably the only 440EP board > with no PCI ;)

Re: [PATCH] ibm_newemac: Increase number of default rx-/tx-buffers

2008-01-05 Thread Josh Boyer
On Sun, 06 Jan 2008 07:53:06 +1100 Benjamin Herrenschmidt <[EMAIL PROTECTED]> wrote: > > On Sat, 2008-01-05 at 13:38 +0100, Stefan Roese wrote: > > On Saturday 05 January 2008, Benjamin Herrenschmidt wrote: > > > On Sat, 2008-01-05 at 10:50 +0100, Stefan Roese wrote: > > > > Performance tests don

Re: [PATCH] ibm_newemac: Increase number of default rx-/tx-buffers

2008-01-05 Thread Benjamin Herrenschmidt
On Sat, 2008-01-05 at 15:48 -0600, Josh Boyer wrote: > No need for a defconfig update patch. Paul or I usually do a general > defconfig update for most boards before the next kernel version. This > will get picked up then. Will it ? I think the defconfigs will stick to the old value. Ben. ___

Re: [PATCH] i2c-ibm_iic driver

2008-01-05 Thread David Gibson
On Sat, Jan 05, 2008 at 08:18:22PM +0100, Arnd Bergmann wrote: > On Saturday 05 January 2008, Sean MacLennan wrote: > > > > Ok. The 44x based .dts files do not list 405-iic, so would I think I > > will add two compatibility matches, one for 405 and one for 440EP. That > > way I do not break all

Re: [PATCH 1/3] Add support for binary includes.

2008-01-05 Thread David Gibson
On Fri, Jan 04, 2008 at 03:10:43PM -0600, Scott Wood wrote: > A property's data can be populated with a file's contents > as follows: > > node { > prop = /incbin/("path/to/data"); > }; > > A subset of a file can be included by passing start and size parameters. > For example, to include by

Re: [PATCH] MTD for Taco

2008-01-05 Thread David Gibson
On Sat, Jan 05, 2008 at 10:41:17AM +0100, Stefan Roese wrote: > On Saturday 05 January 2008, Sean MacLennan wrote: > > +++ drivers/mtd/maps/taco.c 2008-01-02 13:07:43.0 -0500 > > @@ -0,0 +1,140 @@ > > +/* > > + * $Id: $ > > + * > > + * drivers/mtd/maps/taco.c > > + * > > + * Mapping for

Re: [PATCH] ibm_newemac: Increase number of default rx-/tx-buffers

2008-01-05 Thread Josh Boyer
On Sun, 06 Jan 2008 08:54:28 +1100 Benjamin Herrenschmidt <[EMAIL PROTECTED]> wrote: > > On Sat, 2008-01-05 at 15:48 -0600, Josh Boyer wrote: > > No need for a defconfig update patch. Paul or I usually do a general > > defconfig update for most boards before the next kernel version. This > > wi

Re: [PATCH] MTD for Taco

2008-01-05 Thread Sean MacLennan
David Gibson wrote: >> I'm pretty sure that you don't need a board specific mapping driver >> for NOR flash. physmap_of should be exactly what you need. You just need >> to fill the device tree properties correctly. >> > > Absolutely. We should not be using C-coded maps in arch/powerpc > >

Re: [alsa-devel] [PATCH] ASoC drivers for the Freescale MPC8610 SoC

2008-01-05 Thread David Gibson
On Fri, Jan 04, 2008 at 08:39:54PM -0600, Timur Tabi wrote: > David Gibson wrote: > > > And what distinction are you drawing between "first" and "second" > > here? > > Oh, that's an easy one: The CS4270 can work without an I2C or SPI > connection, > but it will never work without an I2S conne

Re: [PATCH 2/3] Handle absolute pathnames correctly in dtc_open_file.

2008-01-05 Thread David Gibson
On Fri, Jan 04, 2008 at 03:10:45PM -0600, Scott Wood wrote: > Also, free file->dir when freeing file. > > Signed-off-by: Scott Wood <[EMAIL PROTECTED]> > --- > srcpos.c | 12 > 1 files changed, 12 insertions(+), 0 deletions(-) > > diff --git a/srcpos.c b/srcpos.c > index 7340c33..

Re: [PATCH] MTD for Taco

2008-01-05 Thread David Gibson
On Sat, Jan 05, 2008 at 10:20:58PM -0500, Sean MacLennan wrote: > David Gibson wrote: > >> I'm pretty sure that you don't need a board specific mapping driver > >> for NOR flash. physmap_of should be exactly what you need. You just need > >> to fill the device tree properties correctly. > >> >