Re: How to add platform specific data to a of_device

2007-07-16 Thread Robert Schwebel
On Sun, Jul 15, 2007 at 06:48:53AM +1000, Benjamin Herrenschmidt wrote: > Your approach would work I suppose though it's a bit ugly. Speaking of uggly, I'm still wondering why this oftree stuff for powerpc must be s complicated. If you come from the ARM-linux world like we do, the whole po

Re: How to add platform specific data to a of_device

2007-07-16 Thread Benjamin Herrenschmidt
On Mon, 2007-07-16 at 08:51 +0200, Robert Schwebel wrote: > On Sun, Jul 15, 2007 at 06:48:53AM +1000, Benjamin Herrenschmidt wrote: > > Your approach would work I suppose though it's a bit ugly. > > Speaking of uggly, I'm still wondering why this oftree stuff for powerpc > must be s compli

Re: How to add platform specific data to a of_device

2007-07-16 Thread Robert Schwebel
On Mon, Jul 16, 2007 at 05:09:12PM +1000, Benjamin Herrenschmidt wrote: > As I wrote a couple of times already, it's a perfectly acceptable > approach to have "constructors" (what you call oftree-interpreter) that > generate platform devices from the OF tree. Great! > > mapping. Is there a reason

Re: How to add platform specific data to a of_device

2007-07-16 Thread Benjamin Herrenschmidt
On Mon, 2007-07-16 at 09:19 +0200, Robert Schwebel wrote: > I think it is a fundamental thing: the "we just have to wait long > enough, until oftree definitions have settled" proposal just isn't > right. It may be right for big irons, being well defined. But for the > embedded processors, too less

Re: How to add platform specific data to a of_device

2007-07-16 Thread Michael Ellerman
On Mon, 2007-07-16 at 08:51 +0200, Robert Schwebel wrote: > On Sun, Jul 15, 2007 at 06:48:53AM +1000, Benjamin Herrenschmidt wrote: > > Your approach would work I suppose though it's a bit ugly. > > Speaking of uggly, I'm still wondering why this oftree stuff for powerpc > must be s compli

Legacy ISA registers/interrupts in PCI device tree node

2007-07-16 Thread Gerhard Pircher
Hi, I wonder, if there is a recommended way to specify ISA register addresses and interrupts for a PCI device (unlike for a PCI2ISA bridge)? The device in question is the integrated IDE controller of the VIA686B southbridge, which works in compatible/legacy mode and thus uses interrupts 14 and 15

Re: Legacy ISA registers/interrupts in PCI device tree node

2007-07-16 Thread Matt Sealey
Gerhard, You could do a LOT worse than check the Pegasos. -- Matt Sealey <[EMAIL PROTECTED]> Genesi, Manager, Developer Relations Gerhard Pircher wrote: > Hi, > > I wonder, if there is a recommended way to specify ISA register addresses > and interrupts for a PCI device (unlike for a PCI2ISA b

Re: [Cbe-oss-dev] PS3 improved video mode autodetection for HDMI/DVI

2007-07-16 Thread Geert Uytterhoeven
On Fri, 13 Jul 2007, Ranulf Doswell wrote: > > > > Since 720p is a broadcast mode, I can't make it default to fullscreen, > > as a > > > > part of the image will fall off on most monitors. > > > > > Do you have any info from the EDID block that would tell you whether the > > > monitor displays the

Re: [PATCH 1/1] libata: pata_pdc2027x PLL input clock fix

2007-07-16 Thread Albert Lee
Mikael Pettersson wrote: > On Wed, 11 Jul 2007 10:45:35 +0800, Albert Lee wrote: > >>So, it seems both mdelay(37) and do_gettimeofday() are working properly on >>PowerMac G3. >>Maybe the calculated wrong PLL input is due to wrong reading of the counter >>register? >>Could you please try the atta

Re: possible dead CONFIG-related content under arch/powerpc

2007-07-16 Thread Geert Uytterhoeven
On Sat, 14 Jul 2007, Robert P. J. Day wrote: > == SPE_BASE == > arch/powerpc/mm/hash_utils_64.c:612:#ifdef CONFIG_SPE_BASE > arch/powerpc/mm/hash_utils_64.c:747:#ifdef CONFIG_SPE_BASE Interesting, should this one be CONFIG_SPU_BASE? With kind regards, Geert Uytterhoeven Software

Re: [patch] use __attribute__ in asm-powerpc

2007-07-16 Thread Geert Uytterhoeven
On Sat, 14 Jul 2007, Mike Frysinger wrote: > Pretty much everyone uses "__attribute__" or "attribute", no one > uses "__attribute". This patch tweaks the three places in asm-powerpc where > this comes up. While only asm-powerpc/types.h is interesting (for userspace), > I did asm-powerpc/processor

Re: [patch] use __attribute__ in asm-powerpc

2007-07-16 Thread Robert P. J. Day
On Mon, 16 Jul 2007, Geert Uytterhoeven wrote: > On Sat, 14 Jul 2007, Mike Frysinger wrote: > > Pretty much everyone uses "__attribute__" or "attribute", no one > > uses "__attribute". This patch tweaks the three places in asm-powerpc where > > this comes up. While only asm-powerpc/types.h is in

Re: [patch] use __attribute__ in asm-powerpc

2007-07-16 Thread Andreas Schwab
Geert Uytterhoeven <[EMAIL PROTECTED]> writes: > If the code is not exported to userspace (and thus not subject to different > compilers), I think the preferred form is plain `attribute'. That does not exist without underscores. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Lin

Re: [patch 5/6] ps3: BD/DVD/CD-ROM Storage Driver

2007-07-16 Thread Geert Uytterhoeven
On Fri, 13 Jul 2007, Geert Uytterhoeven wrote: > Ah, that explains it. flush_dcache_page() is used in some drivers. > I'll update my patches. Thanks for the comments! Does this look OK? - Replaced KM_USER0 by KM_IRQ0 (all routines are either called from an interrupt handler, from .request_fn

Re: [patch 5/6] ps3: BD/DVD/CD-ROM Storage Driver

2007-07-16 Thread Segher Boessenkool
>> I'm pretty sure that no ppc64 machine needs alias resolution in >> the kernel, >> although some are VIPT. Last time we discussed this, Segher >> explained it >> to me, but I don't remember which way Cell does it. IIRC, it >> automatically >> flushes cache lines that are accessed through al

Re: [patch 5/6] ps3: BD/DVD/CD-ROM Storage Driver

2007-07-16 Thread Jens Axboe
On Mon, Jul 16 2007, Geert Uytterhoeven wrote: > On Fri, 13 Jul 2007, Geert Uytterhoeven wrote: > > Ah, that explains it. flush_dcache_page() is used in some drivers. > > I'll update my patches. Thanks for the comments! > > Does this look OK? > - Replaced KM_USER0 by KM_IRQ0 (all routines are ei

Re: Legacy ISA registers/interrupts in PCI device tree node

2007-07-16 Thread Segher Boessenkool
> I wonder, if there is a recommended way to specify ISA register > addresses > and interrupts for a PCI device (unlike for a PCI2ISA bridge)? The PCI binding describes the required way to do this. > The device in question is the integrated IDE controller of the VIA686B > southbridge, which wor

Re: [PATCH v2] Allow exec on 32-bit from readable, non-exec pages, with a warning.

2007-07-16 Thread Segher Boessenkool
Actually I see no good reason to enforce no-exec at all if we can't do it consistently. And if we're not going to enforce it then there is no point whinging about it. >>> >>> >>> I have a new patch with just this behaviour, Scott is >>> testing it on old glibc (I think

Re: [patch 5/6] ps3: BD/DVD/CD-ROM Storage Driver

2007-07-16 Thread Geert Uytterhoeven
On Mon, 16 Jul 2007, Jens Axboe wrote: > On Mon, Jul 16 2007, Geert Uytterhoeven wrote: > > On Fri, 13 Jul 2007, Geert Uytterhoeven wrote: > > > Ah, that explains it. flush_dcache_page() is used in some drivers. > > > I'll update my patches. Thanks for the comments! > > > > Does this look OK? > >

Re: possible dead CONFIG-related content under arch/powerpc

2007-07-16 Thread Michael Ellerman
On Mon, 2007-07-16 at 11:16 +0200, Geert Uytterhoeven wrote: > On Sat, 14 Jul 2007, Robert P. J. Day wrote: > > == SPE_BASE == > > arch/powerpc/mm/hash_utils_64.c:612:#ifdef CONFIG_SPE_BASE > > arch/powerpc/mm/hash_utils_64.c:747:#ifdef CONFIG_SPE_BASE > > Interesting, should this

Re: [patch 5/6] ps3: BD/DVD/CD-ROM Storage Driver

2007-07-16 Thread Jens Axboe
On Mon, Jul 16 2007, Geert Uytterhoeven wrote: > On Mon, 16 Jul 2007, Jens Axboe wrote: > > On Mon, Jul 16 2007, Geert Uytterhoeven wrote: > > > On Fri, 13 Jul 2007, Geert Uytterhoeven wrote: > > > > Ah, that explains it. flush_dcache_page() is used in some drivers. > > > > I'll update my patches.

Re: [patch 3/6] Add 8548 CDS PCI express controller node and PCI-X device node

2007-07-16 Thread Segher Boessenkool
>> is this the only fix, I've already applied a version of this to my >> tree (with the irq sense fix) and just want to make sure there isn't >> anything else. > I do not get more. > I'd like to enroll Segher's suggestion together with VIA chip function > in next step. > We need to make basic pcie

Re: [patch 5/6] ps3: BD/DVD/CD-ROM Storage Driver

2007-07-16 Thread Geert Uytterhoeven
On Mon, 16 Jul 2007, Geert Uytterhoeven wrote: > On Mon, 16 Jul 2007, Jens Axboe wrote: > > On Mon, Jul 16 2007, Geert Uytterhoeven wrote: > > > On Fri, 13 Jul 2007, Geert Uytterhoeven wrote: > > > > Ah, that explains it. flush_dcache_page() is used in some drivers. > > > > I'll update my patches.

Re: Legacy ISA registers/interrupts in PCI device tree node

2007-07-16 Thread Gerhard Pircher
Original-Nachricht Datum: Mon, 16 Jul 2007 14:40:48 +0200 Von: Segher Boessenkool <[EMAIL PROTECTED]> An: Gerhard Pircher <[EMAIL PROTECTED]> CC: linuxppc-dev@ozlabs.org Betreff: Re: Legacy ISA registers/interrupts in PCI device tree node > > I wonder, if there is a recommended

Re: [patch 5/6] ps3: BD/DVD/CD-ROM Storage Driver

2007-07-16 Thread Jens Axboe
On Mon, Jul 16 2007, Geert Uytterhoeven wrote: > On Mon, 16 Jul 2007, Geert Uytterhoeven wrote: > > On Mon, 16 Jul 2007, Jens Axboe wrote: > > > On Mon, Jul 16 2007, Geert Uytterhoeven wrote: > > > > On Fri, 13 Jul 2007, Geert Uytterhoeven wrote: > > > > > Ah, that explains it. flush_dcache_page()

Re: [patch 5/6] ps3: BD/DVD/CD-ROM Storage Driver

2007-07-16 Thread James Bottomley
On Mon, 2007-07-16 at 14:16 +0200, Jens Axboe wrote: > On Mon, Jul 16 2007, Geert Uytterhoeven wrote: > > On Fri, 13 Jul 2007, Geert Uytterhoeven wrote: > > > Ah, that explains it. flush_dcache_page() is used in some drivers. > > > I'll update my patches. Thanks for the comments! > > > > Does this

Re: [patch 3/6] Add 8548 CDS PCI express controller node and PCI-X device node

2007-07-16 Thread Kumar Gala
On Jul 16, 2007, at 8:05 AM, Segher Boessenkool wrote: >>> is this the only fix, I've already applied a version of this to my >>> tree (with the irq sense fix) and just want to make sure there isn't >>> anything else. >> I do not get more. >> I'd like to enroll Segher's suggestion together with V

Re: [RFC][PATCH 6/8] Walnut DTS

2007-07-16 Thread Segher Boessenkool
>>> + #address-cells = <0>; >>> + #size-cells = <0>; >> >> No need for these. > > Isn't a good practice to put #address-cells in interrupt controller > nodes? It is not. > If the device tree has an interrupt map defined the interrupt > parent 'unit interrupt specifier' has to

Re: [patch 5/6] ps3: BD/DVD/CD-ROM Storage Driver

2007-07-16 Thread Jens Axboe
On Mon, Jul 16 2007, James Bottomley wrote: > On Mon, 2007-07-16 at 14:16 +0200, Jens Axboe wrote: > > On Mon, Jul 16 2007, Geert Uytterhoeven wrote: > > > On Fri, 13 Jul 2007, Geert Uytterhoeven wrote: > > > > Ah, that explains it. flush_dcache_page() is used in some drivers. > > > > I'll update m

Re: [PATCH 1/4] Add DMA sector to Documentation/powerpc/booting-without-of.txt file.

2007-07-16 Thread Segher Boessenkool
> I thought the idea of the dts/of was for the hardware specific boot > loader to tell the kernel about hardware that the kernel couldn't > otherwise know about, because its not detectable by a bus probe > method, > etc. Its not there to tell you how to use the device or arbitrate > which > oth

Re: [PATCH 1/4] Add DMA sector to Documentation/powerpc/booting-without-of.txt file.

2007-07-16 Thread Segher Boessenkool
> It's not that bad in most respects, though unlike some, I don't > think we need to stick dogmatically to the exact way that Open > Firmware(tm) did everything. s/did/does/ And for the record: neither do I. Segher ___ Linuxppc-dev mailing list L

Re: [patch 5/6] ps3: BD/DVD/CD-ROM Storage Driver

2007-07-16 Thread Geert Uytterhoeven
On Mon, 16 Jul 2007, Jens Axboe wrote: > On Mon, Jul 16 2007, James Bottomley wrote: > > On Mon, 2007-07-16 at 14:16 +0200, Jens Axboe wrote: > > > On Mon, Jul 16 2007, Geert Uytterhoeven wrote: > > > > On Fri, 13 Jul 2007, Geert Uytterhoeven wrote: > > > > > Ah, that explains it. flush_dcache_page

Re: [patch 3/6] Add 8548 CDS PCI express controller node and PCI-X device node

2007-07-16 Thread Segher Boessenkool
is this the only fix, I've already applied a version of this to my tree (with the irq sense fix) and just want to make sure there isn't anything else. >>> I do not get more. >>> I'd like to enroll Segher's suggestion together with VIA chip >>> function >>> in next step. >>>

Re: Legacy ISA registers/interrupts in PCI device tree node

2007-07-16 Thread Segher Boessenkool
>>> I wonder, if there is a recommended way to specify ISA register >>> addresses and interrupts for a PCI device (unlike for a PCI2ISA >>> bridge)? >> >> The PCI binding describes the required way to do this. > Hmm, I must reread the PCI binding spec. It didn't seem to contain any > information ab

Re: hvc_iseries not working

2007-07-16 Thread Will Schmidt
On Fri, 2007-07-13 at 19:05 +0200, Olaf Hering wrote: > 2.6.21 arch/powerpc/configs/iseries_defconfig works on an i825 with v5r4 > 2.6.22 arch/powerpc/configs/iseries_defconfig does not. But it works on > a i820 with v5r3. > 2.6.22 boots ok with CONFIG_VIOCONS When it works, do you have more than

Re: [PATCH 01/10] IB/ehca: Support for multiple event queues

2007-07-16 Thread Roland Dreier
> The eHCA driver can now handle multiple event queues (read: interrupt > sources) instead of one. The number of available EQs is selected via the > nr_eqs module parameter. > CQs are either assigned to the EQs based on the comp_vector index or, if the > dist_eqs module parameter is supplied,

Re: How to add platform specific data to a of_device

2007-07-16 Thread Segher Boessenkool
>> Hmm, as I stated above: Handling the SPI slave devices is done in >> the SPI >> framework. But including this data into the dts sounds better than >> including >> it into the BSP. Is there some documentation around how to >> describe such a >> SPI bus with its devices in the dts? > > I don

Re: How to add platform specific data to a of_device

2007-07-16 Thread Segher Boessenkool
> Is there a reason why there is sooo much interaction of the > platform code with the oftree? Yes. Since the decision has been made to require a device tree for every platform, arch/powerpc is in the luxury position that we can actually exploit the benefits of _having_ a tree for every platform.

[patch 0/3] PS3 Storage Drivers for 2.6.23, take 5

2007-07-16 Thread Geert Uytterhoeven
Hi, These are the remaining patches of the new PS3 storage drivers series: [1] ps3: Disk Storage Driver [2] ps3: BD/DVD/CD-ROM Storage Driver [3] ps3: FLASH ROM Storage Driver They are based on: - the current Linux kernel source tree, - plus the PS3 patches already submitted by

[patch 1/3] ps3: Disk Storage Driver

2007-07-16 Thread Geert Uytterhoeven
From: Geert Uytterhoeven <[EMAIL PROTECTED]> Add a Disk Storage Driver for the PS3: - Implemented as a block device driver with a dynamic major - Disk names (and partitions) are of the format ps3d%c(%u) - Uses software scatter-gather with a 64 KiB bounce buffer as the hypervisor doesn't

[patch 3/3] ps3: FLASH ROM Storage Driver

2007-07-16 Thread Geert Uytterhoeven
From: Geert Uytterhoeven <[EMAIL PROTECTED]> Add a FLASH ROM Storage Driver for the PS3: - Implemented as a misc character device driver - Uses a fixed 256 KiB buffer allocated from boot memory as the hypervisor requires the writing of aligned 256 KiB blocks CC: Geoff Levand <[EMAIL PROTE

[patch 2/3] ps3: BD/DVD/CD-ROM Storage Driver

2007-07-16 Thread Geert Uytterhoeven
From: Geert Uytterhoeven <[EMAIL PROTECTED]> Add a BD/DVD/CD-ROM Storage Driver for the PS3: - Implemented as a SCSI device driver - Uses software scatter-gather with a 64 KiB bounce buffer as the hypervisor doesn't support scatter-gather CC: Geoff Levand <[EMAIL PROTECTED]> Signed-off-by

Re: How to add platform specific data to a of_device

2007-07-16 Thread Segher Boessenkool
> As I wrote a couple of times already, it's a perfectly acceptable > approach to have "constructors" (what you call oftree-interpreter) > that > generate platform devices from the OF tree. Yes, lots of the "glue" code could be made into some helper library. Also, while that glue code might be

[PATCH] cell: CONFIG_SPE_BASE is a typo (was: Re: possible dead CONFIG-related content under arch/powerpc)

2007-07-16 Thread Geert Uytterhoeven
The config symbol for SPE support is called CONFIG_SPU_BASE, not CONFIG_SPE_BASE. Signed-off-by: Geert Uytterhoeven <[EMAIL PROTECTED]> diff --git a/arch/powerpc/mm/hash_utils_64.c b/arch/powerpc/mm/hash_utils_64.c index 4f2f453..0b25d42 100644 --- a/arch/powerpc/mm/hash_utils_64.c +++ b/arch/pow

Re: How to add platform specific data to a of_device

2007-07-16 Thread Segher Boessenkool
>> Well, they aren't supposed to :-) The problem at this point is >> more due >> to the fact that for things that haven't been specified by >> official OF >> bindings, people are going all over trying to define their own and >> sometimes conflicting bindings and then changing them. > > I think

Re: [patch] use __attribute__ in asm-powerpc

2007-07-16 Thread Mike Frysinger
On Monday 16 July 2007, Geert Uytterhoeven wrote: > On Sat, 14 Jul 2007, Mike Frysinger wrote: > > Pretty much everyone uses "__attribute__" or "attribute", no one > > uses "__attribute". This patch tweaks the three places in asm-powerpc > > where this comes up. While only asm-powerpc/types.h is

Re: [PATCH 2/2] Add PCI/PCI Express node for 8544DS board]

2007-07-16 Thread Segher Boessenkool
It looks real good now :-) One tiny comment... > + [EMAIL PROTECTED] { > + compatible = "fsl,mpc8548-pcie"; I would name the node [EMAIL PROTECTED] instead; generic names aren't for machine consumption anyway, and most humans want to know which buses are plain PCI

Re: [PATCH 04/10] IB/ehca: use common error code mapping instead of specific ones

2007-07-16 Thread Roland Dreier
> @@ -161,8 +161,11 @@ static inline int ehca2ib_return_code(u64 ehca_rc) applied, but as a further cleanup it seems that ehca2ib_return_code() should be moved into a .c file and moved out of line -- I think it would probably shrink the compiled code quite a bit, and as far as I can see it is nev

Re: [PATCH] crash in 2.6.22-git2 sysctl_set_parent()

2007-07-16 Thread Linas Vepstas
On Fri, Jul 13, 2007 at 07:06:56PM -0600, Eric W. Biederman wrote: > > .data = &ipv4_devconf.loop, > > .maxlen = sizeof(int), > > .mode = 0644, > > + .child = 0x0, > > .pro

RE: [PATCH] Fix Tsi108 ethernet driver performance

2007-07-16 Thread Alexandre Bounine
I agree that 20 ms is not the best option. But, as you mentioned as well, shorter period may bring more wasted CPU cycles. Using this approach to interrupt moderation I see performance improvement using frame flow that generates about one interrupt per frame. Below are CPU usage numbers reported by

Re: [PATCH] crash in 2.6.22-git2 sysctl_set_parent()

2007-07-16 Thread Linas Vepstas
On Fri, Jul 13, 2007 at 03:47:02PM -0700, David Miller wrote: > From: [EMAIL PROTECTED] (Linas Vepstas) > Date: Fri, 13 Jul 2007 15:05:15 -0500 > > > > > This is a patch (& bug report) for a crash in sysctl_set_parent() > > in 2.6.22-git2. > > > > Problem: 2.6.22-git2 crashes with a stack trac

[PATCH] Fix Tsi108 ethernet driver performance

2007-07-16 Thread Alexandre Bounine
From: Alexandre Bounine <[EMAIL PROTECTED]> This patch improves performance of the Tsi108 Ethernet driver by changing interrupt handling for frame receive path. It reduces number of interrupts generated for received frames and therefore lowers CPU utilization by the device driver. Signed-off-b

Re: [PATCH 10/10] IB/ehca: Support large page MRs

2007-07-16 Thread Roland Dreier
> Add support for MR pages larger than 4K on eHCA2. This reduces firmware > memory consumption. If enabled via the mr_largepage module parameter, the MR > page size will be determined based on the MR length and the hardware > capabilities - if the MR is >= 16M, 16M pages are used, for example.

[PATCH 0/3] 82xx: Add the support for Wind River SBC PowerQUICCII

2007-07-16 Thread Mark Zhan
These 3 patches add the powerpc support of Wind River SBC PowerQUICCII. 1) Currently, some mpc82xx platform hooks in mpc82xx_ads.c are actually not specific to ads board. So the 1st patch makes them be shared by different 82xx boards. 2) The 2nd patch make 'cpm_uart_of_init' be able to parse SM

Re: [PATCH] Update mpc7448hpc2 device tree to be compatible for tsi109 chip

2007-07-16 Thread Segher Boessenkool
> Update mpc7448hpc2 device tree to be compatible for tsi109 chip. > > Signed-off-by: Roy Zang <[EMAIL PROTECTED]> Looks good, thanks! Segher ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Help needed interpreting weird kOops

2007-07-16 Thread Simon Vallet
Hi, still working on mapping a Mach-O driver to ELF, I'm seeing a weird kOops when insmod'ing the driver : Jul 16 20:16:07 tertius kernel: Oops: Unrecoverable FP Unavailable Exception, sig: 6 [#1] Jul 16 20:16:07 tertius kernel: PREEMPT Jul 16 20:16:07 tertius kernel: Modules linked in: unicorn

[PATCH 2/3] 82xx: Parse SMC serial device node in DTS

2007-07-16 Thread Mark Zhan
This patch makes 'cpm_uart_of_init' be able to parses SMC serial device node in DTS Signed-off-by: Mark Zhan <[EMAIL PROTECTED]> --- arch/powerpc/sysdev/fsl_soc.c | 37 - 1 file changed, 20 insertions(+), 17 deletions(-) Index: linux-powerpc-2.6.x/arch/po

[PATCH 1/3] 82xx: some 82xx platform hook functions can be shared by different boards

2007-07-16 Thread Mark Zhan
Some mpc82xx platform hooks in mpc82xx_ads.c are actually not specific to ads board, they could be shared by different 82xx boards. Signed-off-by: Mark Zhan <[EMAIL PROTECTED]> --- arch/powerpc/platforms/82xx/mpc82xx.c | 30 +++ arch/powerpc/platforms/82xx/mpc82xx_ad

[PATCH 3/3] 82xx: SBCPQ2 board platform support

2007-07-16 Thread Mark Zhan
This patch addes the powerpc support to Wind River SBC PowerQUICCII 82xx board. Signed-off-by: Mark Zhan <[EMAIL PROTECTED]> --- arch/powerpc/boot/dts/sbcpq2.dts | 191 +++ arch/powerpc/configs/sbcpq2_defconfig | 917 ++ arch/powerpc/platforms/82xx/K

Re: [PATCH 01/10] IB/ehca: Support for multiple event queues

2007-07-16 Thread Joachim Fenkes
Roland Dreier <[EMAIL PROTECTED]> wrote on 16.07.2007 18:04:26: > It seems not quite right to me for the driver to advertise nr_eqs > completion vectors, but then if round-robin is turned on to ignore the > consumer's decision about which vector to use. The round-robin feature was primarily meant

Re: [PATCH 04/10] IB/ehca: use common error code mapping instead of specific ones

2007-07-16 Thread Joachim Fenkes
Roland Dreier <[EMAIL PROTECTED]> wrote on 16.07.2007 19:14:03: > applied, but as a further cleanup it seems that ehca2ib_return_code() > should be moved into a .c file and moved out of line -- I think it > would probably shrink the compiled code quite a bit, and as far as I > can see it is never

Re: [PATCH 01/10] IB/ehca: Support for multiple event queues

2007-07-16 Thread Hoang-Nam Nguyen
Roland Dreier <[EMAIL PROTECTED]> wrote on 16.07.2007 18:04:26: > Do you have any data on how well this round-robin assignment works? > It seems not quite right to me for the driver to advertise nr_eqs > completion vectors, but then if round-robin is turned on to ignore the > consumer's decision ab

[RFC][PATCH] therm_adt746x: fix behaviour on !ADT7460

2007-07-16 Thread Aristeu Rozanski
Hi, this bug exists since I began using a powerbook 12". When the system gets hot, therm_adt746x begins to oscillate between two fan speeds every one or two seconds. The result is very annoying not optimal: while switching between two speeds, the machine takes a long time to get cold again.

[PATCH] adbhid: enable KEY_FN key reporting

2007-07-16 Thread Aristeu Rozanski
When a Fn key is used in combination with another key in ADB keyboards it will generate a Fn event and then a second event that can be a different key than pressed (Fn + F1 for instance can generate Fn + brightness down if it's configured like that). This patch enables the reporting of the Fn key t

[PATCH 0/2] adb: make sysrq key configurable at runtime

2007-07-16 Thread Aristeu Rozanski
These two patches make possible to configure the sysrq key on ADB based machines where the default sysrq key (0x69) is not present. The first patch creates a class device for each handled device. The second one adds an attribute to ADB keyboards that makes possible to configure the sysrq key for ea

[PATCH 1/2] adb: create class devices for each adb device

2007-07-16 Thread Aristeu Rozanski
This patch adds a class device for each adb device that has a handler. The class device contents will be accessible by /sys/class/adb/N directory. This patch is needed in order to add an class device attribute to all keyboards that will determine the sysrq key for each keyboard. Signed-of-by: Aris

[PATCH 2/2] adbhid: make sysrq key configurable on adb keyboards

2007-07-16 Thread Aristeu Rozanski
This patch adds an sysfs attribute to each handled ADB keyboard in order to support runtime sysrq key configuration. This is needed because some machines don't have the default sysrq key (0x69). The key will be configurable by /sys/class/adb/keyboard/sysrq_key. Signed-of-by: Aristeu Rozanski <[EMA

Re: [PATCH 10/10] IB/ehca: Support large page MRs

2007-07-16 Thread Joachim Fenkes
Roland Dreier <[EMAIL PROTECTED]> wrote on 16.07.2007 19:37:09: > > If enabled via the mr_largepage module parameter, > > Why the module parameter? Is there any reason a user would want to > turn this off? Or conversely, why is it off by default? We're pretty confident this new feature works

of_flat_dt_is_compatible() scope Q

2007-07-16 Thread Guennadi Liakhovetski
Hi Just noticed, that of_flat_dt_is_compatible() is only ever used with node = of_get_flat_dt_root(). So, unless we ever plan to use it otherwise, someone might want to simplify it a bit:-) Thanks Guennadi --- Guennadi Liakhovetski ___ Linuxppc-dev ma

Re: Legacy ISA registers/interrupts in PCI device tree node

2007-07-16 Thread Benjamin Herrenschmidt
On Mon, 2007-07-16 at 09:59 +0100, Matt Sealey wrote: > You could do a LOT worse than check the Pegasos. Yes, mimmicing the pegasos will probably work > Matt Sealey <[EMAIL PROTECTED]> > Genesi, Manager, Developer Relations > > Gerhard Pircher wrote: > > Hi, > > > > I wonder, if there is a reco

Re: [patch 5/6] ps3: BD/DVD/CD-ROM Storage Driver

2007-07-16 Thread Benjamin Herrenschmidt
> Upon closer look, while flush_kernel_dcache_page() is a no-op on ppc64, > flush_dcache_page() isn't. So I'd prefer to not call it if not really needed. > > And according to James, flush_kernel_dcache_page() should be sufficient... > > So I'm getting puzzled again... flush_dcache_page() handle

Re: [patch 5/6] ps3: BD/DVD/CD-ROM Storage Driver

2007-07-16 Thread Benjamin Herrenschmidt
On Mon, 2007-07-16 at 08:47 -0500, James Bottomley wrote: > > No ... that was the point of flush_kernel_dcache_page(). The page in > question is page cache backed and contains user mappings. However, > the > block layer has already done a flush_dcache_page() in get_user_pages() > and the user sh

Re: [RFC][PATCH 6/8] Walnut DTS

2007-07-16 Thread Benjamin Herrenschmidt
On Mon, 2007-07-16 at 16:34 +0200, Segher Boessenkool wrote: > >>> + #address-cells = <0>; > >>> + #size-cells = <0>; > >> > >> No need for these. > > > > Isn't a good practice to put #address-cells in interrupt controller > > nodes? > > It is not. Well, that's debatable... but ye

Re: [patch 5/6] ps3: BD/DVD/CD-ROM Storage Driver

2007-07-16 Thread Benjamin Herrenschmidt
> No ... that was the point of flush_kernel_dcache_page(). The page in > question is page cache backed and contains user mappings. However, the > block layer has already done a flush_dcache_page() in get_user_pages() > and the user shouldn't be touching memory under I/O (unless they want > self

Re: [PATCH] cell: CONFIG_SPE_BASE is a typo (was: Re: possible dead CONFIG-related content under arch/powerpc)

2007-07-16 Thread Benjamin Herrenschmidt
On Mon, 2007-07-16 at 18:35 +0200, Geert Uytterhoeven wrote: > The config symbol for SPE support is called CONFIG_SPU_BASE, not > CONFIG_SPE_BASE. Oops... Arnd, we need to check the distro kernels here. > Signed-off-by: Geert Uytterhoeven <[EMAIL PROTECTED]> Acked-by: Benjamin Herrenschmidt <[EM

Re: [RFC][PATCH 6/8] Walnut DTS

2007-07-16 Thread Scott Wood
Benjamin Herrenschmidt wrote: > I would personally be inclined to define that whatever spec we come up > with always require #address-cells/#size-cells for any node that can > have either device children or interrupt children, and ban default > values alltogether. When is #size-cells used in the i

RE: [RFC][PATCH 6/8] Walnut DTS

2007-07-16 Thread Yoder Stuart-B08248
[snip] > There is no child device node, but there are child interrupt > nodes, and > since the interrupt-tree uses #address/size-cells, it does make some > sense to specify them. > > Yes, there is a default value when absent, but the simple > fact that the > default is different depending if yo

Re: [PATCH] crash in 2.6.22-git2 sysctl_set_parent()

2007-07-16 Thread David Miller
From: [EMAIL PROTECTED] (Linas Vepstas) Date: Mon, 16 Jul 2007 12:25:35 -0500 > On Fri, Jul 13, 2007 at 03:47:02PM -0700, David Miller wrote: > > From: [EMAIL PROTECTED] (Linas Vepstas) > > Date: Fri, 13 Jul 2007 15:05:15 -0500 > > > > > > > > This is a patch (& bug report) for a crash in sysctl

Re: [PATCH 1/1] eHEA: Introducing support vor DLPAR memory add

2007-07-16 Thread Jeff Garzik
Thomas Klein wrote: > This patch adds support for DLPAR memory add to the eHEA driver. To detect > whether memory was added the driver uses its own memory mapping table and > checks for kernel addresses whether they're located in already known memory > sections. If not the function ehea_rereg_mrs()

Re: [patch 5/6] ps3: BD/DVD/CD-ROM Storage Driver

2007-07-16 Thread James Bottomley
On Tue, 2007-07-17 at 07:49 +1000, Benjamin Herrenschmidt wrote: > > No ... that was the point of flush_kernel_dcache_page(). The page in > > question is page cache backed and contains user mappings. However, the > > block layer has already done a flush_dcache_page() in get_user_pages() > > and t

Re: [RFC][PATCH 6/8] Walnut DTS

2007-07-16 Thread Benjamin Herrenschmidt
On Mon, 2007-07-16 at 16:55 -0500, Scott Wood wrote: > Benjamin Herrenschmidt wrote: > > I would personally be inclined to define that whatever spec we come up > > with always require #address-cells/#size-cells for any node that can > > have either device children or interrupt children, and ban def

RE: [RFC][PATCH 6/8] Walnut DTS

2007-07-16 Thread Benjamin Herrenschmidt
> > I would personally be inclined to define that whatever spec we come up > > with always require #address-cells/#size-cells for any node that can > > have either device children or interrupt children, and ban default > > values alltogether. > > Did you really mean #size-cells here? Shouldn't i

Re: [patch 5/6] ps3: BD/DVD/CD-ROM Storage Driver

2007-07-16 Thread Benjamin Herrenschmidt
On Mon, 2007-07-16 at 17:03 -0500, James Bottomley wrote: > On Tue, 2007-07-17 at 07:49 +1000, Benjamin Herrenschmidt wrote: > > > No ... that was the point of flush_kernel_dcache_page(). The page in > > > question is page cache backed and contains user mappings. However, the > > > block layer ha

Re: [RFC][PATCH 6/8] Walnut DTS

2007-07-16 Thread Scott Wood
Benjamin Herrenschmidt wrote: > No, interrupt maps are useful in devices with no children in some corner > cases. Remember that a map doesnt need to use the address part of the > source specifier, thus it can be used to do a pure domain->domain > conversion of the irq numbers, what sort of thing. T

Re: [PATCH] Fix Tsi108 ethernet driver performance

2007-07-16 Thread Jeff Garzik
Alexandre Bounine wrote: > From: Alexandre Bounine <[EMAIL PROTECTED]> > > This patch improves performance of the Tsi108 Ethernet driver by > changing interrupt handling for frame receive path. It reduces number of > interrupts generated for received frames and therefore lowers CPU > utilization b

Re: [RFC][PATCH 6/8] Walnut DTS

2007-07-16 Thread Benjamin Herrenschmidt
On Mon, 2007-07-16 at 17:18 -0500, Scott Wood wrote: > > OK... but if you're doing a pure IRQ number conversion, the only useful > #address-cells would be zero, which makes it a reasonable default IMHO > (unlike the arbitrary 2 for regular traversal). It does make a reasonable default. The thi

Re: [PATCH] adbhid: enable KEY_FN key reporting

2007-07-16 Thread Benjamin Herrenschmidt
On Mon, 2007-07-16 at 16:53 -0400, Aristeu Rozanski wrote: > When a Fn key is used in combination with another key in ADB keyboards > it will generate a Fn event and then a second event that can be a > different key than pressed (Fn + F1 for instance can generate Fn + > brightness down if it's conf

Re: [PATCH 1/2] adb: create class devices for each adb device

2007-07-16 Thread Benjamin Herrenschmidt
On Mon, 2007-07-16 at 16:53 -0400, Aristeu Rozanski wrote: > This patch adds a class device for each adb device that has a handler. > The class device contents will be accessible by /sys/class/adb/N > directory. This patch is needed in order to add an class device > attribute to all keyboards that

[PATCH] PHY fixed driver: rework release path and update phy_id notation

2007-07-16 Thread Vitaly Bordug
device_bind_driver() error code returning has been fixed. release() function has been written, so that to free resources in correct way; the release path is now clean. Before the rework, it used to cause Device '[EMAIL PROTECTED]:1' does not have a release() function, it is broken and mu

Re: [PATCH 0/3] 82xx: Add the support for Wind River SBC PowerQUICCII

2007-07-16 Thread Vitaly Bordug
On Mon, 16 Jul 2007 17:01:28 +0800 Mark Zhan wrote: > These 3 patches add the powerpc support of Wind River SBC > PowerQUICCII. > I am sorry, but this would intercept with big 8xx/82xx series from Scott Wood I am reviewing now. it makes the initial merged code more maintainable and powerpc-frien

[PATCH] POWERPC: Added RTC support for mpc8313RDB and utilize "clock-frequency"

2007-07-16 Thread Vitaly Bordug
This enables DS1337 embedded RTC and uses "clock-frequency" property to configure loops_per_jiffy. Fixed spaces vs tabs issue in couple of places. Signed-off-by: Vitaly Bordug <[EMAIL PROTECTED]> --- arch/powerpc/platforms/83xx/mpc8313_rdb.c | 52 - 1 files change

[PATCH] POWERPC: add support of the GiGE switch for mpc8313RDB via fixed PHY

2007-07-16 Thread Vitaly Bordug
This utilises pretend phy, making access to it via device tree. GiGE switch is connected to TSEC1 with fixed gigE link, so we need to emulate it via artificial PHY to make it work. Signed-off-by: Vitaly Bordug <[EMAIL PROTECTED]> --- arch/powerpc/boot/dts/mpc8313erdb.dts |1 + arch/pow

[PATCH] USB_DR host support for FSL MPC831x

2007-07-16 Thread Vitaly Bordug
Modifies fsl_ehci code so that to get USB host working on mpc831x platform. Verified with MPC8313RDB reference board. Signed-off-by: Vitaly Bordug <[EMAIL PROTECTED]> --- arch/powerpc/boot/dts/mpc8313erdb.dts |1 + drivers/usb/host/ehci-fsl.c |4 +++- drivers/usb/host/ehci-hc

[PATCH] USB_DR device support for FSL MPC831x

2007-07-16 Thread Vitaly Bordug
This adds support for USB device mode on mpc831x series. Devicetree node modification is required to make it work - dr_mode ="peripheral"; which should be commented out if host mode is desired onboot. Signed-off-by: Vitaly Bordug <[EMAIL PROTECTED]> --- arch/powerpc/sysdev/fsl_soc.c |1

Re: [PATCH 1/3] 82xx: some 82xx platform hook functions can be shared by different boards

2007-07-16 Thread Arnd Bergmann
On Monday 16 July 2007, Mark Zhan wrote: > @@ -96,7 +94,7 @@ > pvid = mfspr(SPRN_PVR); > svid = mfspr(SPRN_SVR); > > - seq_printf(m, "Vendor\t\t: Freescale Semiconductor\n"); > + seq_printf(m, "Vendor\t\t: %s\n", CPUINFO_VENDOR); > seq_printf(m, "Machine\t\t: %s\n", CPUI

Re: [PATCH 2/3] 82xx: Parse SMC serial device node in DTS

2007-07-16 Thread Arnd Bergmann
On Monday 16 July 2007, Mark Zhan wrote: > -   cpm_uart_data.uart_clk = ppc_proc_freq; > +   if (strstr(model, "SMC")) { > +   cpm_uart_dev = > platform_device_register_simple("fsl-cpm-smc:uart", > +   

[PATCH] POWERPC 8xx: bump up initial memory limit for 8xx

2007-07-16 Thread Vitaly Bordug
From: John Traill <[EMAIL PROTECTED]> The 8xx can only support a max of 8M during early boot ( it seems a lot of 8xx boards only have 8M so the bug was never triggered ). The following change makes it able to run with 128M. Signed-off-by: Vitaly Bordug <[EMAIL PROTECTED]> --- arch/powerpc/mm/

[PATCH 2.6.22-rc7 0/4] phy/gianfar: Fixes for gianfar and vitesse RGMII-ID support

2007-07-16 Thread Andy Fleming
A few bugs in the Vitesse PHY driver were found on the 8641D HPCN board. Originally, they were masked by a bug in the PHY Lib which was fixed by patch 5f708dd91d15876e26d7a57f97a255cedffca463 (Fix phy_id for Vitesse 824x PHY). That patch allowed the Vitesse PHY to bind on the 8641D HPCN board, the

[PATCH 4/4] gianfar: Fix RGMII-ID handling in gianfar

2007-07-16 Thread Andy Fleming
The TSEC/eTSEC can detect the interface to the PHY automatically, but it isn't able to detect whether the RGMII connection needs internal delay. So we need to detect that change in the device tree, propagate it to the platform data, and then check it if we're in RGMII. This fixes a bug on the 864

[PATCH 1/4] phy: Fix Vitesse 824x PHY interrupt acking

2007-07-16 Thread Andy Fleming
The Vitesse 824x PHY doesn't allow an interrupt to be cleared if the mask bit for that interrupt isn't set. This means that the PHY Lib's order of handling interrupts (disable, then clear) breaks on this PHY. However, clearing then disabling the interrupt opens up the code for a silly race condit

  1   2   >