Re: powerpc: use time64_t in read_persistent_clock

2018-06-18 Thread Arnd Bergmann
On Thu, Jun 14, 2018 at 9:03 PM, Mathieu Malaterre wrote: > On Thu, Jun 14, 2018 at 1:46 PM Arnd Bergmann wrote: >> On Wed, Jun 13, 2018 at 10:24 PM, Mathieu Malaterre wrote: > >> Can you confirm that this patch addresses your problem? > > Yes ! > > Before: > [5.986710] rtc-generic rtc-gener

Re: powerpc: use time64_t in read_persistent_clock

2018-06-14 Thread Mathieu Malaterre
On Thu, Jun 14, 2018 at 1:46 PM Arnd Bergmann wrote: > > On Wed, Jun 13, 2018 at 10:24 PM, Mathieu Malaterre wrote: > > Arnd, > > > > In 5bfd643583b2e I can see that you changed: > > > > $ git show 5bfd643583b2e -- arch/powerpc/platforms/powermac/time.c > > [...] > > #ifdef CONFIG_ADB_PMU > > -s

Re: powerpc: use time64_t in read_persistent_clock

2018-06-14 Thread Arnd Bergmann
On Wed, Jun 13, 2018 at 10:24 PM, Mathieu Malaterre wrote: > Arnd, > > In 5bfd643583b2e I can see that you changed: > > $ git show 5bfd643583b2e -- arch/powerpc/platforms/powermac/time.c > [...] > #ifdef CONFIG_ADB_PMU > -static unsigned long pmu_get_time(void) > +static time64_t pmu_get_time(voi

powerpc: use time64_t in read_persistent_clock

2018-06-13 Thread Mathieu Malaterre
Arnd, In 5bfd643583b2e I can see that you changed: $ git show 5bfd643583b2e -- arch/powerpc/platforms/powermac/time.c [...] #ifdef CONFIG_ADB_PMU -static unsigned long pmu_get_time(void) +static time64_t pmu_get_time(void) { struct adb_request req; - unsigned int now; + time

Re: [PATCH 3/5] powerpc: use time64_t in read_persistent_clock

2018-04-23 Thread kbuild test robot
Hi Arnd, I love your patch! Yet something to improve: [auto build test ERROR on powerpc/next] [also build test ERROR on v4.17-rc2 next-20180423] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/A

[PATCH 3/5] powerpc: use time64_t in read_persistent_clock

2018-04-23 Thread Arnd Bergmann
Looking through the remaining users of the deprecated mktime() function, I found the powerpc rtc handlers, which use it in place of rtc_tm_to_time64(). To clean this up, I'm changing over the read_persistent_clock() function to the read_persistent_clock64() variant, and change all the platform spe

Re: [PATCH 3/5] powerpc: use time64_t in read_persistent_clock

2018-04-23 Thread Arnd Bergmann
On Mon, Apr 23, 2018 at 10:10 AM, Arnd Bergmann wrote: > @@ -170,7 +170,6 @@ unsigned long __init maple_get_boot_time(void) > request_resource(&ioport_resource, &rtc_iores); > > maple_get_rtc_time(&tm); > - return mktime(tm.tm_year+1900, tm.tm_mon+1, tm.tm_mday, > -

[PATCH 3/5] powerpc: use time64_t in read_persistent_clock

2018-04-23 Thread Arnd Bergmann
Looking through the remaining users of the deprecated mktime() function, I found the powerpc rtc handlers, which use it in place of rtc_tm_to_time64(). To clean this up, I'm changing over the read_persistent_clock() function to the read_persistent_clock64() variant, and change all the platform spe