Hi Arnd,

I love your patch! Yet something to improve:

[auto build test ERROR on powerpc/next]
[also build test ERROR on v4.17-rc2 next-20180423]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:    
https://github.com/0day-ci/linux/commits/Arnd-Bergmann/powerpc-always-enable-RTC_LIB/20180423-223504
base:   https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
config: powerpc64-defconfig (attached as .config)
compiler: powerpc64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
        wget 
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O 
~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=powerpc64 

All errors (new ones prefixed by >>):

   arch/powerpc/platforms/maple/time.c: In function 'maple_get_boot_time':
>> arch/powerpc/platforms/maple/time.c:173:9: error: implicit declaration of 
>> function 'rtc_tm_to_time66'; did you mean 'rtc_tm_to_time64'? 
>> [-Werror=implicit-function-declaration]
     return rtc_tm_to_time66(&tm);
            ^~~~~~~~~~~~~~~~
            rtc_tm_to_time64
   cc1: all warnings being treated as errors

vim +173 arch/powerpc/platforms/maple/time.c

   139  
   140  time64_t __init maple_get_boot_time(void)
   141  {
   142          struct rtc_time tm;
   143          struct device_node *rtcs;
   144  
   145          rtcs = of_find_compatible_node(NULL, "rtc", "pnpPNP,b00");
   146          if (rtcs) {
   147                  struct resource r;
   148                  if (of_address_to_resource(rtcs, 0, &r)) {
   149                          printk(KERN_EMERG "Maple: Unable to translate 
RTC"
   150                                 " address\n");
   151                          goto bail;
   152                  }
   153                  if (!(r.flags & IORESOURCE_IO)) {
   154                          printk(KERN_EMERG "Maple: RTC address isn't 
PIO!\n");
   155                          goto bail;
   156                  }
   157                  maple_rtc_addr = r.start;
   158                  printk(KERN_INFO "Maple: Found RTC at IO 0x%x\n",
   159                         maple_rtc_addr);
   160          }
   161   bail:
   162          if (maple_rtc_addr == 0) {
   163                  maple_rtc_addr = RTC_PORT(0); /* legacy address */
   164                  printk(KERN_INFO "Maple: No device node for RTC, 
assuming "
   165                         "legacy address (0x%x)\n", maple_rtc_addr);
   166          }
   167  
   168          rtc_iores.start = maple_rtc_addr;
   169          rtc_iores.end = maple_rtc_addr + 7;
   170          request_resource(&ioport_resource, &rtc_iores);
   171  
   172          maple_get_rtc_time(&tm);
 > 173          return rtc_tm_to_time66(&tm);
   174  }
   175  

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip

Reply via email to