[PATCH, RESEND] powerpc/cell/oprofile: fix mutex locking for spu-oprofile

2008-10-15 Thread Arnd Bergmann
>From aa5810fa545515c9f383e3e649bd120bef9c7f29 Mon Sep 17 00:00:00 2001 From: Carl Love <[EMAIL PROTECTED]> Date: Fri, 8 Aug 2008 15:38:36 -0700 Subject: [PATCH] powerpc/cell/oprofile: fix mutex locking for spu-oprofile The issue is the SPU code is not holding the kernel mutex lock whi

Re: [Cbe-oss-dev] powerpc/cell/oprofile: fix mutex locking for spu-oprofile

2008-10-13 Thread Robert Richter
it://git.kernel.org/pub/scm/linux/kernel/git/rric/oprofile.git powerpc-for-paul Pending patches are: Carl Love (1): powerpc/cell/oprofile: fix mutex locking for spu-oprofile Roel Kluin (1): powerpc/cell/oprofile: vma_map: fix test o

Re: [Cbe-oss-dev] powerpc/cell/oprofile: fix mutex locking for spu-oprofile

2008-10-13 Thread Arnd Bergmann
t merge to get this commit below. I have rebased it on top of the current benh/powerpc/next branch. Thanks, Arnd <>< --- commit aa5810fa545515c9f383e3e649bd120bef9c7f29 Author: Carl Love <[EMAIL PROTECTED]> Date: Fri Aug 8 15:38:36 2008 -0700 powerpc/cell/oprofile: fix

Re: [Cbe-oss-dev] powerpc/cell/oprofile: fix mutex locking for spu-oprofile

2008-08-25 Thread Arnd Bergmann
On Monday 25 August 2008, Paul Mackerras wrote: > > > Since rc4 is out now, I understand if you feel more comfortable with > > putting the patch into -next instead of -merge. > > Linus has been getting stricter about only putting in fixes for > regressions and serious bugs (see his recent email t

Re: [Cbe-oss-dev] powerpc/cell/oprofile: fix mutex locking for spu-oprofile

2008-08-24 Thread Paul Mackerras
Arnd Bergmann writes: > The patch does not fix a regression, the spu-oprofile code basically never > worked. With the current code in Linux, samples in the profile buffer > can get corrupted because reader and writer to that buffer use different > locks for accessing it. It took us several iterati

Re: [Cbe-oss-dev] powerpc/cell/oprofile: fix mutex locking for spu-oprofile

2008-08-21 Thread Carl Love
On Thu, 2008-08-21 at 20:20 +1000, Michael Ellerman wrote: > On Thu, 2008-08-21 at 10:14 +0200, Arnd Bergmann wrote: > > On Thursday 21 August 2008, Paul Mackerras wrote: > > > Arnd Bergmann writes: > > > > > > > Paul, any chance we can still get this into 2.6.27? > > > > > > Possibly. We'll ne

Re: [Cbe-oss-dev] powerpc/cell/oprofile: fix mutex locking for spu-oprofile

2008-08-21 Thread Michael Ellerman
On Thu, 2008-08-21 at 10:14 +0200, Arnd Bergmann wrote: > On Thursday 21 August 2008, Paul Mackerras wrote: > > Arnd Bergmann writes: > > > > > Paul, any chance we can still get this into 2.6.27? > > > > Possibly. We'll need a really good explanation for Linus as to why > > this is needed (what

Re: [Cbe-oss-dev] powerpc/cell/oprofile: fix mutex locking for spu-oprofile

2008-08-21 Thread Arnd Bergmann
On Thursday 21 August 2008, Paul Mackerras wrote: > Arnd Bergmann writes: > > > Paul, any chance we can still get this into 2.6.27? > > Possibly. We'll need a really good explanation for Linus as to why > this is needed (what regression or serious bug this fixes) and why it > is late. Can you s

Re: powerpc/cell/oprofile: fix mutex locking for spu-oprofile

2008-08-20 Thread Paul Mackerras
Arnd Bergmann writes: > Paul, any chance we can still get this into 2.6.27? Possibly. We'll need a really good explanation for Linus as to why this is needed (what regression or serious bug this fixes) and why it is late. Can you send me something explaining that? > I've added the Ack and uplo

Re: powerpc/cell/oprofile: fix mutex locking for spu-oprofile

2008-08-20 Thread Carl Love
On Wed, 2008-08-20 at 14:39 +0200, Robert Richter wrote: > On 20.08.08 14:05:31, Arnd Bergmann wrote: > > On Wednesday 20 August 2008, Robert Richter wrote: > > > I am fine with the changes with the exception of removing > > > add_event_entry() from include/linux/oprofile.h. Though there is no > >

Re: powerpc/cell/oprofile: fix mutex locking for spu-oprofile

2008-08-20 Thread Arnd Bergmann
On Wednesday 20 August 2008, Robert Richter wrote: > > Signed-off-by: Carl Love <[EMAIL PROTECTED]> > > Signed-off-by: Maynard Johnson <[EMAIL PROTECTED]> > > Signed-off-by: Arnd Bergmann <[EMAIL PROTECTED]> > > Acked-by: Robert Richter <[EMAIL PROTECTED]> > Thanks Robert. Paul, any chance we

Re: powerpc/cell/oprofile: fix mutex locking for spu-oprofile

2008-08-20 Thread Robert Richter
On 11.08.08 09:25:07, Arnd Bergmann wrote: > From: Carl Love <[EMAIL PROTECTED]> > > The issue is the SPU code is not holding the kernel mutex lock while > adding samples to the kernel buffer. > > This patch creates per SPU buffers to hold the data. Data > is added to the buffers from in interru

Re: powerpc/cell/oprofile: fix mutex locking for spu-oprofile

2008-08-20 Thread Robert Richter
On 20.08.08 14:05:31, Arnd Bergmann wrote: > On Wednesday 20 August 2008, Robert Richter wrote: > > I am fine with the changes with the exception of removing > > add_event_entry() from include/linux/oprofile.h. Though there is no > > usage of the function also in other architectures anymore, this c

Re: powerpc/cell/oprofile: fix mutex locking for spu-oprofile

2008-08-20 Thread Arnd Bergmann
On Wednesday 20 August 2008, Robert Richter wrote: > I am fine with the changes with the exception of removing > add_event_entry() from include/linux/oprofile.h. Though there is no > usage of the function also in other architectures anymore, this change > in the API should be discussed on the oprof

Re: powerpc/cell/oprofile: fix mutex locking for spu-oprofile

2008-08-20 Thread Robert Richter
I am fine with the changes with the exception of removing add_event_entry() from include/linux/oprofile.h. Though there is no usage of the function also in other architectures anymore, this change in the API should be discussed on the oprofile mailing list. Please separate the change in a different

powerpc/cell/oprofile: fix mutex locking for spu-oprofile

2008-08-11 Thread Arnd Bergmann
From: Carl Love <[EMAIL PROTECTED]> The issue is the SPU code is not holding the kernel mutex lock while adding samples to the kernel buffer. This patch creates per SPU buffers to hold the data. Data is added to the buffers from in interrupt context. The data is periodically pushed to the kerne