Arnd Bergmann writes: > The patch does not fix a regression, the spu-oprofile code basically never > worked. With the current code in Linux, samples in the profile buffer > can get corrupted because reader and writer to that buffer use different > locks for accessing it. It took us several iterations to come up with > a solution that does not introduce other problems and I didn't want to > push an earlier version that would need more fixups. > > Since rc4 is out now, I understand if you feel more comfortable with > putting the patch into -next instead of -merge.
Linus has been getting stricter about only putting in fixes for regressions and serious bugs (see his recent email to Dave Airlie on LKML for instance). I assume that the corruption is just in the data that is supplied to userspace and doesn't extend to any kernel data structures. If it does then we have a much stronger argument for pushing this stuff for 2.6.27. > Note that the second patch is trivial and fixes an oopsable condition > of the kernel, so at least that should still go into 2.6.27. OK, I'll cherry-pick that one for my next batch for Linus. Paul. _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
