On Thu, 2009-04-30 at 04:19 +0100, Benjamin Herrenschmidt wrote:
>
> I fail to see the point of this "special" partition in the first
> place...
>
> Things would make more sense if you had a full flash device
> whose child nodes are the partitions.
That's the model I think I want to move to, and
On Wed, 2009-04-22 at 10:05 +0200, Ricardo Ribalda Delgado wrote:
> Sometimes, an special partition is included in the device tree including all
> the
> partitions. Like in:
>
> partit...@ff00 {
> reg = < 0x00 0x80 >;
> label = "Root File System";
> };
> partit...@ff80
Sometimes, an special partition is included in the device tree
including all the
partitions. Like in:
partit...@ff00 {
reg = < 0x00 0x80 >;
label = "Root File System";
};
partit...@ff80 {
reg = < 0x80 0x1a >;
label = "Bitstream";
};
...
f...@f
>--- a/drivers/mtd/ofpart.c
>+++ b/drivers/mtd/ofpart.c
>@@ -48,7 +48,9 @@ int __devinit of_mtd_parse_partitions(struct device *dev,
>
> /* check if this is a partition node */
> partname = of_get_property(pp, "name", &len);
>- if (strcmp(partname, "partiti
Sometimes, an special partition is included in the device tree including all the
partitions. Like in:
partit...@ff00 {
reg = < 0x00 0x80 >;
label = "Root File System";
};
partit...@ff80 {
reg = < 0x80 0x1a >;
label = "Bitstream";
};
...
f...@ff00
Hello Scott
It is definitively more elegant...
Let me send tomorrow a patch
On Wed, Apr 22, 2009 at 20:11, Scott Wood wrote:
> Ricardo Ribalda Delgado wrote:
>>
>> Hi Scott
>>
>>> Perhaps "compatible" should be used instead?
>>
>> What do you mean?
>>
>> if (strcmp(partname, "partition") || s
* Ricardo Ribalda Delgado | 2009-04-22 19:59:08 [+0200]:
>>
>> if (strcmp(partname, "partition") <= 0) {
>
>Anything alfabetically higher than partition (like "z" will pass
>the test :S)
You are totally right!
cheers
ben
___
Linuxppc
Ricardo Ribalda Delgado wrote:
Hi Scott
Perhaps "compatible" should be used instead?
What do you mean?
if (strcmp(partname, "partition") || strcmp(partname, "compatible") )
I can't see the advantages.
No, I mean:
foo {
compatible = "partition";
...
};
-Scott
Hello Benjamin
> Hi Recardo,
>
> I would suggest to do:
>
> if (strcmp(partname, "partition") <= 0) {
Anything alfabetically higher than partition (like "z" will pass
the test :S)
Regards
>
> cheers
> ben
>
>
--
Ricardo Ribalda
http://www.eps.uam.es/~rribalda/
Hi Scott
> Perhaps "compatible" should be used instead?
What do you mean?
if (strcmp(partname, "partition") || strcmp(partname, "compatible") )
I can't see the advantages.
>
>> Hi Recardo,
>>
>> I would suggest to do:
>>
>> if (strcmp(partname, "partition") <= 0) {
>
> Check wh
Benjamin Krill wrote:
--- a/drivers/mtd/ofpart.c
+++ b/drivers/mtd/ofpart.c
@@ -48,7 +48,7 @@ int __devinit of_mtd_parse_partitions(struct device *dev,
/* check if this is a partition node */
partname = of_get_property(pp, "name", &len);
- if (strcmp
>--- a/drivers/mtd/ofpart.c
>+++ b/drivers/mtd/ofpart.c
>@@ -48,7 +48,7 @@ int __devinit of_mtd_parse_partitions(struct device *dev,
>
> /* check if this is a partition node */
> partname = of_get_property(pp, "name", &len);
>- if (strcmp(partname, "partiti
Hello
You are right, remove the -1. I thought that strlen gives the #of
chars + 1 ('\0').
Thanks
On Wed, Apr 22, 2009 at 11:24, Peter Korsgaard wrote:
>> "Ricardo" == Ricardo Ribalda Delgado writes:
>
> Hi,
>
> Ricardo> Sometimes, an special partition is included in the device
> Ric
Sometimes, an special partition is included in the device tree including all the
partitions. Like in:
partit...@ff00 {
reg = < 0x00 0x80 >;
label = "Root File System";
};
partit...@ff80 {
reg = < 0x80 0x1a >;
label = "Bitstream";
};
...
partition
> "Ricardo" == Ricardo Ribalda Delgado writes:
Hi,
Ricardo> Sometimes, an special partition is included in the device
Ricardo> tree including all the partitions. Like in:
Ricardo> drivers/mtd/ofpart.c |3 ++-
Ricardo> 1 files changed, 2 insertions(+), 1 deletions(-)
Ricardo> diff
Sometimes, an special partition is included in the device tree including all the
partitions. Like in:
partit...@ff00 {
reg = < 0x00 0x80 >;
label = "Root File System";
};
partit...@ff80 {
reg = < 0x80 0x1a >;
label = "Bitstream";
};
...
parti
16 matches
Mail list logo
