Re: cxl: Fix wrong comparison in cxl_adapter_context_get()

2018-07-23 Thread Michael Ellerman
On Wed, 2018-07-04 at 15:28:33 UTC, Vaibhav Jain wrote: > Function atomic_inc_unless_negative() returns a bool to indicate > success/failure. However cxl_adapter_context_get() wrongly compares > the return value against '>=0' which will always be true. The patch > fixes this comparison to '==0' the

Re: [PATCH] cxl: Fix wrong comparison in cxl_adapter_context_get()

2018-07-05 Thread Frederic Barrat
Le 04/07/2018 à 17:28, Vaibhav Jain a écrit : Function atomic_inc_unless_negative() returns a bool to indicate success/failure. However cxl_adapter_context_get() wrongly compares the return value against '>=0' which will always be true. The patch fixes this comparison to '==0' there by also fi

Re: [PATCH] cxl: Fix wrong comparison in cxl_adapter_context_get()

2018-07-04 Thread Andrew Donnellan
On 05/07/18 01:28, Vaibhav Jain wrote: Function atomic_inc_unless_negative() returns a bool to indicate success/failure. However cxl_adapter_context_get() wrongly compares the return value against '>=0' which will always be true. The patch fixes this comparison to '==0' there by also fixing this

[PATCH] cxl: Fix wrong comparison in cxl_adapter_context_get()

2018-07-04 Thread Vaibhav Jain
Function atomic_inc_unless_negative() returns a bool to indicate success/failure. However cxl_adapter_context_get() wrongly compares the return value against '>=0' which will always be true. The patch fixes this comparison to '==0' there by also fixing this compile time warning: drivers/mi