On Wed, 2018-07-04 at 15:28:33 UTC, Vaibhav Jain wrote: > Function atomic_inc_unless_negative() returns a bool to indicate > success/failure. However cxl_adapter_context_get() wrongly compares > the return value against '>=0' which will always be true. The patch > fixes this comparison to '==0' there by also fixing this compile time > warning: > > drivers/misc/cxl/main.c:290 cxl_adapter_context_get() > warn: 'atomic_inc_unless_negative(&adapter->contexts_num)' is unsigned > > Cc: sta...@vger.kernel.org > Fixes: 70b565bbdb91 ("cxl: Prevent adapter reset if an active context exists") > Reported-by: Dan Carpenter <dan.carpen...@oracle.com> > Signed-off-by: Vaibhav Jain <vaib...@linux.ibm.com> > Acked-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com> > Acked-by: Frederic Barrat <fbar...@linux.vnet.ibm.com>
Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/ef6cb5f1a048fdf91ccee6d63d2bfa cheers