Hello Scott
It is definitively more elegant...
Let me send tomorrow a patch
On Wed, Apr 22, 2009 at 20:11, Scott Wood wrote:
> Ricardo Ribalda Delgado wrote:
>>
>> Hi Scott
>>
>>> Perhaps "compatible" should be used instead?
>>
>> What do you mean?
>>
>> if (strcmp(partname, "partition") || s
* Ricardo Ribalda Delgado | 2009-04-22 19:59:08 [+0200]:
>>
>> if (strcmp(partname, "partition") <= 0) {
>
>Anything alfabetically higher than partition (like "z" will pass
>the test :S)
You are totally right!
cheers
ben
___
Linuxppc
Ricardo Ribalda Delgado wrote:
Hi Scott
Perhaps "compatible" should be used instead?
What do you mean?
if (strcmp(partname, "partition") || strcmp(partname, "compatible") )
I can't see the advantages.
No, I mean:
foo {
compatible = "partition";
...
};
-Scott
Hello Benjamin
> Hi Recardo,
>
> I would suggest to do:
>
> if (strcmp(partname, "partition") <= 0) {
Anything alfabetically higher than partition (like "z" will pass
the test :S)
Regards
>
> cheers
> ben
>
>
--
Ricardo Ribalda
http://www.eps.uam.es/~rribalda/
Hi Scott
> Perhaps "compatible" should be used instead?
What do you mean?
if (strcmp(partname, "partition") || strcmp(partname, "compatible") )
I can't see the advantages.
>
>> Hi Recardo,
>>
>> I would suggest to do:
>>
>> if (strcmp(partname, "partition") <= 0) {
>
> Check wh
Benjamin Krill wrote:
--- a/drivers/mtd/ofpart.c
+++ b/drivers/mtd/ofpart.c
@@ -48,7 +48,7 @@ int __devinit of_mtd_parse_partitions(struct device *dev,
/* check if this is a partition node */
partname = of_get_property(pp, "name", &len);
- if (strcmp
>--- a/drivers/mtd/ofpart.c
>+++ b/drivers/mtd/ofpart.c
>@@ -48,7 +48,7 @@ int __devinit of_mtd_parse_partitions(struct device *dev,
>
> /* check if this is a partition node */
> partname = of_get_property(pp, "name", &len);
>- if (strcmp(partname, "partiti
