Re: [PATCH v5 05/21] powerpc: Use a function for getting the instruction op code

2020-04-08 Thread Jordan Niethe
On Thu, Apr 9, 2020 at 4:21 AM Segher Boessenkool wrote: > > Hi! > > On Mon, Apr 06, 2020 at 06:09:20PM +1000, Jordan Niethe wrote: > > +static inline int ppc_inst_opcode(u32 x) > > +{ > > + return x >> 26; > > +} > > Maybe you should have "primary opcode" in this function name? Thanks, that i

Re: [PATCH v5 05/21] powerpc: Use a function for getting the instruction op code

2020-04-08 Thread Segher Boessenkool
Hi! On Mon, Apr 06, 2020 at 06:09:20PM +1000, Jordan Niethe wrote: > +static inline int ppc_inst_opcode(u32 x) > +{ > + return x >> 26; > +} Maybe you should have "primary opcode" in this function name? Segher

Re: [PATCH v5 05/21] powerpc: Use a function for getting the instruction op code

2020-04-07 Thread Jordan Niethe
On Tue, Apr 7, 2020 at 5:05 PM Balamuruhan S wrote: > > On Mon, 2020-04-06 at 18:09 +1000, Jordan Niethe wrote: > > In preparation for using a data type for instructions that can not be > > directly used with the '>>' operator use a function for getting the op > > code of an instruction. > > vecem

Re: [PATCH v5 05/21] powerpc: Use a function for getting the instruction op code

2020-04-07 Thread Balamuruhan S
On Mon, 2020-04-06 at 18:09 +1000, Jordan Niethe wrote: > In preparation for using a data type for instructions that can not be > directly used with the '>>' operator use a function for getting the op > code of an instruction. vecemu.c and sstep.c will need ppc_inst_opcode(). -- Bala > > Signed

Re: [PATCH v5 05/21] powerpc: Use a function for getting the instruction op code

2020-04-06 Thread Jordan Niethe
On Mon, Apr 6, 2020 at 6:22 PM Christophe Leroy wrote: > > > > Le 06/04/2020 à 10:09, Jordan Niethe a écrit : > > In preparation for using a data type for instructions that can not be > > directly used with the '>>' operator use a function for getting the op > > code of an instruction. > > > > Sig

Re: [PATCH v5 05/21] powerpc: Use a function for getting the instruction op code

2020-04-06 Thread Christophe Leroy
Le 06/04/2020 à 10:09, Jordan Niethe a écrit : In preparation for using a data type for instructions that can not be directly used with the '>>' operator use a function for getting the op code of an instruction. Signed-off-by: Jordan Niethe --- v4: New to series --- arch/powerpc/include/as