Re: [PATCH v2 1/4] Add platform support for AmigaOne

2009-02-04 Thread John W. Linville
On Wed, Feb 04, 2009 at 10:35:31PM +0100, Gerhard Pircher wrote: > > Original-Nachricht > > Datum: Wed, 4 Feb 2009 21:59:41 +0100 > > Von: Gabriel Paubert > > An: Benjamin Herrenschmidt > > CC: Gerhard Pircher , linuxppc-dev list > >

Re: [PATCH v2 1/4] Add platform support for AmigaOne

2009-02-04 Thread Gerhard Pircher
Original-Nachricht > Datum: Wed, 4 Feb 2009 21:59:41 +0100 > Von: Gabriel Paubert > An: Benjamin Herrenschmidt > CC: Gerhard Pircher , linuxppc-dev list > > Betreff: Re: [PATCH v2 1/4] Add platform support for AmigaOne > On Wed, Feb 04, 2009 at 02:50

Re: [PATCH v2 1/4] Add platform support for AmigaOne

2009-02-04 Thread Gabriel Paubert
On Wed, Feb 04, 2009 at 02:50:07PM +1100, Benjamin Herrenschmidt wrote: > > > + hose->first_busno = bus_range ? bus_range[0] : 0; > > + hose->last_busno = bus_range ? bus_range[1] : 0xff; > > + > > + setup_indirect_pci(hose, 0xfec00cf8, 0xfee00cfc, 0); > > Minor in the context of amigaone but sti

Re: [PATCH v2 1/4] Add platform support for AmigaOne

2009-02-04 Thread Benjamin Herrenschmidt
On Wed, 2009-02-04 at 13:09 +0100, Gerhard Pircher wrote: > I agree that these addresses should come from the device-tree, but these > two config registers are not located within the normal PCI I/O address > space (0xfe00-0xfec0). > Maybe I should add a "reg" property to the PHB node, but I

Re: [PATCH v2 1/4] Add platform support for AmigaOne

2009-02-04 Thread Gerhard Pircher
Original-Nachricht > Datum: Wed, 04 Feb 2009 14:50:07 +1100 > Von: Benjamin Herrenschmidt > An: Gerhard Pircher > CC: linuxppc-dev list > Betreff: Re: [PATCH v2 1/4] Add platform support for AmigaOne > > + hose->first_busno = bus_range ? bus_

Re: [PATCH v2 1/4] Add platform support for AmigaOne

2009-02-03 Thread Benjamin Herrenschmidt
> + hose->first_busno = bus_range ? bus_range[0] : 0; > + hose->last_busno = bus_range ? bus_range[1] : 0xff; > + > + setup_indirect_pci(hose, 0xfec00cf8, 0xfee00cfc, 0); Minor in the context of amigaone but still... the above should come from the device-tree... I suppose those are really just IO