-------- Original-Nachricht -------- > Datum: Wed, 04 Feb 2009 14:50:07 +1100 > Von: Benjamin Herrenschmidt <b...@kernel.crashing.org> > An: Gerhard Pircher <gerhard_pirc...@gmx.net> > CC: linuxppc-dev list <linuxppc-dev@ozlabs.org> > Betreff: Re: [PATCH v2 1/4] Add platform support for AmigaOne
> > + hose->first_busno = bus_range ? bus_range[0] : 0; > > + hose->last_busno = bus_range ? bus_range[1] : 0xff; > > + > > + setup_indirect_pci(hose, 0xfec00cf8, 0xfee00cfc, 0); > > Minor in the context of amigaone but still... the above should come from > the device-tree... I suppose those are really just IO space addresses > cf8 and cfc, in which case, an option is to call that first: I agree that these addresses should come from the device-tree, but these two config registers are not located within the normal PCI I/O address space (0xfe000000-0xfec00000). Maybe I should add a "reg" property to the PHB node, but I don't know if this is the right approach. The OF PCI spec isn't very clear about this. What do you think? Gerhard -- Psssst! Schon vom neuen GMX MultiMessenger gehört? Der kann`s mit allen: http://www.gmx.net/de/go/multimessenger01 _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
