Re: [PATCH v2 1/2] powerpc: Board support for GE Fanuc SBC610

2008-08-26 Thread Martyn Welch
On Fri, 22 Aug 2008 12:11:35 -0500 Scott Wood <[EMAIL PROTECTED]> wrote: > On Fri, Aug 22, 2008 at 12:26:01PM +0100, Martyn Welch wrote: > > > > drop device_type. > > > > > > > > > > Ah - _all_ device_type! > > > > > > > Um, not all - just the ones where the name of the block matches the > > d

Re: [PATCH v2 1/2] powerpc: Board support for GE Fanuc SBC610

2008-08-23 Thread Kumar Gala
On Aug 22, 2008, at 6:11 AM, Martyn Welch wrote: +static void __init +gef_sbc610_init_irq(void) +{ + struct mpic *mpic1; + struct device_node *np; + struct resource res; + + /* Determine PIC address. */ + np = of_find_node_by_type(NULL, "open-pic"); + if (np

Re: [PATCH v2 1/2] powerpc: Board support for GE Fanuc SBC610

2008-08-23 Thread Kumar Gala
On Aug 22, 2008, at 12:11 PM, Scott Wood wrote: On Fri, Aug 22, 2008 at 12:26:01PM +0100, Martyn Welch wrote: drop device_type. Ah - _all_ device_type! Um, not all - just the ones where the name of the block matches the device type(?) All except "cpu" and "memory". I think "network"

Re: [PATCH v2 1/2] powerpc: Board support for GE Fanuc SBC610

2008-08-22 Thread Scott Wood
On Fri, Aug 22, 2008 at 12:26:01PM +0100, Martyn Welch wrote: > > > drop device_type. > > > > > > > Ah - _all_ device_type! > > > > Um, not all - just the ones where the name of the block matches the > device type(?) All except "cpu" and "memory". -Scott __

Re: [PATCH v2 1/2] powerpc: Board support for GE Fanuc SBC610

2008-08-22 Thread Scott Wood
On Fri, Aug 22, 2008 at 06:46:20AM -0400, Martyn Welch wrote: > + enet0: [EMAIL PROTECTED] { > + #address-cells = <1>; > + #size-cells = <0>; > + device_type = "network"; > + model = "eTSEC"; > +

Re: [PATCH v2 1/2] powerpc: Board support for GE Fanuc SBC610

2008-08-22 Thread Martyn Welch
On Fri, 22 Aug 2008 12:11:52 +0100 Martyn Welch <[EMAIL PROTECTED]> wrote: > On Fri, 22 Aug 2008 05:56:53 -0500 > Kumar Gala <[EMAIL PROTECTED]> wrote: > > > > > > > + PowerPC,[EMAIL PROTECTED] { > > > + device_type = "cpu"; > > > + reg = <0x>; > >

Re: [PATCH v2 1/2] powerpc: Board support for GE Fanuc SBC610

2008-08-22 Thread Martyn Welch
On Fri, 22 Aug 2008 05:56:53 -0500 Kumar Gala <[EMAIL PROTECTED]> wrote: > > > > + PowerPC,[EMAIL PROTECTED] { > > + device_type = "cpu"; > > + reg = <0x>; > > + d-cache-line-size = <32>; // 32 bytes > > +

Re: [PATCH v2 1/2] powerpc: Board support for GE Fanuc SBC610

2008-08-22 Thread Kumar Gala
+ PowerPC,[EMAIL PROTECTED] { + device_type = "cpu"; + reg = <0x>; + d-cache-line-size = <32>; // 32 bytes + i-cache-line-size = <32>; // 32 bytes + d-cache-size = <