+               PowerPC,[EMAIL PROTECTED] {
+                       device_type = "cpu";
+                       reg = <0x00000000>;
+                       d-cache-line-size = <32>; // 32 bytes
+                       i-cache-line-size = <32>; // 32 bytes
+                       d-cache-size = <32768>;           // L1, 32K
+                       i-cache-size = <32768>;           // L1, 32K
+                       timebase-frequency = <0>; // From uboot
+                       bus-frequency = <0>;              // From uboot
+                       clock-frequency = <0>;            // From uboot
+                       l2cr = <0x80000000>;              // Enable L2

do you expect the 'l2cr' prop to do anything? Not sure if this is something apple invented or you did?



+               i2c1: [EMAIL PROTECTED] {
+                       #address-cells = <1>;
+                       #size-cells = <0>;
+                       device_type = "i2c";

drop device_type.


+                       compatible = "fsl-i2c";
+                       reg = <0x00003000 0x00000100>;
+                       interrupts = <0x2b 0x2>;
+                       interrupt-parent = <&mpic>;
+                       dfsrr;
+
+                       [EMAIL PROTECTED] {
+                               compatible = "dallas,ds1682";
+                               reg = <0x0000006b>;
+                       };
+               };
+
+               i2c2: [EMAIL PROTECTED] {

I recommend having #addr/#size cells here.


+                       device_type = "i2c";

ditto

+                       compatible = "fsl-i2c";
+                       reg = <0x00003100 0x00000100>;
+                       interrupts = <0x2b 0x2>;
+                       interrupt-parent = <&mpic>;
+                       dfsrr;
+               };
+

+               [EMAIL PROTECTED] {
+                       #address-cells = <1>;
+                       #size-cells = <0>;
+                       device_type = "mdio";

drop device_type, (see a theme here ;)


+                       compatible = "fsl,gianfar-mdio";
+                       reg = <0x00024520 0x00000020>;
+
+                       phy0: [EMAIL PROTECTED] {
+                               interrupt-parent = <&mpic>;
+                               interrupts = <0x0 0x1>;
+                               reg = <0x00000001>;
+                               device_type = "ethernet-phy";

drop device_type.


+                       };
+                       phy2: [EMAIL PROTECTED] {
+                               interrupt-parent = <&mpic>;
+                               interrupts = <0x0 0x1>;
+                               reg = <0x00000003>;
+                               device_type = "ethernet-phy";

ditto


+                       };
+               };
+
+               enet0: [EMAIL PROTECTED] {
+                       #address-cells = <1>;
+                       #size-cells = <0>;

there is no need for #add/size cells here.


+                       device_type = "network";
+                       model = "eTSEC";
+                       compatible = "gianfar";
+                       reg = <0x00024000 0x00001000>;
+                       mac-address = [ 00 00 00 00 00 00 ]; // set by u-boot
+                       interrupts = <0x1d 0x2 0x1e 0x2 0x22 0x2>;
+                       interrupt-parent = <&mpic>;
+                       phy-handle = <&phy0>;
+                       phy-connection-type = "gmii";
+               };
+
+               enet1: [EMAIL PROTECTED] {
+                       #address-cells = <1>;
+                       #size-cells = <0>;

there is no need for #add/size cells here.


+                       device_type = "network";
+                       model = "eTSEC";
+                       compatible = "gianfar";
+                       reg = <0x00026000 0x00001000>;
+                       mac-address = [ 00 00 00 00 00 00 ]; // set by u-boot
+                       interrupts = <0x1f 0x2 0x20 0x2 0x21 0x2>;
+                       interrupt-parent = <&mpic>;
+                       phy-handle = <&phy2>;
+                       phy-connection-type = "gmii";
+               };
+

You may want to add in msi interrupts for PCIe support (see mpc8572ds.dtb)

+
+               mpic: [EMAIL PROTECTED] {
+                       clock-frequency = <0>;
+                       interrupt-controller;
+                       #address-cells = <0>;
+                       #interrupt-cells = <2>;
+                       reg = <0x00040000 0x00040000>;
+                       compatible = "chrp,open-pic";
+                       device_type = "open-pic";
+               };
+
+               [EMAIL PROTECTED] {
+                       compatible = "fsl,mpc8641-guts";
+                       reg = <0x000e0000 0x00001000>;
+                       fsl,has-rstcr;
+               };
+       };
+
+       pci0: [EMAIL PROTECTED] {
+               compatible = "fsl,mpc8641-pcie";
+               device_type = "pci";
+               #interrupt-cells = <1>;
+               #size-cells = <2>;
+               #address-cells = <3>;
+               reg = <0xfef08000 0x00001000>;
+               bus-range = <0x0 0xff>;
+               ranges = <0x02000000 0x0 0x80000000 0x80000000 0x0 0x40000000
+                         0x01000000 0x0 0x00000000 0xfe000000 0x0 0x00400000>;
+               clock-frequency = <33333333>;
+               interrupt-parent = <&mpic>;
+               interrupts = <0x18 0x2>;
+               interrupt-map-mask = <0xf800 0x0 0x0 0x7>;
+               interrupt-map = <
+                       0x0000 0x0 0x0 0x1 &mpic 0x0 0x1
+                       0x0000 0x0 0x0 0x2 &mpic 0x1 0x1
+                       0x0000 0x0 0x0 0x3 &mpic 0x2 0x1
+                       0x0000 0x0 0x0 0x4 &mpic 0x3 0x1
+               >;
+
+               [EMAIL PROTECTED] {
+                       reg = <0 0 0 0 0>;
+                       #size-cells = <2>;
+                       #address-cells = <3>;
+                       device_type = "pci";
+                       ranges = <0x02000000 0x0 0x80000000
+                                 0x02000000 0x0 0x80000000
+                                 0x0 0x40000000
+
+                                 0x01000000 0x0 0x00000000
+                                 0x01000000 0x0 0x00000000
+                                 0x0 0x00400000>;
+               };
+       };
+};



diff --git a/arch/powerpc/platforms/86xx/Makefile b/arch/powerpc/ platforms/86xx/Makefile
index 8fee37d..cb9fc8f 100644
--- a/arch/powerpc/platforms/86xx/Makefile
+++ b/arch/powerpc/platforms/86xx/Makefile
@@ -7,3 +7,4 @@ obj-$(CONFIG_SMP)               += mpc86xx_smp.o
obj-$(CONFIG_MPC8641_HPCN)      += mpc86xx_hpcn.o
obj-$(CONFIG_SBC8641D)          += sbc8641d.o
obj-$(CONFIG_MPC8610_HPCD)      += mpc8610_hpcd.o
+obj-$(CONFIG_GEF_SBC610)       += gef_sbc610.o
diff --git a/arch/powerpc/platforms/86xx/gef_sbc610.c b/arch/powerpc/ platforms/86xx/gef_sbc610.c
new file mode 100644
index 0000000..a1382da
--- /dev/null
+++ b/arch/powerpc/platforms/86xx/gef_sbc610.c
@@ -0,0 +1,177 @@
+/*
+ * GE Fanuc SBC610 board support
+ *
+ * Author: Martyn Welch <[EMAIL PROTECTED]>
+ *
+ * Copyright 2008 GE Fanuc Intelligent Platforms Embedded Systems, Inc.
+ *
+ * This program is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License as published by the + * Free Software Foundation; either version 2 of the License, or (at your
+ * option) any later version.
+ *
+ * Based on: mpc86xx_hpcn.c (MPC86xx HPCN board specific routines)
+ * Copyright 2006 Freescale Semiconductor Inc.
+ */
+
+#include <linux/stddef.h>
+#include <linux/kernel.h>
+#include <linux/pci.h>
+#include <linux/kdev_t.h>
+#include <linux/delay.h>
+#include <linux/seq_file.h>
+#include <linux/of_platform.h>
+
+#include <asm/system.h>
+#include <asm/time.h>
+#include <asm/machdep.h>
+#include <asm/pci-bridge.h>
+#include <asm/mpc86xx.h>
+#include <asm/prom.h>
+#include <mm/mmu_decl.h>
+#include <asm/udbg.h>
+
+#include <asm/mpic.h>
+
+#include <sysdev/fsl_pci.h>
+#include <sysdev/fsl_soc.h>
+
+#include "mpc86xx.h"
+
+#undef DEBUG
+
+#ifdef DEBUG
+#define DBG (fmt...) do { printk(KERN_ERR "SBC610: " fmt); } while (0)
+#else
+#define DBG (fmt...) do { } while (0)
+#endif
+
+static void __init
+gef_sbc610_init_irq(void)
+{
+       struct mpic *mpic1;
+       struct device_node *np;
+       struct resource res;
+
+       /* Determine PIC address. */
+       np = of_find_node_by_type(NULL, "open-pic");
+       if (np == NULL)
+               return;
+       of_address_to_resource(np, 0, &res);
+
+       mpic1 = mpic_alloc(np, res.start,
+                       MPIC_PRIMARY | MPIC_WANTS_RESET | MPIC_BIG_ENDIAN,
+                       0, 256, "mpic");
+       of_node_put(np);
+       BUG_ON(mpic1 == NULL);
+
+       mpic_init(mpic1);
+}

any reason not to use mpc86xx_init_irq() in pic.c?


- k
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev

Reply via email to