Re: [PATCH v2] net: fec_mpc52xx: Read MAC address from device-tree

2013-02-12 Thread David Miller
From: Stefan Roese Date: Tue, 12 Feb 2013 10:08:08 +0100 > Until now, the MPC5200 FEC ethernet driver relied upon the bootloader > (U-Boot) to write the MAC address into the ethernet controller > registers. The Linux driver should not rely on such a thing. So > lets read the MAC address from the

Re: [PATCH v2] net: fec_mpc52xx: Read MAC address from device-tree

2013-02-12 Thread David Miller
From: Bhushan Bharat-R65777 Date: Tue, 12 Feb 2013 10:56:05 + > Why we read from MAC registers if Linux should not rely on bootloader? Because it used to and if you just remove that code then you break existing setups, and I explicitly told him to code things this way. __

Re: [PATCH v2] net: fec_mpc52xx: Read MAC address from device-tree

2013-02-12 Thread Timur Tabi
On Tue, Feb 12, 2013 at 3:08 AM, Stefan Roese wrote: > +* First try to read MAC address from DT > +*/ > + p = of_get_property(np, "local-mac-address", NULL); of_get_mac_address() ___ Linuxppc-dev mailing list Linuxppc-dev@lists.oz

Re: [PATCH v2] net: fec_mpc52xx: Read MAC address from device-tree

2013-02-12 Thread Stefan Roese
On 12.02.2013 12:23, Bhushan Bharat-R65777 wrote: >>> Why we read from MAC registers if Linux should not rely on bootloader? >> >> It was suggested by David. Backwards compatibility. Here Davids comment to my >> original patch which removed this register reading completely: >> >> " >> I don't think

RE: [PATCH v2] net: fec_mpc52xx: Read MAC address from device-tree

2013-02-12 Thread Bhushan Bharat-R65777
> -Original Message- > From: Stefan Roese [mailto:s...@denx.de] > Sent: Tuesday, February 12, 2013 4:34 PM > To: Bhushan Bharat-R65777 > Cc: net...@vger.kernel.org; linuxppc-...@ozlabs.org; Anatolij Gustschin; David > S. Miller > Subject: Re: [PATCH v2] net: fec_mpc5

Re: [PATCH v2] net: fec_mpc52xx: Read MAC address from device-tree

2013-02-12 Thread Stefan Roese
On 12.02.2013 11:56, Bhushan Bharat-R65777 wrote: >> Until now, the MPC5200 FEC ethernet driver relied upon the bootloader >> (U-Boot) to write the MAC address into the ethernet controller registers. The >> Linux driver should not rely on such a thing. So lets read the MAC address >> from >> the D

RE: [PATCH v2] net: fec_mpc52xx: Read MAC address from device-tree

2013-02-12 Thread Bhushan Bharat-R65777
> -Original Message- > From: Linuxppc-dev [mailto:linuxppc-dev- > bounces+bharat.bhushan=freescale@lists.ozlabs.org] On Behalf Of Stefan > Roese > Sent: Tuesday, February 12, 2013 2:38 PM > To: net...@vger.kernel.org > Cc: linuxppc-...@ozlabs.org; Anatolij Gustschin > Subject: [PATCH