On Wed, Sep 05, 2007 at 11:39:57AM +0400, Vitaly Bordug wrote:
> > Note that this code is mostly duplicated from the existing CPM2
> > version.
> >
> Then it would be good to mention that in short comment block before function.
The code would very quickly become unreadable if we kept comments aro
On Fri, 31 Aug 2007 15:44:18 -0500
Scott Wood wrote:
> > > + u32 mask = 7;
> > > +
> > gotta at least briefly explain the clue here, too.
>
> I'm not sure what you mean... what exactly are you asking me to
> explain?
>
> Note that this code is mostly duplicated from the existing CPM2
> versi
On Thu, Aug 30, 2007 at 01:38:33AM +0400, Vitaly Bordug wrote:
> On Tue, 28 Aug 2007 15:17:19 -0500
> Scott Wood wrote:
> > +struct cpm_ioport16 {
> > + __be16 dir, par, sor, dat, intr;
> > + __be16 res[3];
> > +};
> > +
> Hmm. If we are using such a non-standard types, it worths at least
> exp
On Tue, 28 Aug 2007 15:17:19 -0500
Scott Wood wrote:
> These let board code set up pins and clocks without having to
> put magic numbers directly into the registers.
>
I personally is not fond of such idea, but it would make this more
understandable eases transfer to feature_call
or qe pin setti
