On Fri, 31 Aug 2007 15:44:18 -0500 Scott Wood wrote: > > > + u32 mask = 7; > > > + > > gotta at least briefly explain the clue here, too. > > I'm not sure what you mean... what exactly are you asking me to > explain? > > Note that this code is mostly duplicated from the existing CPM2 > version. > Then it would be good to mention that in short comment block before function.
> > We're adding helper functions and should be ready that something > > somewhere won't work as expected. > > Could you elaborate on what you expect to possibly not work, or what > we should do to "be ready"? Some new PQ-like board being added to powerpc. I mean, each newly-added non-static function should have some sort of description unless it(function) is completely self-explanatory. Just a few words either here as a comment or in patch description, what the function supposed to do and which way, so that someone not familiar with cpm/cpm2, would quickly understand what's happening in there. -- Sincerely, Vitaly _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
