Re: [PATCH 2/6] mtd: m25p80: Convert to device table matching

2009-09-22 Thread Andrew Morton
On Wed, 23 Sep 2009 03:55:34 +0400 Anton Vorontsov wrote: > On Tue, Sep 22, 2009 at 04:43:47PM -0700, David Woodhouse wrote: > > On Wed, 2009-09-23 at 03:01 +0400, Anton Vorontsov wrote: > > > > > > And the two patches I sent on top: > > > > > > http://lkml.org/lkml/2009/8/18/364 > > > http://l

Re: [PATCH 2/6] mtd: m25p80: Convert to device table matching

2009-09-22 Thread Anton Vorontsov
On Tue, Sep 22, 2009 at 04:43:47PM -0700, David Woodhouse wrote: > On Wed, 2009-09-23 at 03:01 +0400, Anton Vorontsov wrote: > > > > And the two patches I sent on top: > > > > http://lkml.org/lkml/2009/8/18/364 > > http://lkml.org/lkml/2009/8/18/366 > > Got versions of those which apply to the m

Re: [PATCH 2/6] mtd: m25p80: Convert to device table matching

2009-09-22 Thread Andrew Morton
On Tue, 22 Sep 2009 16:43:47 -0700 David Woodhouse wrote: > On Wed, 2009-09-23 at 03:01 +0400, Anton Vorontsov wrote: > > > > And the two patches I sent on top: > > > > http://lkml.org/lkml/2009/8/18/364 > > http://lkml.org/lkml/2009/8/18/366 > > Got versions of those which apply to the mtd-2.

Re: [PATCH 2/6] mtd: m25p80: Convert to device table matching

2009-09-22 Thread David Woodhouse
On Wed, 2009-09-23 at 03:01 +0400, Anton Vorontsov wrote: > > And the two patches I sent on top: > > http://lkml.org/lkml/2009/8/18/364 > http://lkml.org/lkml/2009/8/18/366 Got versions of those which apply to the mtd-2.6.git tree (which I'm about to ask Linus to pull)? -- dwmw2

Re: [PATCH 2/6] mtd: m25p80: Convert to device table matching

2009-09-22 Thread Anton Vorontsov
On Tue, Sep 22, 2009 at 02:17:05PM -0700, Andrew Morton wrote: > On Mon, 3 Aug 2009 19:54:50 -0700 > David Brownell wrote: > > > On Thursday 30 July 2009, Anton Vorontsov wrote: > > > This patch converts the m25p80 driver so that now it uses .id_table > > > for device matching, making it properly

Re: [PATCH 2/6] mtd: m25p80: Convert to device table matching

2009-09-22 Thread Andrew Morton
On Mon, 3 Aug 2009 19:54:50 -0700 David Brownell wrote: > On Thursday 30 July 2009, Anton Vorontsov wrote: > > This patch converts the m25p80 driver so that now it uses .id_table > > for device matching, making it properly detect devices on OpenFirmware > > platforms (prior to this patch the driv

Re: [PATCH 2/6] mtd: m25p80: Convert to device table matching

2009-08-18 Thread Anton Vorontsov
Hi David, Thanks for the review, and sorry for the delayed response. On Mon, Aug 03, 2009 at 07:54:50PM -0700, David Brownell wrote: > On Thursday 30 July 2009, Anton Vorontsov wrote: > > This patch converts the m25p80 driver so that now it uses .id_table > > for device matching, making it proper

Re: [PATCH 2/6] mtd: m25p80: Convert to device table matching

2009-08-12 Thread Michael Barkowski
Anton Vorontsov wrote: > On Wed, Aug 12, 2009 at 04:45:55PM -0400, Michael Barkowski wrote: >> Hello Anton, >> >> Is m25p_probe now valid with dev.platform_data == NULL, for of platforms? >> >> Then shouldn't you have the following change as well, near the end of >> the function? >> >> -} else

Re: [PATCH 2/6] mtd: m25p80: Convert to device table matching

2009-08-12 Thread Anton Vorontsov
On Wed, Aug 12, 2009 at 04:45:55PM -0400, Michael Barkowski wrote: > Hello Anton, > > Is m25p_probe now valid with dev.platform_data == NULL, for of platforms? > > Then shouldn't you have the following change as well, near the end of > the function? > > - } else if (data->nr_parts) > + }

Re: [PATCH 2/6] mtd: m25p80: Convert to device table matching

2009-08-12 Thread Michael Barkowski
Hello Anton, Is m25p_probe now valid with dev.platform_data == NULL, for of platforms? Then shouldn't you have the following change as well, near the end of the function? - } else if (data->nr_parts) + } else if (data && data->nr_parts) dev_warn(&spi->dev, "ignoring %

Re: [PATCH 2/6] mtd: m25p80: Convert to device table matching

2009-08-04 Thread David Brownell
On Thursday 30 July 2009, Anton Vorontsov wrote: > This patch converts the m25p80 driver so that now it uses .id_table > for device matching, making it properly detect devices on OpenFirmware > platforms (prior to this patch the driver misdetected non-JEDEC chips, > seeing all chips as "m25p80").