On Tue, Sep 22, 2009 at 02:17:05PM -0700, Andrew Morton wrote: > On Mon, 3 Aug 2009 19:54:50 -0700 > David Brownell <davi...@pacbell.net> wrote: > > > On Thursday 30 July 2009, Anton Vorontsov wrote: > > > This patch converts the m25p80 driver so that now it uses .id_table > > > for device matching, making it properly detect devices on OpenFirmware > > > platforms (prior to this patch the driver misdetected non-JEDEC chips, > > > seeing all chips as "m25p80"). > > > > I suspect "detect" is a misnomer there. It only "detects" JEDEC chips. > > All others got explicit declarations ... so if there's misbehavior for > > other chips, it's because those declarations were poorly handled. Maybe > > they were not properly flagged as non-JDEC > > > > > > > Also, now jedec_probe() only does jedec probing, nothing else. If it > > > is not able to detect a chip, NULL is returned and the driver fall > > > backs to the information specified by the platform (platform_data, or > > > exact ID). > > > > I'd rather keep the warning, so there's a clue about what's really > > going on: JEDEC chip found, but its ID is not handled. > > > > afaik there was no response to David's review comments, so this patch > is in the "stuck" state.
Hm? Response: http://lkml.org/lkml/2009/8/18/363 And the two patches I sent on top: http://lkml.org/lkml/2009/8/18/364 http://lkml.org/lkml/2009/8/18/366 -- Anton Vorontsov email: cbouatmai...@gmail.com irc://irc.freenode.net/bd2 _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
