Re: [PATCH 2/6] ibm_newemac: Add ET1011c PHY support

2007-11-08 Thread Stefan Roese
On Thursday 08 November 2007, Benjamin Herrenschmidt wrote: > > DENX is pretty good about having Signed-off-by lines in their tree... > > maybe you should add the original authors as well if it's there. > > I picked it up from an already patched tree. Stefan, can you provide me > the proper SOB ?

Re: [PATCH 2/6] ibm_newemac: Add ET1011c PHY support

2007-11-08 Thread Benjamin Herrenschmidt
On Thu, 2007-11-08 at 06:08 -0600, Josh Boyer wrote: > > Agreed, I though I had removed them, looks like I didn't. Will fix > that > > before submitting. > > DENX is pretty good about having Signed-off-by lines in their tree... > maybe you should add the original authors as well if it's there. I

Re: [PATCH 2/6] ibm_newemac: Add ET1011c PHY support

2007-11-08 Thread Josh Boyer
On Thu, 08 Nov 2007 19:42:24 +1100 Benjamin Herrenschmidt <[EMAIL PROTECTED]> wrote: > > > > +static struct mii_phy_def et1011c_phy_def = { > > > +.phy_id = 0x0282f000, > > > +.phy_id_mask= 0x0f00, > > > +.name = "ET1011C Gigabit Ethernet", > > >

Re: [PATCH 2/6] ibm_newemac: Add ET1011c PHY support

2007-11-08 Thread Stefan Roese
On Thursday 08 November 2007, Benjamin Herrenschmidt wrote: > This adds support for the ET1011c PHY as found on the taishan > board. > > The code comes from the kernel distributed with the board by > AMCC and developped by DENX. > > Signed-off-by: Benjamin Herrenschmidt <[EMAIL PROTECTED]> > --- >

Re: [PATCH 2/6] ibm_newemac: Add ET1011c PHY support

2007-11-08 Thread Benjamin Herrenschmidt
> > +static struct mii_phy_def et1011c_phy_def = { > > +.phy_id = 0x0282f000, > > +.phy_id_mask= 0x0f00, > > +.name = "ET1011C Gigabit Ethernet", > > +.ops= &et1011c_phy_ops > > +}; > > + > > + > > + > > + > > + > > Nitpicking: