On Thu, 08 Nov 2007 19:42:24 +1100
Benjamin Herrenschmidt <[EMAIL PROTECTED]> wrote:
>
> > > +static struct mii_phy_def et1011c_phy_def = {
> > > + .phy_id = 0x0282f000,
> > > + .phy_id_mask = 0x0fffff00,
> > > + .name = "ET1011C Gigabit Ethernet",
> > > + .ops = &et1011c_phy_ops
> > > +};
> > > +
> > > +
> > > +
> > > +
> > > +
> >
> > Nitpicking: Too many empty lines for my taste.
>
> Agreed, I though I had removed them, looks like I didn't. Will fix that
> before submitting.
DENX is pretty good about having Signed-off-by lines in their tree...
maybe you should add the original authors as well if it's there.
josh
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
