Re: [PATCH 2/3] Convert PowerPC MPC i2c to of_platform_driver from platform_driver

2008-01-28 Thread Olof Johansson
Hi, Nice to see this one, I've been waiting for it. :) On Mon, Jan 28, 2008 at 09:42:07AM -0500, Jon Smirl wrote: > diff --git a/drivers/i2c/busses/powerpc-common.c > b/drivers/i2c/busses/powerpc-common.c > new file mode 100644 > index 000..51b039f > --- /dev/null > +++ b/drivers/i2c/busses

Re: [PATCH 2/3] Convert PowerPC MPC i2c to of_platform_driver from platform_driver

2008-01-23 Thread Jon Smirl
On 1/23/08, Jon Loeliger <[EMAIL PROTECTED]> wrote: > So, like, the other day Jon Smirl mumbled: > > Convert MPC i2c driver from a platform_driver to a > > of_platform_driver. Add the ability to dynamically load i2c drivers > > based on device tree names. Routine names were changed from fsl_ to > >

Re: [PATCH 2/3] Convert PowerPC MPC i2c to of_platform_driver from platform_driver

2008-01-23 Thread Jon Loeliger
So, like, the other day Jon Smirl mumbled: > Convert MPC i2c driver from a platform_driver to a > of_platform_driver. Add the ability to dynamically load i2c drivers > based on device tree names. Routine names were changed from fsl_ to > mpc_ to make them match the file name. Common code moved to >

Re: [PATCH 2/3] Convert PowerPC MPC i2c to of_platform_driver from platform_driver

2008-01-22 Thread Jon Smirl
On 1/22/08, Stephen Rothwell <[EMAIL PROTECTED]> wrote: > On Tue, 22 Jan 2008 21:09:14 -0500 Jon Smirl <[EMAIL PROTECTED]> wrote: > > > > +static struct of_device_id mpc_i2c_of_match[] = { > > (sfr winds up his broken record :-)) const, please. Fixed this > > > +#else > > + > > static int fsl_i

Re: [PATCH 2/3] Convert PowerPC MPC i2c to of_platform_driver from platform_driver

2008-01-22 Thread Stephen Rothwell
On Tue, 22 Jan 2008 21:09:14 -0500 Jon Smirl <[EMAIL PROTECTED]> wrote: > > +static struct of_device_id mpc_i2c_of_match[] = { (sfr winds up his broken record :-)) const, please. > +#else > + > static int fsl_i2c_probe(struct platform_device *pdev) While this code is still here, you should sti