Re: [PATCH 1/3] Add a new member name to structure irq_host

2007-07-31 Thread Segher Boessenkool
>>> In that case, I would display the node full path. >> >> Those tend to be quite long, in the cases where there are >> multiple interrupt controllers in the system; and really >> useless otherwise. I think the interrupt controllers should >> still just fill in the names "manually". > > They tend

Re: [PATCH 1/3] Add a new member name to structure irq_host

2007-07-31 Thread Michael Ellerman
On Wed, 2007-08-01 at 00:13 +0200, Segher Boessenkool wrote: > >>> Which makes me think (again) that we should have an optional > >>> device_node > >>> pointer in irq_host. I know you said you wanted the irq stuff to be > >>> OF > >>> agnostic, but the reality is most of the implementations do hav

Re: [PATCH 1/3] Add a new member name to structure irq_host

2007-07-31 Thread Segher Boessenkool
>>> Which makes me think (again) that we should have an optional >>> device_node >>> pointer in irq_host. I know you said you wanted the irq stuff to be >>> OF >>> agnostic, but the reality is most of the implementations do have an >>> OF >>> node. And all of the newer irq_host implementations do

Re: [PATCH 1/3] Add a new member name to structure irq_host

2007-07-31 Thread Benjamin Herrenschmidt
On Tue, 2007-07-31 at 21:42 +0200, Segher Boessenkool wrote: > > Which makes me think (again) that we should have an optional > > device_node > > pointer in irq_host. I know you said you wanted the irq stuff to be OF > > agnostic, but the reality is most of the implementations do have an OF > > no

Re: [PATCH 1/3] Add a new member name to structure irq_host

2007-07-31 Thread Segher Boessenkool
> Which makes me think (again) that we should have an optional > device_node > pointer in irq_host. I know you said you wanted the irq stuff to be OF > agnostic, but the reality is most of the implementations do have an OF > node. And all of the newer irq_host implementations do, with the > except

RE: [PATCH 1/3] Add a new member name to structure irq_host

2007-07-25 Thread Zhang Wei-r63237
Hi, Ben, Thanks! > Sure, hence the word 'optional' which would provide a default name. > About the default name, since platforms we touched are very limited, we do not know which name should be proper default name. We just assign those default name to 'NULL' for passing the compiling process.

RE: [PATCH 1/3] Add a new member name to structure irq_host

2007-07-24 Thread Benjamin Herrenschmidt
On Tue, 2007-07-24 at 17:25 +0800, Zhang Wei-r63237 wrote: > Hi, Ben, > > Thanks! Please see my inline comments. > > > > > Well, you would have to look at a cell blade or pSeries machine > > device-tree, I don't have one at hand in DTS form... but basically, > > those don't have a 1:1 relations

RE: [PATCH 1/3] Add a new member name to structure irq_host

2007-07-24 Thread Zhang Wei-r63237
Hi, Ben, Thanks! Please see my inline comments. > > Well, you would have to look at a cell blade or pSeries machine > device-tree, I don't have one at hand in DTS form... but basically, > those don't have a 1:1 relationship between hosts and nodes. Is there any problem when the relationship be

RE: [PATCH 1/3] Add a new member name to structure irq_host

2007-07-23 Thread Benjamin Herrenschmidt
On Tue, 2007-07-24 at 12:06 +0800, Chen Gong-B11801 wrote: > Can you give me a DTS example or code segment? I'm ambiguous about > what you said. Well, you would have to look at a cell blade or pSeries machine device-tree, I don't have one at hand in DTS form... but basically, those don't have a 1

RE: [PATCH 1/3] Add a new member name to structure irq_host

2007-07-23 Thread Chen Gong-B11801
rg; [EMAIL PROTECTED] > Subject: Re: [PATCH 1/3] Add a new member name to structure irq_host > > On Tue, 2007-07-24 at 09:22 +1000, Michael Ellerman wrote: > > On Tue, 2007-07-24 at 08:04 +1000, Benjamin Herrenschmidt wrote: > > > On Mon, 2007-07-23 at 19:13 +0800, Chen Gong

Re: [PATCH 1/3] Add a new member name to structure irq_host

2007-07-23 Thread Benjamin Herrenschmidt
On Tue, 2007-07-24 at 09:22 +1000, Michael Ellerman wrote: > On Tue, 2007-07-24 at 08:04 +1000, Benjamin Herrenschmidt wrote: > > On Mon, 2007-07-23 at 19:13 +0800, Chen Gong wrote: > > > This patch adds a new member 'name' for irq host's name to > > > structure irq_host and modifies the definition

Re: [PATCH 1/3] Add a new member name to structure irq_host

2007-07-23 Thread Michael Ellerman
On Tue, 2007-07-24 at 08:04 +1000, Benjamin Herrenschmidt wrote: > On Mon, 2007-07-23 at 19:13 +0800, Chen Gong wrote: > > This patch adds a new member 'name' for irq host's name to > > structure irq_host and modifies the definition of the > > function irq_alloc_host(). The assignment to the > > ir

Re: [PATCH 1/3] Add a new member name to structure irq_host

2007-07-23 Thread Benjamin Herrenschmidt
On Mon, 2007-07-23 at 19:13 +0800, Chen Gong wrote: > This patch adds a new member 'name' for irq host's name to > structure irq_host and modifies the definition of the > function irq_alloc_host(). The assignment to the > irq host's name is also added to irq_alloc_host(). I would instead prefer ad