On Wed, 2007-08-01 at 00:13 +0200, Segher Boessenkool wrote: > >>> Which makes me think (again) that we should have an optional > >>> device_node > >>> pointer in irq_host. I know you said you wanted the irq stuff to be > >>> OF > >>> agnostic, but the reality is most of the implementations do have an > >>> OF > >>> node. And all of the newer irq_host implementations do, with the > >>> exception of PS3 and celleb - which are special. > >> > >> How do you suggest to get a reasonable display name out of > >> the device tree? The recommended human-readable name for > >> interrupt controller nodes is "interrupt-controller"... > >> You cannot use "device_type" either, and using "compatible" > >> requires selecting one of its string entries, and likely > >> using a lookup table after that, too. > > > > In that case, I would display the node full path. > > Those tend to be quite long, in the cases where there are > multiple interrupt controllers in the system; and really > useless otherwise. I think the interrupt controllers should > still just fill in the names "manually".
They tend to be long, but they're unique, which is what you want, and they're only for debugging anyway. > It's a good thing to have an of_node in the irq_host struct > anyway, though :-) I posted patches for that last week. cheers -- Michael Ellerman OzLabs, IBM Australia Development Lab wwweb: http://michael.ellerman.id.au phone: +61 2 6212 1183 (tie line 70 21183) We do not inherit the earth from our ancestors, we borrow it from our children. - S.M.A.R.T Person
signature.asc
Description: This is a digitally signed message part
_______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
