Re: [PATCH] powerpc: Add MPC837x PCIE controller RC mode support

2008-01-03 Thread Li Li
On Thu, 2008-01-03 at 18:14 +0800, Arnd Bergmann wrote: > After some more research, I noticed that the distinction between > primary and secondary host bridges will go away _anyway_, so > I guess we shouldn't worry about it too much. > > On powerpc64, we already don't care, as the > arch/powerp

Re: [PATCH] powerpc: Add MPC837x PCIE controller RC mode support

2008-01-03 Thread Arnd Bergmann
On Thursday 03 January 2008, Li Li wrote: > > > It's easy enough to just panic() if you find more than one primary > > bus, > > since the information from the device tree is static enough that one > > will know how to fix this after seeing the error. > > > > It is just a case. what about if do

Re: [PATCH] powerpc: Add MPC837x PCIE controller RC mode support

2008-01-03 Thread Li Li
On Thu, 2008-01-03 at 16:14 +0800, Arnd Bergmann wrote: > On Thursday 03 January 2008, Li Li wrote: > > > * The detection method for the primary bus is somewhat fragile, > > > because > > > we depend on the order of the nodes in the device tree, which is > not > > > specified to have a meaning.

Re: [PATCH] powerpc: Add MPC837x PCIE controller RC mode support

2008-01-03 Thread Arnd Bergmann
On Thursday 03 January 2008, Li Li wrote: > > * The detection method for the primary bus is somewhat fragile, > > because > > we depend on the order of the nodes in the device tree, which is not > > specified to have a meaning. /Maybe/ there could be a property in > > (at most) one of the PCI ho

Re: [PATCH] powerpc: Add MPC837x PCIE controller RC mode support

2008-01-02 Thread Li Li
On Wed, 2008-01-02 at 19:53 +0800, Arnd Bergmann wrote: > On Wednesday 02 January 2008, Li Li wrote: > > #ifdef CONFIG_PCI > > - for_each_compatible_node(np, "pci", "fsl,mpc8349-pci") > > - mpc83xx_add_bridge(np); > > + for_each_compatible_node(np, "pci", "fsl,mpc8349

Re: [PATCH] powerpc: Add MPC837x PCIE controller RC mode support

2008-01-02 Thread Li Li
On Wed, 2008-01-02 at 23:23 +0800, Kumar Gala wrote: > > On Jan 2, 2008, at 5:16 AM, Li Li wrote: > > > * The MPC837x PCIE controller hardware resources and SerDes are > > initiated in u-boot. > > * Merge the MPC837x PCIE code into arch/powerpc/sysdev/fsl_pci.c > > * The MPC837x PCIE controll

Re: [PATCH] powerpc: Add MPC837x PCIE controller RC mode support

2008-01-02 Thread Olof Johansson
On Wed, Jan 02, 2008 at 07:16:45PM +0800, Li Li wrote: > diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h > index 1ee009e..f84caa7 100644 > --- a/include/linux/pci_ids.h > +++ b/include/linux/pci_ids.h > @@ -2111,6 +2111,10 @@ > #define PCI_DEVICE_ID_TDI_EHCI 0x0101 > > #

Re: [PATCH] powerpc: Add MPC837x PCIE controller RC mode support

2008-01-02 Thread Kumar Gala
On Jan 2, 2008, at 5:16 AM, Li Li wrote: > * The MPC837x PCIE controller hardware resources and SerDes are > initiated in u-boot. > * Merge the MPC837x PCIE code into arch/powerpc/sysdev/fsl_pci.c > * The MPC837x PCIE controller`s configure address bit field is uniqe: > bus number:

Re: [PATCH] powerpc: Add MPC837x PCIE controller RC mode support

2008-01-02 Thread Arnd Bergmann
On Wednesday 02 January 2008, Li Li wrote: >  #ifdef CONFIG_PCI > -   for_each_compatible_node(np, "pci", "fsl,mpc8349-pci") > -   mpc83xx_add_bridge(np); > +   for_each_compatible_node(np, "pci", "fsl,mpc8349-pci") { > +   if (primary_pci_bus) { > +