Re: [PATCH] powerpc/85xx: Add support for MPC8536DS

2008-07-02 Thread Chen Gong
Kumar Gala 写道: > > On Jul 2, 2008, at 9:04 AM, Chen Gong wrote: > >> Stephen Rothwell 写道: >>> Hi Kumar, >>> >>> On Wed, 2 Jul 2008 02:01:10 -0500 (CDT) Kumar Gala >>> <[EMAIL PROTECTED]> wrote: +void __init mpc8536_ds_pic_init(void) +{ +struct mpic *mpic; +struct reso

Re: [PATCH] powerpc/85xx: Add support for MPC8536DS

2008-07-02 Thread Kumar Gala
On Jul 2, 2008, at 9:04 AM, Chen Gong wrote: Stephen Rothwell 写道: Hi Kumar, On Wed, 2 Jul 2008 02:01:10 -0500 (CDT) Kumar Gala <[EMAIL PROTECTED] > wrote: +void __init mpc8536_ds_pic_init(void) +{ + struct mpic *mpic; + struct resource r; + struct device_node *np = NULL;

Re: [PATCH] powerpc/85xx: Add support for MPC8536DS

2008-07-02 Thread Chen Gong
Stephen Rothwell 写道: > Hi Kumar, > > On Wed, 2 Jul 2008 02:01:10 -0500 (CDT) Kumar Gala <[EMAIL PROTECTED]> wrote: >> +void __init mpc8536_ds_pic_init(void) >> +{ >> +struct mpic *mpic; >> +struct resource r; >> +struct device_node *np = NULL; > > You don't need to initialise this. >

Re: [PATCH] powerpc/85xx: Add support for MPC8536DS

2008-07-02 Thread Stephen Rothwell
Hi Kumar, On Wed, 2 Jul 2008 02:01:10 -0500 (CDT) Kumar Gala <[EMAIL PROTECTED]> wrote: > > +void __init mpc8536_ds_pic_init(void) > +{ > + struct mpic *mpic; > + struct resource r; > + struct device_node *np = NULL; You don't need to initialise this. > + np = of_find_node_by_typ