Hi Kumar,
On Wed, 2 Jul 2008 02:01:10 -0500 (CDT) Kumar Gala <[EMAIL PROTECTED]> wrote:
>
> +void __init mpc8536_ds_pic_init(void)
> +{
> + struct mpic *mpic;
> + struct resource r;
> + struct device_node *np = NULL;
You don't need to initialise this.
> + np = of_find_node_by_type(np, "open-pic");
> +
Extra blank line.
> + if (np == NULL) {
> + printk(KERN_ERR "Could not find open-pic node\n");
> + return;
> + }
> +
> + if (of_address_to_resource(np, 0, &r)) {
> + printk(KERN_ERR "Failed to map mpic register space\n");
> + of_node_put(np);
> + return;
> + }
> +
> + mpic = mpic_alloc(np, r.start,
> + MPIC_PRIMARY | MPIC_WANTS_RESET |
> + MPIC_BIG_ENDIAN | MPIC_BROKEN_FRR_NIRQS,
> + 0, 256, " OpenPIC ");
> + BUG_ON(mpic == NULL);
> +
> + mpic_init(mpic);
You leak a reference to np here.
> +static struct of_device_id mpc8536_ds_ids[] = {
__initdata, please.
--
Cheers,
Stephen Rothwell [EMAIL PROTECTED]
http://www.canb.auug.org.au/~sfr/
pgpcmF8wjzPib.pgp
Description: PGP signature
_______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
