Re: [PATCH] ndfc driver

2008-12-17 Thread Josh Boyer
On Wed, Dec 10, 2008 at 06:16:34PM -0500, Sean MacLennan wrote: >Here is an updated patch. Doc has been moved to 4xx and amcc changed to >ibm. > >Arnd: I removed your acked-by just in case you don't approve of the new >flash layout. Feel free to ack again. > >Cheers, > Sean > >Port of the ndfc dr

Re: [PATCH] ndfc driver

2008-12-17 Thread Josh Boyer
On Tue, Dec 16, 2008 at 11:14:00PM -0500, Sean MacLennan wrote: >On Wed, 10 Dec 2008 18:16:34 -0500 >"Sean MacLennan" wrote: > >> Here is an updated patch. Doc has been moved to 4xx and amcc changed >> to ibm. > >Anybody? Even if it is not perfect, it would be better to have >a driver that at leas

Re: [PATCH] ndfc driver

2008-12-16 Thread Sean MacLennan
On Wed, 10 Dec 2008 18:16:34 -0500 "Sean MacLennan" wrote: > Here is an updated patch. Doc has been moved to 4xx and amcc changed > to ibm. Anybody? Even if it is not perfect, it would be better to have a driver that at least compiles ;) Cheers, Sean _

Re: [PATCH] ndfc driver

2008-12-10 Thread Sean MacLennan
Here is an updated patch. Doc has been moved to 4xx and amcc changed to ibm. Arnd: I removed your acked-by just in case you don't approve of the new flash layout. Feel free to ack again. Cheers, Sean Port of the ndfc driver to an OF platform driver. Signed-off-by: Sean MacLennan <[EMAIL PROT

Re: [PATCH] ndfc driver

2008-12-10 Thread Mitch Bradley
n Mon, 08 Dec 2008 21:57:12 -1000 "Mitch Bradley" <[EMAIL PROTECTED]> wrote: > One address/size cell isn't enough for the next generation of NAND > FLASH chips. > I am no dts expert, but I thought I could put: nand { #address-cells = <1>; #siz

Re: [PATCH] ndfc driver

2008-12-09 Thread Sean MacLennan
On Mon, 08 Dec 2008 21:57:12 -1000 "Mitch Bradley" <[EMAIL PROTECTED]> wrote: > One address/size cell isn't enough for the next generation of NAND > FLASH chips. > I am no dts expert, but I thought I could put: nand { #address-cells = <1>; #size-cells = <

Re: [PATCH] ndfc driver

2008-12-09 Thread Josh Boyer
On Tue, 9 Dec 2008 07:10:27 +0100 Stefan Roese <[EMAIL PROTECTED]> wrote: > On Tuesday 09 December 2008, Sean MacLennan wrote: > > On Thu, 4 Dec 2008 09:01:07 -0500 > > > > "Josh Boyer" <[EMAIL PROTECTED]> wrote: > > > In addition to an example DTS patch (probably to warp itself), could > > > you

Re: [PATCH] ndfc driver

2008-12-09 Thread Mitch Bradley
One address/size cell isn't enough for the next generation of NAND FLASH chips. ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH] ndfc driver

2008-12-08 Thread Stefan Roese
On Tuesday 09 December 2008, Sean MacLennan wrote: > On Thu, 4 Dec 2008 09:01:07 -0500 > > "Josh Boyer" <[EMAIL PROTECTED]> wrote: > > In addition to an example DTS patch (probably to warp itself), could > > you briefly write up a binding and put it in > > Documentation/powerpc/dts-bindings/amcc (o

Re: [PATCH] ndfc driver

2008-12-08 Thread Sean MacLennan
On Mon, 8 Dec 2008 22:32:27 -0500 "Josh Boyer" <[EMAIL PROTECTED]> wrote: > Except there is no controller in front of the NOR. It's all just > MMIOs. With NDFC, there is a controller, you have to do things to it > to talk to different chips, etc. Ok, I have the following dts working... would th

Re: [PATCH] ndfc driver

2008-12-08 Thread Josh Boyer
On Mon, 8 Dec 2008 21:45:12 -0500 Sean MacLennan <[EMAIL PROTECTED]> wrote: > On Tue, 9 Dec 2008 05:11:15 +0300 > "Anton Vorontsov" <[EMAIL PROTECTED]> wrote: > > > So this is a controller with partitions? ;-) > > Actually, I did it this way to mimic the look of the NOR. Really, we > shouldn't c

Re: [PATCH] ndfc driver

2008-12-08 Thread Sean MacLennan
On Tue, 9 Dec 2008 05:11:15 +0300 "Anton Vorontsov" <[EMAIL PROTECTED]> wrote: > So this is a controller with partitions? ;-) Actually, I did it this way to mimic the look of the NOR. Really, we shouldn't care about the NAND chip. Here is the complete NOR and NAND DTS: [EMAIL PROTECTED],0 {

Re: [PATCH] ndfc driver

2008-12-08 Thread Anton Vorontsov
Hi Sean, On Mon, Dec 08, 2008 at 07:34:46PM -0500, Sean MacLennan wrote: > On Thu, 4 Dec 2008 09:01:07 -0500 > "Josh Boyer" <[EMAIL PROTECTED]> wrote: > > > In addition to an example DTS patch (probably to warp itself), could > > you briefly write up a binding and put it in > > Documentation/powe

Re: [PATCH] ndfc driver

2008-12-08 Thread Sean MacLennan
On Thu, 4 Dec 2008 09:01:07 -0500 "Josh Boyer" <[EMAIL PROTECTED]> wrote: > You also seem to only support a single NAND chip, however the NDFC can > support multiple chips. Have you looked at how the the fsl_elbc_nand > driver does multiple chip support? If not, could you at least > document the

Re: [PATCH] ndfc driver

2008-12-08 Thread Sean MacLennan
On Thu, 4 Dec 2008 09:01:07 -0500 "Josh Boyer" <[EMAIL PROTECTED]> wrote: > In addition to an example DTS patch (probably to warp itself), could > you briefly write up a binding and put it in > Documentation/powerpc/dts-bindings/amcc (or similar)? Also please CC > the devicetree-discuss list on t

Re: [PATCH] ndfc driver

2008-12-04 Thread Sean MacLennan
On Thu, 4 Dec 2008 09:01:07 -0500 "Josh Boyer" <[EMAIL PROTECTED]> wrote: > On Wed, 3 Dec 2008 22:28:32 -0500 > Sean MacLennan <[EMAIL PROTECTED]> wrote: > > Hi Sean, > > A couple of comments/requests below. > > In addition to an example DTS patch (probably to warp itself), could > you briefly

Re: [PATCH] ndfc driver

2008-12-04 Thread Josh Boyer
On Wed, 3 Dec 2008 22:28:32 -0500 Sean MacLennan <[EMAIL PROTECTED]> wrote: Hi Sean, A couple of comments/requests below. > The current ndfc driver only compiles under arch/ppc. This arch was > removed from the kernel. I notice the event entry for the ndfc in > Kconfig has been removed in 2.6.28

Re: [PATCH] ndfc driver

2008-11-03 Thread Felix Radensky
Hi, I can confirm that this driver works fine on custom 4060EX board. The NAND is 256MiB Samsumg, with 2K page size. I had to modify U-boot to provide EBC "ranges" property for NAND, but otherwise it worked from the beginning. I didn't see any reaction to Sean's post, but this driver is importan