Re: [PATCH] ibm_newemac: Fixes memory leak in ibm_newemac ethernet driver

2008-07-01 Thread SathyaNarayanan
On Wed, Jul 2, 2008 at 11:16 AM, Benjamin Herrenschmidt < [EMAIL PROTECTED]> wrote: > > > > > Actually the meachanism of stopping the queue and starting it is > > already there. But even then due to some sync issue between the poll > > routine and xmit, we were resulted in using the slots of skb

Re: [PATCH] ibm_newemac: Fixes memory leak in ibm_newemac ethernet driver

2008-07-01 Thread Benjamin Herrenschmidt
> > Actually the meachanism of stopping the queue and starting it is > already there. But even then due to some sync issue between the poll > routine and xmit, we were resulted in using the slots of skb which was > not actually got freed before. > I agree this could a bug , Since its not is not

Re: [PATCH] ibm_newemac: Fixes memory leak in ibm_newemac ethernet driver

2008-07-01 Thread SathyaNarayanan
Hi Benn, Please find my comments below. On Tue, Jun 24, 2008 at 4:51 AM, Benjamin Herrenschmidt < [EMAIL PROTECTED]> wrote: > On Mon, 2008-06-23 at 14:55 +0200, Stefan Roese wrote: > > From: Sathya Narayanan <[EMAIL PROTECTED]> > > > > This patch addresses the memory leak happenni

Re: [PATCH] ibm_newemac: Fixes memory leak in ibm_newemac ethernet driver

2008-06-23 Thread Benjamin Herrenschmidt
On Mon, 2008-06-23 at 14:55 +0200, Stefan Roese wrote: > From: Sathya Narayanan <[EMAIL PROTECTED]> > > This patch addresses the memory leak happenning in drivers transmit queue > under heavy load condition. Once the transmit queue becomes full, driver > does an automatic wrapup of queue. During w