On Mon, 2008-06-23 at 14:55 +0200, Stefan Roese wrote:
> From: Sathya Narayanan <[EMAIL PROTECTED]>
>
> This patch addresses the memory leak happenning in drivers transmit queue
> under heavy load condition. Once the transmit queue becomes full, driver
> does an automatic wrapup of queue. During which the untransmitted SKB's are
> lost without getting freed up.
This would be a bug. We should stop the queue when full instead.
> Signed-off-by: Sathya Narayanan <[EMAIL PROTECTED]>
> Signed-off-by: Stefan Roese <[EMAIL PROTECTED]>
> ---
> drivers/net/ibm_newemac/core.c | 7 +++++++
> 1 files changed, 7 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/ibm_newemac/core.c b/drivers/net/ibm_newemac/core.c
> index aa407b2..ee868b6 100644
> --- a/drivers/net/ibm_newemac/core.c
> +++ b/drivers/net/ibm_newemac/core.c
> @@ -1328,6 +1328,13 @@ static int emac_start_xmit(struct sk_buff *skb, struct
> net_device *ndev)
>
> DBG2(dev, "xmit(%u) %d" NL, len, slot);
>
> + if (dev->tx_skb[slot] && dev->tx_desc[slot].data_ptr) {
> + dev_kfree_skb(dev->tx_skb[slot]);
> + dev->tx_skb[slot] = NULL;
> + dev->tx_cnt--;
> + ++dev->estats.tx_dropped;
> + }
> +
> dev->tx_skb[slot] = skb;
> dev->tx_desc[slot].data_ptr = dma_map_single(&dev->ofdev->dev,
> skb->data, len,
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
