Re: [PATCH V2] tools/perf/builtin-lock: Fix return code for functions in __cmd_contention

2025-01-18 Thread Namhyung Kim
On Fri, 10 Jan 2025 15:07:30 +0530, Athira Rajeev wrote: > perf lock contention returns zero exit value even if the lock contention > BPF setup failed. > > # ./perf lock con -b true > libbpf: kernel BTF is missing at '/sys/kernel/btf/vmlinux', was > CONFIG_DEBUG_INFO_BTF enabled? > libbpf:

Re: [RESEND PATCH] powerpc/kprobes: don't save r13 register in kprobe context

2025-01-17 Thread pangliyuan
On Sat, Jan 18, 2025 at 15:40:01PM +0800, pangliyuan wrote: > Le 16/01/2025 à 09:45, pangliyuan a écrit : >> [Vous ne recevez pas souvent de courriers de pangliyu...@huawei.com. >> Découvrez pourquoi ceci est important à >> https://aka.ms/LearnAboutSenderIdentification ] >> >> When CONFIG_STACKP

Re: [PATCH v2 3/7] syscall.h: add syscall_set_arguments() and syscall_set_return_value()

2025-01-17 Thread H. Peter Anvin
On January 17, 2025 7:45:02 AM PST, Eugene Syromyatnikov wrote: >On Fri, Jan 17, 2025 at 2:03 AM H. Peter Anvin wrote: >> >> I link the concept of this patchset, but *please* make it clear in the >> comments that this does not solve the issue of 64-bit kernel arguments >> on 32-bit systems being

Re: [PATCH v2 3/7] syscall.h: add syscall_set_arguments() and syscall_set_return_value()

2025-01-17 Thread Eugene Syromyatnikov
On Fri, Jan 17, 2025 at 2:03 AM H. Peter Anvin wrote: > > I link the concept of this patchset, but *please* make it clear in the > comments that this does not solve the issue of 64-bit kernel arguments > on 32-bit systems being ABI specific. Sorry, but I don't see how this is relevant; each archi

Re: [PATCH 1/2] arch/powerpc/perf: Check the instruction type before creating sample with perf_mem_data_src

2025-01-17 Thread kernel test robot
Hi Athira, kernel test robot noticed the following build errors: [auto build test ERROR on powerpc/next] [also build test ERROR on powerpc/fixes linus/master v6.13-rc7 next-20250117] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to u

Re: [PATCH v13 5/5] rust: Use gendwarfksyms + extended modversions for CONFIG_MODVERSIONS

2025-01-17 Thread Masahiro Yamada
On Wed, Jan 15, 2025 at 3:58 AM Sami Tolvanen wrote: > > On Tue, Jan 14, 2025 at 10:22:15AM +0900, Masahiro Yamada wrote: > > On Tue, Jan 14, 2025 at 5:04 AM Sami Tolvanen > > wrote: > > > > > > Hi Masahiro, > > > > > > On Fri, Jan 10, 2025 at 6:26 PM Masahiro Yamada > > > wrote: > > > > > > >

Re: [PATCH] powerpc/prom_init: Fixup missing #size-cells on PowerBook6,7

2025-01-17 Thread Rob Herring
On Mon, Jan 13, 2025 at 11:19 AM Andreas Schwab wrote: > > Similar to the PowerMac3,1, the PowerBook6,7 is missing the #size-cells > property on the i2s node. > > Depends-on: 045b14ca5c36 ("of: WARN on deprecated #address-cells/#size-cells > handling") > Signed-off-by: Andreas Schwab > --- > ar

Re: [PATCH v2] cpufreq: Use str_enable_disable-like helpers

2025-01-17 Thread Rafael J. Wysocki
On Wed, Jan 15, 2025 at 8:12 AM Viresh Kumar wrote: > > On 14-01-25, 20:06, Krzysztof Kozlowski wrote: > > Replace ternary (condition ? "enable" : "disable") syntax with helpers > > from string_choices.h because: > > 1. Simple function call with one argument is easier to read. Ternary > >oper

Re: [PATCH v2 5/6] powerpc/book3s-hv-pmu: Implement GSB message-ops for hostwide counters

2025-01-17 Thread Gautam Menghani
On Wed, Jan 15, 2025 at 08:09:46PM +0530, Vaibhav Jain wrote: > Implement and setup necessary structures to send a prepolulated > Guest-State-Buffer(GSB) requesting hostwide counters to L0-PowerVM and have > the returned GSB holding the values of these counters parsed. This is done > via existing G

Re: [PATCH v2 4/6] kvm powerpc/book3s-apiv2: Introduce kvm-hv specific PMU

2025-01-17 Thread Gautam Menghani
On Wed, Jan 15, 2025 at 08:09:45PM +0530, Vaibhav Jain wrote: > Introduce a new PMU named 'kvm-hv' to report Book3s kvm-hv specific > performance counters. This will expose KVM-HV specific performance > attributes to user-space via kernel's PMU infrastructure and would enable > users to monitor act

Re: [PATCH v2 4/6] kvm powerpc/book3s-apiv2: Introduce kvm-hv specific PMU

2025-01-17 Thread Vaibhav Jain
Thanks for catching this build warning kernel-test-robot. I will spin-off a v3 fixing this. kernel test robot writes: > Hi Vaibhav, > > kernel test robot noticed the following build warnings: > > [auto build test WARNING on powerpc/topic/ppc-kvm] > [also build test WARNING on powerpc/next powe

Re: [PATCH v2 1/6] powerpc: Document APIv2 KVM hcall spec for Hostwide counters

2025-01-17 Thread Gautam Menghani
On Wed, Jan 15, 2025 at 08:09:42PM +0530, Vaibhav Jain wrote: > Update kvm-nested APIv2 documentation to include five new > Guest-State-Elements to fetch the hostwide counters. These counters are > per L1-Lpar and indicate the amount of Heap/Page-table memory allocated, > available and Page-table m

Re: [PATCH v5 05/17] arm64: pgtable: use mmu gather to free p4d level page table

2025-01-17 Thread Will Deacon
On Tue, Jan 14, 2025 at 10:26:54AM +0800, Qi Zheng wrote: > Hi Will, > > On 2025/1/14 00:26, Will Deacon wrote: > > On Wed, Jan 08, 2025 at 02:57:21PM +0800, Qi Zheng wrote: > > > Like other levels of page tables, also use mmu gather mechanism to free > > > p4d level page table. > > > > > > Signe

Re: [PATCH v3 1/2] powerpc/fadump: allocate memory for additional parameters early

2025-01-17 Thread Christophe Leroy
Le 17/01/2025 à 13:32, Sourabh Jain a écrit : Hello Christophe, On 17/01/25 17:43, Christophe Leroy wrote: Le 13/11/2024 à 08:06, Sourabh Jain a écrit : From: Hari Bathini Memory for passing additional parameters to fadump capture kernel is allocated during subsys_initcall level, using

Re: [PATCH] selftests: livepatch: handle PRINTK_CALLER in check_result()

2025-01-17 Thread Miroslav Benes
Hi, On Thu, 16 Jan 2025, Petr Mladek wrote: > On Thu 2025-01-16 08:10:44, Joe Lawrence wrote: > > On 1/16/25 04:29, Petr Mladek wrote: > > > On Tue 2025-01-14 20:01:44, Madhavan Srinivasan wrote: > > >> Some arch configs (like ppc64) enable CONFIG_PRINTK_CALLER, which > > >> adds the caller id as

Re: [PATCH] of: address: Unify resource bounds overflow checking

2025-01-17 Thread Thomas Weißschuh
On Fri, Jan 17, 2025 at 12:23:53PM +0530, Basharath Hussain Khaja wrote: > >> >> Thomas Weißschuh writes: > >> >> > The members "start" and "end" of struct resource are of type > >> >> > "resource_size_t" which can be 32bit wide. > >> >> > Values read from OF however are always 64bit wide. > >> >>

Re: [PATCH v3 1/2] powerpc/fadump: allocate memory for additional parameters early

2025-01-17 Thread Sourabh Jain
Hello Christophe, On 17/01/25 17:43, Christophe Leroy wrote: Le 13/11/2024 à 08:06, Sourabh Jain a écrit : From: Hari Bathini Memory for passing additional parameters to fadump capture kernel is allocated during subsys_initcall level, using memblock. But as slab is already available by this

Re: [PATCH v3 1/2] powerpc/fadump: allocate memory for additional parameters early

2025-01-17 Thread Christophe Leroy
Le 13/11/2024 à 08:06, Sourabh Jain a écrit : From: Hari Bathini Memory for passing additional parameters to fadump capture kernel is allocated during subsys_initcall level, using memblock. But as slab is already available by this time, allocation happens via the buddy allocator. This may wo

Re: [PATCH RFC v2 16/29] mm: asi: Map kernel text and static data as nonsensitive

2025-01-17 Thread Brendan Jackman
On Fri, 10 Jan 2025 at 19:41, Brendan Jackman wrote: > + asi_clone_pgd(asi_global_nonsensitive_pgd, init_mm.pgd, > VMEMMAP_START); > + asi_clone_pgd(asi_global_nonsensitive_pgd, init_mm.pgd, > + VMEMMAP_START + (1UL << PGDIR_SHIFT)); There's a bug here that Yosry

Re: [PATCH] of: address: Unify resource bounds overflow checking

2025-01-16 Thread Basharath Hussain Khaja
>> >> Thomas Weißschuh writes: >> >> > The members "start" and "end" of struct resource are of type >> >> > "resource_size_t" which can be 32bit wide. >> >> > Values read from OF however are always 64bit wide. >> >> > >> >> > Refactor the diff overflow checks into a helper function. >> >> > Also

Re: [PATCH v2 4/6] kvm powerpc/book3s-apiv2: Introduce kvm-hv specific PMU

2025-01-16 Thread kernel test robot
Hi Vaibhav, kernel test robot noticed the following build warnings: [auto build test WARNING on powerpc/topic/ppc-kvm] [also build test WARNING on powerpc/next powerpc/fixes kvm/queue kvm/next mst-vhost/linux-next linus/master v6.13-rc7 next-20250116] [cannot apply to kvm/linux-next] [If your pa

Re: [PATCH v6 20/26] mm/mlock: Skip ZONE_DEVICE PMDs during mlock

2025-01-16 Thread Alistair Popple
On Mon, Jan 13, 2025 at 06:42:46PM -0800, Dan Williams wrote: > Alistair Popple wrote: > > At present mlock skips ptes mapping ZONE_DEVICE pages. A future change > > to remove pmd_devmap will allow pmd_trans_huge_lock() to return > > ZONE_DEVICE folios so make sure we continue to skip those. > > >

Re: [PATCH v6 19/26] proc/task_mmu: Mark devdax and fsdax pages as always unpinned

2025-01-16 Thread Alistair Popple
On Tue, Jan 14, 2025 at 05:45:46PM +0100, David Hildenbrand wrote: > On 14.01.25 03:28, Dan Williams wrote: > > Alistair Popple wrote: > > > The procfs mmu files such as smaps and pagemap currently ignore devdax and > > > fsdax pages because these pages are considered special. A future change > > >

Re: [PATCH v2 3/7] syscall.h: add syscall_set_arguments() and syscall_set_return_value()

2025-01-16 Thread H. Peter Anvin
I link the concept of this patchset, but *please* make it clear in the comments that this does not solve the issue of 64-bit kernel arguments on 32-bit systems being ABI specific. This isn't unique to this patch in any way; the only way to handle it is by keeping track of each ABI. On 1/15/2

Re: [PATCH v6 11/26] mm: Allow compound zone device pages

2025-01-16 Thread Alistair Popple
On Tue, Jan 14, 2025 at 03:59:31PM +0100, David Hildenbrand wrote: > On 10.01.25 07:00, Alistair Popple wrote: > > Zone device pages are used to represent various type of device memory > > managed by device drivers. Currently compound zone device pages are > > not supported. This is because MEMORY_

Re: [PATCH v6 08/26] fs/dax: Remove PAGE_MAPPING_DAX_SHARED mapping flag

2025-01-16 Thread Alistair Popple
On Tue, Jan 14, 2025 at 09:44:38PM -0800, Dan Williams wrote: > Alistair Popple wrote: > [..] > > > How does this case happen? I don't think any page would ever enter with > > > both ->mapping and ->share set, right? > > > > Sigh. You're right - it can't. This patch series is getting a litte bit

Re: [PATCH RFC v2 02/29] x86: Create CONFIG_MITIGATION_ADDRESS_SPACE_ISOLATION

2025-01-16 Thread Borislav Petkov
On Fri, Jan 10, 2025 at 06:40:28PM +, Brendan Jackman wrote: > diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig > index > 7b9a7e8f39acc8e9aeb7d4213e87d71047865f5c..5a50582eb210e9d1309856a737d32b76fa1bfc85 > 100644 > --- a/arch/x86/Kconfig > +++ b/arch/x86/Kconfig > @@ -2519,6 +2519,20 @@ conf

Re: [PATCH v2 23/25] EDAC/cell: Remove powerpc Cell driver

2025-01-16 Thread Borislav Petkov
On Wed, Dec 18, 2024 at 09:55:11PM +1100, Michael Ellerman wrote: > This driver can no longer be built since support for IBM Cell Blades was > removed, in particular PPC_CELL_COMMON. > > Remove the driver. > > Signed-off-by: Michael Ellerman > --- > v2: Rebase. > > Cc: linux-e...@vger.kernel.or

Re: [PATCH] selftests: livepatch: handle PRINTK_CALLER in check_result()

2025-01-16 Thread Petr Mladek
On Thu 2025-01-16 08:10:44, Joe Lawrence wrote: > On 1/16/25 04:29, Petr Mladek wrote: > > On Tue 2025-01-14 20:01:44, Madhavan Srinivasan wrote: > >> Some arch configs (like ppc64) enable CONFIG_PRINTK_CALLER, which > >> adds the caller id as part of the dmesg. Due to this, even though > >> the ex

Re: [PATCH RFC v2 01/29] mm: asi: Make some utility functions noinstr compatible

2025-01-16 Thread Borislav Petkov
ch > applied on top of tip/master (37bc915c6ad0f). Yeah, it feels like toolchain-related but I can't put my finger on it yet. We'll see if and when this thing will re-surface its ugly head... :-) Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette

Re: [PATCH RFC v2 01/29] mm: asi: Make some utility functions noinstr compatible

2025-01-16 Thread Brendan Jackman
On Thu, 16 Jan 2025 at 01:21, Borislav Petkov wrote: > > Unfortunately Thomas pointed out this will prevent the function from > > being inlined at call sites in .text. > > > > So far I haven't been able[1] to find a formulation that lets us : > > 1. avoid calls from .noinstr.text -> .text, > > 2.

Re: [PATCH] selftests: livepatch: handle PRINTK_CALLER in check_result()

2025-01-16 Thread Joe Lawrence
On 1/16/25 04:29, Petr Mladek wrote: > On Tue 2025-01-14 20:01:44, Madhavan Srinivasan wrote: >> Some arch configs (like ppc64) enable CONFIG_PRINTK_CALLER, which >> adds the caller id as part of the dmesg. Due to this, even though >> the expected vs observed are same, end testcase results are fail

Re: [PATCH RFC v2 01/29] mm: asi: Make some utility functions noinstr compatible

2025-01-16 Thread Borislav Petkov
On Thu, Jan 16, 2025 at 01:18:58AM +0100, Borislav Petkov wrote: > Long story short, lemme try to poke around tomorrow to try to figure out what > actually happens. It could be caused by the part of Rik's patches and this one > inlining things. We'll see... Looks transient... The very similar gues

Re: [RESEND PATCH] powerpc/kprobes: don't save r13 register in kprobe context

2025-01-16 Thread Christophe Leroy
Le 16/01/2025 à 09:45, pangliyuan a écrit : [Vous ne recevez pas souvent de courriers de pangliyu...@huawei.com. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ] When CONFIG_STACKPROTECTOR_STRONG is enabled and FTRACE is disabled on powerpc64, repeatedl

Re: [PATCH v5 00/15] powerpc/objtool: uaccess validation for PPC32 (v5)

2025-01-16 Thread Peter Zijlstra
On Wed, Jan 15, 2025 at 11:42:40PM +0100, Christophe Leroy wrote: > Christophe Leroy (15): > objtool: Fix generic annotation infrastructure cross build > objtool: Move back misplaced comment > objtool: Allow an architecture to disable objtool on ASM files > objtool: Fix JUMP_ENTRY_SIZE for

Re: [PATCH] selftests: livepatch: handle PRINTK_CALLER in check_result()

2025-01-16 Thread Petr Mladek
On Tue 2025-01-14 20:01:44, Madhavan Srinivasan wrote: > Some arch configs (like ppc64) enable CONFIG_PRINTK_CALLER, which > adds the caller id as part of the dmesg. Due to this, even though > the expected vs observed are same, end testcase results are failed. CONFIG_PRINTK_CALLER is not the only

Re: [PATCH v5 12/15] objtool: Add support for more complex UACCESS control

2025-01-16 Thread Peter Zijlstra
On Wed, Jan 15, 2025 at 11:42:52PM +0100, Christophe Leroy wrote: > diff --git a/tools/objtool/check.c b/tools/objtool/check.c > index 91436f4b3622..54625f09d831 100644 > --- a/tools/objtool/check.c > +++ b/tools/objtool/check.c > @@ -2422,6 +2422,14 @@ static int __annotate_late(struct objtool_fi

Re: [PATCH v5 00/15] powerpc/objtool: uaccess validation for PPC32 (v5)

2025-01-15 Thread Christophe Leroy
Le 15/01/2025 à 23:42, Christophe Leroy a écrit : This series adds UACCESS validation for PPC32. It includes a dozen of changes to objtool core. It applies on top of series "Cleanup/Optimise KUAP (v3)" https://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=363368&state=* I forgot to

RE: [PATCH v2 net-next 07/13] net: enetc: add RSS support for i.MX95 ENETC PF

2025-01-15 Thread Wei Fang
vger.kernel.org; > linux-ker...@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; > linux-arm-ker...@lists.infradead.org; i...@lists.linux.dev > Subject: Re: [PATCH v2 net-next 07/13] net: enetc: add RSS support for i.MX95 > ENETC PF > > On Thu, 16 Jan 2025 02:24:10 + Wei

Re: [PATCH] selftests: livepatch: handle PRINTK_CALLER in check_result()

2025-01-15 Thread Madhavan Srinivasan
On 1/15/25 11:40 PM, Joe Lawrence wrote: > On Tue, Jan 14, 2025 at 08:01:44PM +0530, Madhavan Srinivasan wrote: >> Some arch configs (like ppc64) enable CONFIG_PRINTK_CALLER, which >> adds the caller id as part of the dmesg. Due to this, even though >> the expected vs observed are same, end test

Re: [PATCH v2 net-next 07/13] net: enetc: add RSS support for i.MX95 ENETC PF

2025-01-15 Thread Jakub Kicinski
On Thu, 16 Jan 2025 02:24:10 + Wei Fang wrote: > > Why create full ops for something this trivial? > > We add enetc_pf_hw_ops to implement different hardware ops > for different chips. So that they can be called in common functions. > Although the change is minor, it is consistent with the o

RE: [PATCH v2 net-next 07/13] net: enetc: add RSS support for i.MX95 ENETC PF

2025-01-15 Thread Wei Fang
> On Mon, 13 Jan 2025 16:22:39 +0800 Wei Fang wrote: > > Add Receive side scaling (RSS) support for i.MX95 ENETC PF to improve the > > network performance and balance the CPU loading. In addition, since both > > ENETC v1 and ENETC v4 only support the toeplitz algorithm, so a check for > > hfunc was

Re: [PATCH v2 4/7] syscall.h: introduce syscall_set_nr()

2025-01-15 Thread Charlie Jenkins
On Mon, Jan 13, 2025 at 07:11:51PM +0200, Dmitry V. Levin wrote: > Similar to syscall_set_arguments() that complements > syscall_get_arguments(), introduce syscall_set_nr() > that complements syscall_get_nr(). > > syscall_set_nr() is going to be needed along with > syscall_set_arguments() on all H

Re: [PATCH v2 3/7] syscall.h: add syscall_set_arguments() and syscall_set_return_value()

2025-01-15 Thread Charlie Jenkins
On Mon, Jan 13, 2025 at 07:11:40PM +0200, Dmitry V. Levin wrote: > These functions are going to be needed on all HAVE_ARCH_TRACEHOOK > architectures to implement PTRACE_SET_SYSCALL_INFO API. > > This partially reverts commit 7962c2eddbfe ("arch: remove unused > function syscall_set_arguments()") b

Re: [PATCH RFC v2 01/29] mm: asi: Make some utility functions noinstr compatible

2025-01-15 Thread Borislav Petkov
On Fri, Jan 10, 2025 at 06:40:27PM +, Brendan Jackman wrote: > Subject: Re: [PATCH RFC v2 01/29] mm: asi: Make some utility functions > noinstr compatible The tip tree preferred format for patch subject prefixes is 'subsys/component:', e.g. 'x86/apic:', &#

Re: [PATCH 1/2] PCI: dwc: dra7xx: Use syscon_regmap_lookup_by_phandle_args

2025-01-15 Thread Bjorn Helgaas
On Sun, Jan 12, 2025 at 02:39:02PM +0100, Krzysztof Kozlowski wrote: > Use syscon_regmap_lookup_by_phandle_args() which is a wrapper over > syscon_regmap_lookup_by_phandle() combined with getting the syscon > argument. Except simpler code this annotates within one line that given > phandle has arg

Re: [PATCH v2 net-next 07/13] net: enetc: add RSS support for i.MX95 ENETC PF

2025-01-15 Thread Jakub Kicinski
On Mon, 13 Jan 2025 16:22:39 +0800 Wei Fang wrote: > Add Receive side scaling (RSS) support for i.MX95 ENETC PF to improve the > network performance and balance the CPU loading. In addition, since both > ENETC v1 and ENETC v4 only support the toeplitz algorithm, so a check for > hfunc was added. T

Re: [PATCH v2] treewide: const qualify ctl_tables where applicable

2025-01-15 Thread Bill O'Donnell
On Fri, Jan 10, 2025 at 03:16:08PM +0100, Joel Granados wrote: > Add the const qualifier to all the ctl_tables in the tree except for > watchdog_hardlockup_sysctl, memory_allocation_profiling_sysctls, > loadpin_sysctl_table and the ones calling register_net_sysctl (./net, > drivers/inifiniband dirs

Re: [PATCH v2] treewide: const qualify ctl_tables where applicable

2025-01-15 Thread Wei Liu
On Fri, Jan 10, 2025 at 03:16:08PM +0100, Joel Granados wrote: [...] > diff --git a/drivers/hv/hv_common.c b/drivers/hv/hv_common.c > index 7a35c82976e0..9453f0c26f2a 100644 > --- a/drivers/hv/hv_common.c > +++ b/drivers/hv/hv_common.c > @@ -141,7 +141,7 @@ static int sysctl_record_panic_msg = 1; >

Re: [PATCH] selftests: livepatch: handle PRINTK_CALLER in check_result()

2025-01-15 Thread Joe Lawrence
On Tue, Jan 14, 2025 at 08:01:44PM +0530, Madhavan Srinivasan wrote: > Some arch configs (like ppc64) enable CONFIG_PRINTK_CALLER, which > adds the caller id as part of the dmesg. Due to this, even though > the expected vs observed are same, end testcase results are failed. > > -% insmod test_mod

Re: [PATCH v2] treewide: const qualify ctl_tables where applicable

2025-01-15 Thread Thomas Gleixner
On Fri, Jan 10 2025 at 15:16, Joel Granados wrote: > sed: > sed --in-place \ > -e "s/struct ctl_table .table = &uts_kern/const struct ctl_table *table > = \&uts_kern/" \ > kernel/utsname_sysctl.c > > Reviewed-by: Song Liu > Acked-by: Steven Rostedt (Google) # for kernel/trace/ >

Re: [PATCH v5 1/6] elf: Define note name macros

2025-01-15 Thread Dave Martin
Hi, On Wed, Jan 15, 2025 at 02:47:58PM +0900, Akihiko Odaki wrote: > elf.h had a comment saying: > > Notes used in ET_CORE. Architectures export some of the arch register > > sets using the corresponding note types via the PTRACE_GETREGSET and > > PTRACE_SETREGSET requests. > > The note name for t

Re: [PATCH V2 2/5] tools/testing/selftests/powerpc: Add check for power11 pvr for pmu selfests

2025-01-15 Thread Disha Goel
On 13/01/25 1:28 pm, Athira Rajeev wrote: Some of the tests depends on pvr value to choose the event. Example: - event_alternatives_tests_p10: alternative event depends on registered PMU driver which is based on pvr - generic_events_valid_test varies based on platform - bhrb_filter_map_test: ag

Re: [PATCH V2] tools/perf/builtin-lock: Fix return code for functions in __cmd_contention

2025-01-15 Thread Athira Rajeev
> On 14 Jan 2025, at 3:47 AM, Namhyung Kim wrote: > > On Fri, Jan 10, 2025 at 03:07:30PM +0530, Athira Rajeev wrote: >> perf lock contention returns zero exit value even if the lock contention >> BPF setup failed. >> >> # ./perf lock con -b true >> libbpf: kernel BTF is missing at '/sys/ker

Re: [PATCH 0/2] PCI: Simplify few things

2025-01-15 Thread Krzysztof Wilczyński
Hello, > Few code simplifications without functional impact. Not tested on > hardware. Applied to controller/dwc for v6.14, thank you! Krzysztof

Re: [kvm-unit-tests PATCH v1 2/5] configure: Display the default processor for arm and arm64

2025-01-15 Thread Andrew Jones
On Wed, Jan 15, 2025 at 09:55:14AM +, Alexandru Elisei wrote: > Hi Drew, > > On Tue, Jan 14, 2025 at 07:51:04PM +0100, Andrew Jones wrote: > > On Tue, Jan 14, 2025 at 05:17:28PM +, Alexandru Elisei wrote: > > ... > > > > > +# $arch will have changed when cross-compiling. > > > > > +[ -z "$

Re: [kvm-unit-tests PATCH v1 1/5] configure: Document that the architecture name 'aarch64' is also supported

2025-01-15 Thread Alexandru Elisei
Hi Drew, On Tue, Jan 14, 2025 at 07:39:49PM +0100, Andrew Jones wrote: > On Tue, Jan 14, 2025 at 05:03:20PM +, Alexandru Elisei wrote: > ... > > diff --git a/configure b/configure > > index 86cf1da36467..1362b68dd68b 100755 > > --- a/configure > > +++ b/configure > > @@ -15,8 +15,8 @@ objdump=

Re: [kvm-unit-tests PATCH v1 2/5] configure: Display the default processor for arm and arm64

2025-01-15 Thread Alexandru Elisei
Hi Drew, On Tue, Jan 14, 2025 at 07:51:04PM +0100, Andrew Jones wrote: > On Tue, Jan 14, 2025 at 05:17:28PM +, Alexandru Elisei wrote: > ... > > > > +# $arch will have changed when cross-compiling. > > > > +[ -z "$processor" ] && processor=$(get_default_processor $arch) > > > > > > The fact t

Re: [PATCH v6 23/26] mm: Remove pXX_devmap callers

2025-01-14 Thread Alistair Popple
On Tue, Jan 14, 2025 at 10:50:49AM -0800, Dan Williams wrote: > Alistair Popple wrote: > > The devmap PTE special bit was used to detect mappings of FS DAX > > pages. This tracking was required to ensure the generic mm did not > > manipulate the page reference counts as FS DAX implemented it's own

Re: [PATCH v2] cpufreq: Use str_enable_disable-like helpers

2025-01-14 Thread Viresh Kumar
On 14-01-25, 20:06, Krzysztof Kozlowski wrote: > Replace ternary (condition ? "enable" : "disable") syntax with helpers > from string_choices.h because: > 1. Simple function call with one argument is easier to read. Ternary >operator has three arguments and with wrapping might lead to quite >

Re: [PATCH v6 16/26] huge_memory: Add vmf_insert_folio_pmd()

2025-01-14 Thread Alistair Popple
On Tue, Jan 14, 2025 at 09:22:00AM -0800, Dan Williams wrote: > David Hildenbrand wrote: > > > +vm_fault_t vmf_insert_folio_pmd(struct vm_fault *vmf, struct folio > > > *folio, bool write) > > > +{ > > > + struct vm_area_struct *vma = vmf->vma; > > > + unsigned long addr = vmf->address & PMD_MASK;

Re: [PATCH v6 15/26] huge_memory: Add vmf_insert_folio_pud()

2025-01-14 Thread Alistair Popple
On Tue, Jan 14, 2025 at 05:22:15PM +0100, David Hildenbrand wrote: > On 10.01.25 07:00, Alistair Popple wrote: > > Currently DAX folio/page reference counts are managed differently to > > normal pages. To allow these to be managed the same as normal pages > > introduce vmf_insert_folio_pud. This wi

Re: [PATCH v6 13/26] mm/memory: Add vmf_insert_page_mkwrite()

2025-01-14 Thread Alistair Popple
> > > Updates from v2: > > > > - Rename function to make not DAX specific > > > > - Split the insert_page_into_pte_locked() change into a separate > > patch. > > > > Updates from v1: > > > > - Re-arrange code in insert_page_

Re: [PATCH v6 08/26] fs/dax: Remove PAGE_MAPPING_DAX_SHARED mapping flag

2025-01-14 Thread Dan Williams
Alistair Popple wrote: [..] > > How does this case happen? I don't think any page would ever enter with > > both ->mapping and ->share set, right? > > Sigh. You're right - it can't. This patch series is getting a litte bit large > and unweildy with all the prerequisite bugfixes and cleanups. Obvio

Re: [PATCH v6 12/26] mm/memory: Enhance insert_page_into_pte_locked() to create writable mappings

2025-01-14 Thread Alistair Popple
On Mon, Jan 13, 2025 at 05:08:31PM -0800, Dan Williams wrote: > Alistair Popple wrote: > > In preparation for using insert_page() for DAX, enhance > > insert_page_into_pte_locked() to handle establishing writable > > mappings. Recall that DAX returns VM_FAULT_NOPAGE after installing a > > PTE whic

Re: [PATCH v6 08/26] fs/dax: Remove PAGE_MAPPING_DAX_SHARED mapping flag

2025-01-14 Thread Alistair Popple
On Mon, Jan 13, 2025 at 04:52:34PM -0800, Dan Williams wrote: > Alistair Popple wrote: > > PAGE_MAPPING_DAX_SHARED is the same as PAGE_MAPPING_ANON. > > I think a bit a bit more detail is warranted, how about? > > The page ->mapping pointer can have magic values like > PAGE_MAPPING_DAX_SHARED an

Re: [PATCH 06/14] cpumask: re-introduce cpumask_next{,_and}_wrap()

2025-01-14 Thread Yury Norov
On Fri, Jan 03, 2025 at 11:44:32AM -0600, Bjorn Helgaas wrote: > On Sat, Dec 28, 2024 at 10:49:38AM -0800, Yury Norov wrote: > > cpumask_next_wrap_old() has two additional parameters, comparing to it's > > analogue in linux/find.h find_next_bit_wrap(). The reason for that is > > historical. > > s/

Re: [PATCH 06/14] cpumask: re-introduce cpumask_next{,_and}_wrap()

2025-01-14 Thread Yury Norov
On Tue, Jan 07, 2025 at 02:28:31PM +0100, Alexander Gordeev wrote: > On Sat, Dec 28, 2024 at 10:49:38AM -0800, Yury Norov wrote: > > Hi Yury, > > > cpumask_next_wrap_old() has two additional parameters, comparing to it's > > analogue in linux/find.h find_next_bit_wrap(). The reason for that is >

RE: [PATCH 2/2] PCI: dwc: layerscape: Use syscon_regmap_lookup_by_phandle_args

2025-01-14 Thread Roy Zang
> From: Krzysztof Kozlowski > Use syscon_regmap_lookup_by_phandle_args() which is a wrapper over > syscon_regmap_lookup_by_phandle() combined with getting the syscon > argument. Except simpler code this annotates within one line that given > phandle has arguments, so grepping for code would be

Re: [PATCH] fs: introduce getfsxattrat and setfsxattrat syscalls

2025-01-14 Thread Darrick J. Wong
ting but still exist in the directory. Moreover, in the case > when special files are created in the directory with already > existing project quota, these inode inherit extended attributes. > This than leaves them with these attributes without the possibility > to clear

Re: [PATCH v9 0/8] PCI: Consolidate TLP Log reading and printing

2025-01-14 Thread Bjorn Helgaas
On Tue, Jan 14, 2025 at 07:08:32PM +0200, Ilpo Järvinen wrote: > This series has the remaining patches of the AER & DPC TLP Log handling > consolidation and now includes a few minor improvements to the earlier > accepted TLP Logging code. > > v9: > - Added patch to define header logging register s

Re: [PATCH v6 25/26] Revert "riscv: mm: Add support for ZONE_DEVICE"

2025-01-14 Thread Dan Williams
Alistair Popple wrote: > DEVMAP PTEs are no longer required to support ZONE_DEVICE so remove > them. > > Signed-off-by: Alistair Popple > Suggested-by: Chunyan Zhang > Reviewed-by: Björn Töpel This and the next are candidates to squash into the previous remove patch, right? ...and I am not sur

Re: [PATCH v6 24/26] mm: Remove devmap related functions and page table bits

2025-01-14 Thread Dan Williams
Alistair Popple wrote: > Now that DAX and all other reference counts to ZONE_DEVICE pages are > managed normally there is no need for the special devmap PTE/PMD/PUD > page table bits. So drop all references to these, freeing up a > software defined page table bit on architectures supporting it. >

Re: [PATCH v13 5/5] rust: Use gendwarfksyms + extended modversions for CONFIG_MODVERSIONS

2025-01-14 Thread Sami Tolvanen
On Tue, Jan 14, 2025 at 10:22:15AM +0900, Masahiro Yamada wrote: > On Tue, Jan 14, 2025 at 5:04 AM Sami Tolvanen wrote: > > > > Hi Masahiro, > > > > On Fri, Jan 10, 2025 at 6:26 PM Masahiro Yamada > > wrote: > > > > > > On Sat, Jan 4, 2025 at 2:37 AM Matthew Maurer wrote: > > > > > > > > From:

Re: [kvm-unit-tests PATCH v1 2/5] configure: Display the default processor for arm and arm64

2025-01-14 Thread Andrew Jones
On Tue, Jan 14, 2025 at 05:17:28PM +, Alexandru Elisei wrote: ... > > > +# $arch will have changed when cross-compiling. > > > +[ -z "$processor" ] && processor=$(get_default_processor $arch) > > > > The fact that $arch and $processor are wrong until they've had a chance to > > $processor is

Re: [PATCH v6 23/26] mm: Remove pXX_devmap callers

2025-01-14 Thread Dan Williams
Alistair Popple wrote: > The devmap PTE special bit was used to detect mappings of FS DAX > pages. This tracking was required to ensure the generic mm did not > manipulate the page reference counts as FS DAX implemented it's own > reference counting scheme. > > Now that FS DAX pages have their ref

Re: [kvm-unit-tests PATCH v1 1/5] configure: Document that the architecture name 'aarch64' is also supported

2025-01-14 Thread Andrew Jones
On Tue, Jan 14, 2025 at 05:03:20PM +, Alexandru Elisei wrote: ... > diff --git a/configure b/configure > index 86cf1da36467..1362b68dd68b 100755 > --- a/configure > +++ b/configure > @@ -15,8 +15,8 @@ objdump=objdump > readelf=readelf > ar=ar > addr2line=addr2line > -arch=$(uname -m | sed -e

Re: [PATCH v9 3/8] PCI: Add defines for TLP Header/Prefix log sizes

2025-01-14 Thread Jonathan Cameron
On Tue, 14 Jan 2025 19:08:35 +0200 Ilpo Järvinen wrote: > Add defines for AER and DPC capabilities TLP Header Logging register > sizes (PCIe r6.2, sec 7.8.4 / 7.9.14) and replace literals with them. > > Suggested-by: Yazen Ghannam > Signed-off-by: Ilpo Järvinen Hi Ilpo, Where it is simply th

Re: [PATCH] cpufreq: Use str_enable_disable-like helpers

2025-01-14 Thread Krzysztof Kozlowski
On 14/01/2025 11:56, Krzysztof Kozlowski wrote: > if (cpufreq_boost_trigger_state(enable)) { > pr_err("%s: Cannot %s BOOST!\n", > -__func__, enable ? "enable" : "disable"); > +__func__, str_enable_disable(enable)); > return -

Re: [RFC PATCH 0/2] sched/fair: introduce new scheduler group type group_parked

2025-01-14 Thread Tobias Huschle
On 10/12/2024 21:24, Shrikanth Hegde wrote: On 12/9/24 13:35, Tobias Huschle wrote: [...] It was happening with 100% stress-ng case. I was wondering since i dont have no-hz full enabled. I found out the reason why and one way to do is to trigger active load balance if there are any parked

Re: [kvm-unit-tests PATCH v1 4/5] arm/arm64: Add support for --processor=max

2025-01-14 Thread Alexandru Elisei
Hi Drew, On Mon, Jan 13, 2025 at 04:21:45PM +0100, Andrew Jones wrote: > On Fri, Jan 10, 2025 at 01:58:47PM +, Alexandru Elisei wrote: > > For arm64, newer architecture features are supported only on newer CPUs. > > Instead of expecting the user to know which CPU model supports which > > featu

Re: [PATCH v6 16/26] huge_memory: Add vmf_insert_folio_pmd()

2025-01-14 Thread Dan Williams
David Hildenbrand wrote: > > +vm_fault_t vmf_insert_folio_pmd(struct vm_fault *vmf, struct folio *folio, > > bool write) > > +{ > > + struct vm_area_struct *vma = vmf->vma; > > + unsigned long addr = vmf->address & PMD_MASK; > > + struct mm_struct *mm = vma->vm_mm; > > + spinlock_t *ptl; >

Re: [kvm-unit-tests PATCH v1 5/5] configure: arm64: Make 'max' the default for --processor

2025-01-14 Thread Alexandru Elisei
Hi Drew, On Mon, Jan 13, 2025 at 04:29:21PM +0100, Andrew Jones wrote: > On Fri, Jan 10, 2025 at 01:58:48PM +, Alexandru Elisei wrote: > > Newer architecture features are supported by qemu TCG on newer CPUs. When > > writing a test for such architecture features, it is necessary to pass the >

Re: [PATCH 0/2] ASoC: fsl: Support micfil on i.MX943

2025-01-14 Thread Mark Brown
On Tue, 14 Jan 2025 18:27:18 +0800, Shengjiu Wang wrote: > On i.MX943, the FIFO data address is changed and the bit width > of CICOSR is changed. > Add a new compatible string and update driver for these changes. > > Shengjiu Wang (2): > ASoC: fsl_micfil: Add i.MX943 platform support > ASoC: d

Re: [kvm-unit-tests PATCH v1 2/5] configure: Display the default processor for arm and arm64

2025-01-14 Thread Alexandru Elisei
Hi Drew, On Mon, Jan 13, 2025 at 04:11:06PM +0100, Andrew Jones wrote: > On Fri, Jan 10, 2025 at 01:58:45PM +, Alexandru Elisei wrote: > > The help text for the --processor option displays the architecture name as > > the default processor type. But the default for arm is cortex-a15, and for >

Re: [kvm-unit-tests PATCH v1 1/5] configure: Document that the architecture name 'aarch64' is also supported

2025-01-14 Thread Alexandru Elisei
Hi Drew, On Mon, Jan 13, 2025 at 04:01:58PM +0100, Andrew Jones wrote: > On Fri, Jan 10, 2025 at 01:58:44PM +, Alexandru Elisei wrote: > > $arch, on arm64, defaults to 'aarch64', and later in the script is replaced > > by 'arm64'. Intentional or not, document that the name 'aarch64' is also >

Re: [PATCH v2 1/7] powerpc: properly negate error in syscall_set_return_value()

2025-01-14 Thread Dmitry V. Levin
On Mon, Jan 13, 2025 at 06:34:44PM +0100, Christophe Leroy wrote: > Le 13/01/2025 à 18:10, Dmitry V. Levin a écrit : > > Bring syscall_set_return_value() in sync with syscall_get_error(), > > and let upcoming ptrace/set_syscall_info selftest pass on powerpc. > > > > This reverts commit 1b1a3702a65

Re: [PATCH v6 19/26] proc/task_mmu: Mark devdax and fsdax pages as always unpinned

2025-01-14 Thread David Hildenbrand
On 14.01.25 03:28, Dan Williams wrote: Alistair Popple wrote: The procfs mmu files such as smaps and pagemap currently ignore devdax and fsdax pages because these pages are considered special. A future change will start treating these as normal pages, meaning they can be exposed via smaps and pa

Re: [PATCH v6 16/26] huge_memory: Add vmf_insert_folio_pmd()

2025-01-14 Thread David Hildenbrand
+vm_fault_t vmf_insert_folio_pmd(struct vm_fault *vmf, struct folio *folio, bool write) +{ + struct vm_area_struct *vma = vmf->vma; + unsigned long addr = vmf->address & PMD_MASK; + struct mm_struct *mm = vma->vm_mm; + spinlock_t *ptl; + pgtable_t pgtable = NULL; + +

Re: [PATCH v6 15/26] huge_memory: Add vmf_insert_folio_pud()

2025-01-14 Thread David Hildenbrand
On 10.01.25 07:00, Alistair Popple wrote: Currently DAX folio/page reference counts are managed differently to normal pages. To allow these to be managed the same as normal pages introduce vmf_insert_folio_pud. This will map the entire PUD-sized folio and take references as it would for a normall

Re: [PATCH v6 13/26] mm/memory: Add vmf_insert_page_mkwrite()

2025-01-14 Thread David Hildenbrand
be writable if requested/possible. Signed-off-by: Alistair Popple --- Updates from v2: - Rename function to make not DAX specific - Split the insert_page_into_pte_locked() change into a separate patch. Updates from v1: - Re-arrange code in insert_page_into_pte_locked() based on

Re: [PATCH v6 12/26] mm/memory: Enhance insert_page_into_pte_locked() to create writable mappings

2025-01-14 Thread David Hildenbrand
On 10.01.25 07:00, Alistair Popple wrote: In preparation for using insert_page() for DAX, enhance insert_page_into_pte_locked() to handle establishing writable mappings. Recall that DAX returns VM_FAULT_NOPAGE after installing a PTE which bypasses the typical set_pte_range() in finish_fault. Si

Re: [PATCH v6 11/26] mm: Allow compound zone device pages

2025-01-14 Thread David Hildenbrand
On 10.01.25 07:00, Alistair Popple wrote: Zone device pages are used to represent various type of device memory managed by device drivers. Currently compound zone device pages are not supported. This is because MEMORY_DEVICE_FS_DAX pages are the only user of higher order zone device pages and hav

Re: [PATCH v6 08/26] fs/dax: Remove PAGE_MAPPING_DAX_SHARED mapping flag

2025-01-14 Thread David Hildenbrand
On 10.01.25 07:00, Alistair Popple wrote: PAGE_MAPPING_DAX_SHARED is the same as PAGE_MAPPING_ANON. This isn't currently a problem because FS DAX pages are treated specially. However a future change will make FS DAX pages more like normal pages, so folio_test_anon() must not return true for a FS

Re: [PATCH v2 1/7] powerpc: properly negate error in syscall_set_return_value()

2025-01-14 Thread Alexey Gladkov
On Tue, Jan 14, 2025 at 03:48:44PM +0200, Dmitry V. Levin wrote: > On Tue, Jan 14, 2025 at 02:00:16PM +0100, Alexey Gladkov wrote: > > On Mon, Jan 13, 2025 at 07:10:54PM +0200, Dmitry V. Levin wrote: > > > Bring syscall_set_return_value() in sync with syscall_get_error(), > > > and let upcoming ptr

Re: [PATCH v6 10/26] mm/mm_init: Move p2pdma page refcount initialisation to p2pdma

2025-01-14 Thread David Hildenbrand
On 10.01.25 07:00, Alistair Popple wrote: Currently ZONE_DEVICE page reference counts are initialised by core memory management code in __init_zone_device_page() as part of the memremap() call which driver modules make to obtain ZONE_DEVICE pages. This initialises page refcounts to 1 before retur

Re: [PATCH v2 1/7] powerpc: properly negate error in syscall_set_return_value()

2025-01-14 Thread Dmitry V. Levin
On Tue, Jan 14, 2025 at 02:00:16PM +0100, Alexey Gladkov wrote: > On Mon, Jan 13, 2025 at 07:10:54PM +0200, Dmitry V. Levin wrote: > > Bring syscall_set_return_value() in sync with syscall_get_error(), > > and let upcoming ptrace/set_syscall_info selftest pass on powerpc. > > > > This reverts comm

Re: [PATCH v2 1/7] powerpc: properly negate error in syscall_set_return_value()

2025-01-14 Thread Alexey Gladkov
On Mon, Jan 13, 2025 at 07:10:54PM +0200, Dmitry V. Levin wrote: > Bring syscall_set_return_value() in sync with syscall_get_error(), > and let upcoming ptrace/set_syscall_info selftest pass on powerpc. > > This reverts commit 1b1a3702a65c ("powerpc: Don't negate error in > syscall_set_return_valu

Re: [PATCH v4 5/6] s390/crash: Use note name macros

2025-01-14 Thread Dave Martin
Hi, On Sat, Jan 11, 2025 at 02:48:48PM +0900, Akihiko Odaki wrote: > Use note name macros to match with the userspace's expectation. > > Signed-off-by: Akihiko Odaki > Acked-by: Heiko Carstens Reviewed-by: Dave Martin (I'm not in a position to test this, though.) > --- > arch/s390/kernel/c

Re: [PATCH v4 6/6] crash: Remove KEXEC_CORE_NOTE_NAME

2025-01-14 Thread Dave Martin
Hi, On Sat, Jan 11, 2025 at 02:48:49PM +0900, Akihiko Odaki wrote: > KEXEC_CORE_NOTE_NAME is no longer used. > > Signed-off-by: Akihiko Odaki > Acked-by: Baoquan He Reviewed-by: Dave Martin > --- > include/linux/kexec.h | 2 -- > include/linux/vmcore_info.h | 1 - > 2 files changed, 3

  1   2   3   4   5   6   7   8   9   10   >