> -----Original Message----- > From: Jakub Kicinski <k...@kernel.org> > Sent: 2025年1月16日 10:41 > To: Wei Fang <wei.f...@nxp.com> > Cc: Claudiu Manoil <claudiu.man...@nxp.com>; Vladimir Oltean > <vladimir.olt...@nxp.com>; Clark Wang <xiaoning.w...@nxp.com>; > andrew+net...@lunn.ch; da...@davemloft.net; eduma...@google.com; > pab...@redhat.com; christophe.le...@csgroup.eu; net...@vger.kernel.org; > linux-ker...@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; > linux-arm-ker...@lists.infradead.org; i...@lists.linux.dev > Subject: Re: [PATCH v2 net-next 07/13] net: enetc: add RSS support for i.MX95 > ENETC PF > > On Thu, 16 Jan 2025 02:24:10 +0000 Wei Fang wrote: > > > Why create full ops for something this trivial? > > > > We add enetc_pf_hw_ops to implement different hardware ops > > for different chips. So that they can be called in common functions. > > Although the change is minor, it is consistent with the original > > intention of adding enetc_pf_hw_ops. > > In other words you prefer ops. > > Now imagine you have to refactor such piece of code in 10 drivers > and each of them has 2 layers of indirect ops like you do. > Unnecessary complexity.
Okay, I will remove them from ops.
