Re: [RFC PATCH] fsldma: Add DMA_SLAVE support

2009-06-18 Thread Dan Williams
Ira Snyder wrote: So, I see a couple of ways of moving forward: 1) Keep my implementation, moving the includes to arch/powerpc/include. Do we drop the allocation functions? +1 for option 1. Having it under arch/powerpc/include makes it clear that it is a powerpc specific api, so keep the a

Re: [RFC PATCH] fsldma: Add DMA_SLAVE support

2009-06-18 Thread Ira Snyder
On Thu, Jun 18, 2009 at 11:16:03AM -0700, Dan Williams wrote: > Ira Snyder wrote: >> I can do something similar by calling device_prep_dma_memcpy() lots of >> times. Once for each page in the scatterlist. >> >> This has the advantage of not changing the DMAEngine API. >> >> This has the disadvantag

Re: [RFC PATCH] fsldma: Add DMA_SLAVE support

2009-06-18 Thread Dan Williams
Ira Snyder wrote: I can do something similar by calling device_prep_dma_memcpy() lots of times. Once for each page in the scatterlist. This has the advantage of not changing the DMAEngine API. This has the disadvantage of not being a single transaction. The DMA controller will get an interrupt

Re: [RFC PATCH] fsldma: Add DMA_SLAVE support

2009-06-17 Thread Ira Snyder
On Wed, Jun 17, 2009 at 10:17:54AM -0700, Dan Williams wrote: > Ira Snyder wrote: >>> Using EXPORT_SYMBOL would defeat the purpose of conforming to the >>> dmaengine api which should allow other subsystems to generically >>> discover an fsldma resource. >>> >> >> Any driver would still use dma_requ

Re: [RFC PATCH] fsldma: Add DMA_SLAVE support

2009-06-17 Thread Dan Williams
Ira Snyder wrote: Using EXPORT_SYMBOL would defeat the purpose of conforming to the dmaengine api which should allow other subsystems to generically discover an fsldma resource. Any driver would still use dma_request_channel(), etc. to get access to a DMA channel. AFAICT, DMA_SLAVE is intended

Re: [RFC PATCH] fsldma: Add DMA_SLAVE support

2009-06-16 Thread Ira Snyder
On Tue, Jun 16, 2009 at 12:01:40PM -0700, Dan Williams wrote: > Hi Ira, > > Ira Snyder wrote: >> Use the DMA_SLAVE capability of the DMAEngine API to copy/from a >> scatterlist into an arbitrary list of hardware address/length pairs. >> >> This allows a single DMA transaction to copy data from seve

Re: [RFC PATCH] fsldma: Add DMA_SLAVE support

2009-06-16 Thread Dan Williams
Hi Ira, Ira Snyder wrote: Use the DMA_SLAVE capability of the DMAEngine API to copy/from a scatterlist into an arbitrary list of hardware address/length pairs. This allows a single DMA transaction to copy data from several different devices into a scatterlist at the same time. This also adds s

Re: [RFC PATCH] fsldma: Add DMA_SLAVE support

2009-06-04 Thread Ira Snyder
On Thu, Jun 04, 2009 at 07:20:26PM +0800, Li Yang-R58472 wrote: > > >> This is a request for comments on this patch. I hunch it is > >not quite > >> ready for inclusion, though it is certainly ready for > >review. Correct > >> functioning of this patch depends on the patches submitted earlier.

RE: [RFC PATCH] fsldma: Add DMA_SLAVE support

2009-06-04 Thread Li Yang-R58472
>> This is a request for comments on this patch. I hunch it is >not quite >> ready for inclusion, though it is certainly ready for >review. Correct >> functioning of this patch depends on the patches submitted earlier. >> >> As suggested by Dan Williams, I implemented DMA_SLAVE >support for

Re: [RFC PATCH] fsldma: Add DMA_SLAVE support

2009-06-03 Thread Ira Snyder
On Fri, May 15, 2009 at 03:56:59PM -0700, Ira Snyder wrote: > Use the DMA_SLAVE capability of the DMAEngine API to copy/from a > scatterlist into an arbitrary list of hardware address/length pairs. > > This allows a single DMA transaction to copy data from several different > devices into a scatte