Re: [PATCH v3 6/7] mtd: m25p80: add a read function to read page by page

2010-10-07 Thread Kumar Gala
On Oct 7, 2010, at 9:15 PM, Hu Mingkai-B21284 wrote: Yes, I agree with David on this. If large transfers don't work, then it is the SPI master driver that is buggy. >>> >>> By the way, does this fix your problem? >>> >>> https://patchwork.kernel.org/patch/184752/ >> >> It shouldn't.

RE: [PATCH v3 6/7] mtd: m25p80: add a read function to read page by page

2010-10-07 Thread Hu Mingkai-B21284
spi-devel- > gene...@lists.sourceforge.net > Subject: Re: [PATCH v3 6/7] mtd: m25p80: add a read function to read page by > page > > On Thu, Sep 30, 2010 at 11:41:40PM +0900, Grant Likely wrote: > > On Thu, Sep 30, 2010 at 11:16 PM, Grant Likely > > wrote: > > > On Thu,

RE: [PATCH v3 6/7] mtd: m25p80: add a read function to read page by page

2010-10-07 Thread Hu Mingkai-B21284
ang Roy-R61911; Hu Mingkai-B21284 > Subject: Re: [PATCH v3 6/7] mtd: m25p80: add a read function to read page by > page > > > --- On Thu, 9/30/10, Mingkai Hu wrote: > > > From: Mingkai Hu > > Subject: [PATCH v3 6/7] mtd: m25p80: add a read function to read page >

Re: [PATCH v3 6/7] mtd: m25p80: add a read function to read page by page

2010-09-30 Thread Grant Likely
Hmmm for some reason the previous replies didn't get picked up by patchwork, so I'm replying with my comment again for the public record. In this case the eSPI controller driver is buggy and needs to be fixed. If the hardware can only support small transfers, then it is the responsibilty of t

Re: [PATCH v3 6/7] mtd: m25p80: add a read function to read page by page

2010-09-30 Thread Grant Likely
On Fri, Oct 1, 2010 at 12:06 AM, Anton Vorontsov wrote: > On Thu, Sep 30, 2010 at 11:41:40PM +0900, Grant Likely wrote: >> On Thu, Sep 30, 2010 at 11:16 PM, Grant Likely >> wrote: >> > On Thu, Sep 30, 2010 at 7:46 PM, David Brownell >> > wrote: >> >> >> >> --- On Thu, 9/30/10, Mingkai Hu wrote

Re: [PATCH v3 6/7] mtd: m25p80: add a read function to read page by page

2010-09-30 Thread Anton Vorontsov
On Thu, Sep 30, 2010 at 11:41:40PM +0900, Grant Likely wrote: > On Thu, Sep 30, 2010 at 11:16 PM, Grant Likely > wrote: > > On Thu, Sep 30, 2010 at 7:46 PM, David Brownell wrote: > >> > >> --- On Thu, 9/30/10, Mingkai Hu wrote: > >> > >>> From: Mingkai Hu > >>> Subject: [PATCH v3 6/7] mtd: m25p

Re: [PATCH v3 6/7] mtd: m25p80: add a read function to read page by page

2010-09-30 Thread Grant Likely
On Thu, Sep 30, 2010 at 11:16 PM, Grant Likely wrote: > On Thu, Sep 30, 2010 at 7:46 PM, David Brownell wrote: >> >> --- On Thu, 9/30/10, Mingkai Hu wrote: >> >>> From: Mingkai Hu >>> Subject: [PATCH v3 6/7] mtd: m25p80: add a read function to read page by >>> page >> >> NAK. >> >> We went ove

Re: [PATCH v3 6/7] mtd: m25p80: add a read function to read page by page

2010-09-30 Thread Grant Likely
On Thu, Sep 30, 2010 at 7:46 PM, David Brownell wrote: > > --- On Thu, 9/30/10, Mingkai Hu wrote: > >> From: Mingkai Hu >> Subject: [PATCH v3 6/7] mtd: m25p80: add a read function to read page by page > > NAK. > > We went over this before. Yes, I agree with David on this. If large transfers do

Re: [PATCH v3 6/7] mtd: m25p80: add a read function to read page by page

2010-09-30 Thread David Brownell
--- On Thu, 9/30/10, Mingkai Hu wrote: > From: Mingkai Hu > Subject: [PATCH v3 6/7] mtd: m25p80: add a read function to read page by page NAK. We went over this before.   The bug is in your SPI master controller driver, and the fix there involves mapping large reads into multiple smaller re