> -----Original Message----- > From: David Brownell [mailto:davi...@pacbell.net] > Sent: Thursday, September 30, 2010 6:46 PM > To: linuxppc-...@ozlabs.org; spi-devel-gene...@lists.sourceforge.net; linux- > m...@lists.infradead.org; Hu Mingkai-B21284 > Cc: Gala Kumar-B11780; Zang Roy-R61911; Hu Mingkai-B21284 > Subject: Re: [PATCH v3 6/7] mtd: m25p80: add a read function to read page by > page > > > --- On Thu, 9/30/10, Mingkai Hu <mingkai...@freescale.com> wrote: > > > From: Mingkai Hu <mingkai...@freescale.com> > > Subject: [PATCH v3 6/7] mtd: m25p80: add a read function to read page > > by page > > NAK. > > We went over this before. > > The bug is in your SPI master controller driver, and the fix there involves > mapping large reads into multiple smaller reads. (Example, 128K read as two > 64K reads instead of one of 128K. > > It's *NEVER* appropriate to commit to patching all upper level drivers in > order > to work around bugs in lower level ones. The set of such upper level drivers > that may need bugfixing is quite large, most will never be used with your > buggy > controller driver, and all such patches will need testing (but the test > resources are probably not available). > > Whatever SPI controller driver you're working with is clearly buggy ... but > not > unfixably so. > > DO NOT head down the path of requiring every SPI device driver to include > workarounds for this odd little SPI master driver bug. > > - Dave >
Thanks for your comments, the controller driver is the proper place to handle this, I'll fix it. Thanks, Mingkai _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
