Hi, Stephen,
I've updated those patches with fixing up.
Thanks!
Wei.
> -Original Message-
> From: Stephen Rothwell [mailto:[EMAIL PROTECTED]
> Sent: Wednesday, March 05, 2008 10:52 AM
> To: Zhang Wei
> Cc: linuxppc-dev@ozlabs.org; [EMAIL PROTECTED]
> Subject
Hi Weu,
On Wed, 5 Mar 2008 09:59:38 +0800 "Zhang Wei" <[EMAIL PROTECTED]> wrote:
>
> Thanks! I'm considering to commit a updated patch or new code cleaning
> patch.
> How about your idea?
Preferably, fix up the patches. If that is a pain, then a followup patch
that cleans up is ok as these do no
L PROTECTED]; [EMAIL PROTECTED];
> linuxppc-dev@ozlabs.org; [EMAIL PROTECTED]
> Subject: Re: [PATCH 11/17] Add memory mapping driver to RapidIO.
>
> On Wed, 5 Mar 2008 00:29:56 +0800 Zhang Wei
> <[EMAIL PROTECTED]> wrote:
> >
> > + i
On Wed, 5 Mar 2008 00:29:56 +0800 Zhang Wei <[EMAIL PROTECTED]> wrote:
>
> + if (!(rmem->virt = dma_alloc_coherent(NULL, rmem->size,
> + &rmem->iores.start, GFP_KERNEL))) {
Please separate assignments from tests.
> + if ((ret = rio_space_claim(rmem))) {
Again
