Hi, Stephen, Thanks! I'm considering to commit a updated patch or new code cleaning patch. How about your idea?
Cheers! Wei > -----Original Message----- > From: Stephen Rothwell [mailto:[EMAIL PROTECTED] > Sent: Tuesday, March 04, 2008 6:38 PM > To: Zhang Wei > Cc: [EMAIL PROTECTED]; [EMAIL PROTECTED]; > linuxppc-dev@ozlabs.org; [EMAIL PROTECTED] > Subject: Re: [PATCH 11/17] Add memory mapping driver to RapidIO. > > On Wed, 5 Mar 2008 00:29:56 +0800 Zhang Wei > <[EMAIL PROTECTED]> wrote: > > > > + if (!(rmem->virt = dma_alloc_coherent(NULL, rmem->size, > > + &rmem->iores.start, GFP_KERNEL))) { > > Please separate assignments from tests. > > > + if ((ret = rio_space_claim(rmem))) { > > Again. > > -- > Cheers, > Stephen Rothwell [EMAIL PROTECTED] > http://www.canb.auug.org.au/~sfr/ > _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
