Re: PS3: Fix memory hotplug

2008-05-21 Thread Geoff Levand
Paul Mackerras wrote: > Benjamin Herrenschmidt writes: > >> When you do an lmb_add you should probably also do an lmb_analyze to >> update the total memory count etc... >> >> That leads to some interesting issues such as the LMB stuff wasn't >> really meant to be dynamically modified after boot,

Re: [patch v2] PS3: Fix memory hotplug

2008-05-21 Thread Geoff Levand
Geoff Levand wrote: > A change was made to walk_memory_resource() in commit > 4b119e21d0c66c22e8ca03df05d9de623d0eb50f that added a > check of find_lmb(). Add the coresponding lmb_add() > call to ps3_mm_add_memory() so that that check will > succeed. > > This fixes the condition where the PS3 boo

[patch v2] PS3: Fix memory hotplug

2008-05-15 Thread Geoff Levand
A change was made to walk_memory_resource() in commit 4b119e21d0c66c22e8ca03df05d9de623d0eb50f that added a check of find_lmb(). Add the coresponding lmb_add() call to ps3_mm_add_memory() so that that check will succeed. This fixes the condition where the PS3 boots up with only the 128 MiB of boo

Re: PS3: Fix memory hotplug

2008-05-15 Thread Paul Mackerras
Benjamin Herrenschmidt writes: > When you do an lmb_add you should probably also do an lmb_analyze to > update the total memory count etc... > > That leads to some interesting issues such as the LMB stuff wasn't > really meant to be dynamically modified after boot, and thus the kernel > has no lo

Re: PS3: Fix memory hotplug

2008-05-15 Thread David Miller
From: Benjamin Herrenschmidt <[EMAIL PROTECTED]> Date: Wed, 14 May 2008 23:51:29 -0700 > > > Paul, any thoughts here ? Should we add a lock ? That would mean being > > careful as the LMB stuff can be called very early, and spinlock wants > > things like PACA and possibly lockdep to be around.. >

Re: PS3: Fix memory hotplug

2008-05-15 Thread Benjamin Herrenschmidt
> Paul, any thoughts here ? Should we add a lock ? That would mean being > careful as the LMB stuff can be called very early, and spinlock wants > things like PACA and possibly lockdep to be around.. Actually, we call early_init_devtree(), which populates the LMB, after we initialize the PACA an

Re: PS3: Fix memory hotplug

2008-05-14 Thread Benjamin Herrenschmidt
On Tue, 2008-05-13 at 09:23 -0700, Geoff Levand wrote: > A change was made to walk_memory_resource() in commit > 4b119e21d0c66c22e8ca03df05d9de623d0eb50f that added a > check of find_lmb(). Add the corresponding lmb_add() > call to ps3_mm_add_memory() so that that check will > succeed. > > This

PS3: Fix memory hotplug

2008-05-13 Thread Geoff Levand
A change was made to walk_memory_resource() in commit 4b119e21d0c66c22e8ca03df05d9de623d0eb50f that added a check of find_lmb(). Add the corresponding lmb_add() call to ps3_mm_add_memory() so that that check will succeed. This fixes the condition where the PS3 boots up with just the 128 MiB of bo