Re: Missing operand for tlbie instruction on Power7

2015-10-07 Thread Michael Ellerman
On Wed, 2015-10-07 at 20:15 -0400, Josh Boyer wrote: > On Wed, Oct 7, 2015 at 8:10 PM, Michael Ellerman wrote: > > On Wed, 2015-10-07 at 10:31 -0400, Josh Boyer wrote: > >> On Wed, Oct 7, 2015 at 5:13 AM, Michael Ellerman > >> wrote: > >> > On Wed, 2015-10-07 at 02:19 -0500, Segher Boessenkool w

Re: Missing operand for tlbie instruction on Power7

2015-10-07 Thread Josh Boyer
On Wed, Oct 7, 2015 at 8:10 PM, Michael Ellerman wrote: > On Wed, 2015-10-07 at 10:31 -0400, Josh Boyer wrote: >> On Wed, Oct 7, 2015 at 5:13 AM, Michael Ellerman wrote: >> > On Wed, 2015-10-07 at 02:19 -0500, Segher Boessenkool wrote: >> >> On Wed, Oct 07, 2015 at 05:00:49PM +1100, Michael Eller

Re: Missing operand for tlbie instruction on Power7

2015-10-07 Thread Michael Ellerman
On Wed, 2015-10-07 at 10:31 -0400, Josh Boyer wrote: > On Wed, Oct 7, 2015 at 5:13 AM, Michael Ellerman wrote: > > On Wed, 2015-10-07 at 02:19 -0500, Segher Boessenkool wrote: > >> On Wed, Oct 07, 2015 at 05:00:49PM +1100, Michael Ellerman wrote: > >> > > It's also worth noting that the __flush_po

Re: Missing operand for tlbie instruction on Power7

2015-10-07 Thread Josh Boyer
On Wed, Oct 7, 2015 at 5:13 AM, Michael Ellerman wrote: > On Wed, 2015-10-07 at 02:19 -0500, Segher Boessenkool wrote: >> On Wed, Oct 07, 2015 at 05:00:49PM +1100, Michael Ellerman wrote: >> > > It's also worth noting that the __flush_power7 uses tlbiel instead of >> > > tlbie. >> > >> > Yeah tha

Re: Missing operand for tlbie instruction on Power7

2015-10-07 Thread Michael Ellerman
On Wed, 2015-10-07 at 02:19 -0500, Segher Boessenkool wrote: > On Wed, Oct 07, 2015 at 05:00:49PM +1100, Michael Ellerman wrote: > > > It's also worth noting that the __flush_power7 uses tlbiel instead of > > > tlbie. > > > > Yeah that's a good point. It's not clear if the swsusp code wants to a

Re: Missing operand for tlbie instruction on Power7

2015-10-07 Thread Segher Boessenkool
On Wed, Oct 07, 2015 at 05:00:49PM +1100, Michael Ellerman wrote: > > It's also worth noting that the __flush_power7 uses tlbiel instead of tlbie. > > Yeah that's a good point. It's not clear if the swsusp code wants to a local > or > a global invalidate. If I read the code right, this is called

Re: Missing operand for tlbie instruction on Power7

2015-10-06 Thread Michael Ellerman
On Tue, 2015-10-06 at 11:25 -0700, Laura Abbott wrote: > On 10/05/2015 08:35 PM, Michael Ellerman wrote: > > On Fri, 2015-10-02 at 08:43 -0700, Laura Abbott wrote: > >> Hi, > >> > >> We received a report (https://bugzilla.redhat.com/show_bug.cgi?id=1267395) > >> of bad assembly > >> when compiling

Re: Missing operand for tlbie instruction on Power7

2015-10-06 Thread Laura Abbott
On 10/05/2015 08:35 PM, Michael Ellerman wrote: On Fri, 2015-10-02 at 08:43 -0700, Laura Abbott wrote: Hi, We received a report (https://bugzilla.redhat.com/show_bug.cgi?id=1267395) of bad assembly when compiling on powerpc with little endian ... After some discussion with the binutils fol

Re: Missing operand for tlbie instruction on Power7

2015-10-05 Thread Michael Ellerman
On Fri, 2015-10-02 at 08:43 -0700, Laura Abbott wrote: > Hi, > > We received a report (https://bugzilla.redhat.com/show_bug.cgi?id=1267395) of > bad assembly > when compiling on powerpc with little endian ... > After some discussion with the binutils folks, it turns out that the tlbie > instruc

Re: Missing operand for tlbie instruction on Power7

2015-10-05 Thread Laura Abbott
On 10/03/2015 05:00 PM, Segher Boessenkool wrote: On Fri, Oct 02, 2015 at 09:24:46PM -0500, Peter Bergner wrote: Ok, than we can just zero out r5 for example and use it in tlbie as RS, right? That won't assemble _unless_ your assembler is in POWER7 mode. It also won't do the right thing at ru

Re: Missing operand for tlbie instruction on Power7

2015-10-03 Thread Segher Boessenkool
On Fri, Oct 02, 2015 at 09:24:46PM -0500, Peter Bergner wrote: > > > Ok, than we can just zero out r5 for example and use it in tlbie as RS, > > > right? > > > > That won't assemble _unless_ your assembler is in POWER7 mode. It also > > won't do the right thing at run time on older machines. > >

Re: Missing operand for tlbie instruction on Power7

2015-10-02 Thread Peter Bergner
On Fri, 2015-10-02 at 17:00 -0500, Segher Boessenkool wrote: > On Sat, Oct 03, 2015 at 12:37:35AM +0300, Denis Kirjanov wrote: > > >> -0: tlbie r4; \ > > >> +0: tlbie r4, 0; \ > > > > > > This isn't correct. With POWER7 and later (wh

Re: Missing operand for tlbie instruction on Power7

2015-10-02 Thread Laura Abbott
On 10/02/2015 03:00 PM, Segher Boessenkool wrote: On Sat, Oct 03, 2015 at 12:37:35AM +0300, Denis Kirjanov wrote: -0: tlbie r4; \ +0: tlbie r4, 0; \ This isn't correct. With POWER7 and later (which this compile is, since it's on

Re: Missing operand for tlbie instruction on Power7

2015-10-02 Thread Segher Boessenkool
On Sat, Oct 03, 2015 at 12:37:35AM +0300, Denis Kirjanov wrote: > >> -0: tlbie r4; \ > >> +0: tlbie r4, 0; \ > > > > This isn't correct. With POWER7 and later (which this compile > > is, since it's on LE), the tlbie instruction takes

Re: Missing operand for tlbie instruction on Power7

2015-10-02 Thread Denis Kirjanov
On 10/2/15, Peter Bergner wrote: > On Fri, 2015-10-02 at 22:03 +0300, Denis Kirjanov wrote: >> arch/powerpc/kernel/swsusp_asm64.S: Assembler messages: >>> arch/powerpc/kernel/swsusp_asm64.S:188: Error: missing operand >>> scripts/Makefile.build:294: recipe for target >>> 'arch/powerpc/kernel/swsus

Re: Missing operand for tlbie instruction on Power7

2015-10-02 Thread Peter Bergner
On Fri, 2015-10-02 at 22:03 +0300, Denis Kirjanov wrote: > arch/powerpc/kernel/swsusp_asm64.S: Assembler messages: >> arch/powerpc/kernel/swsusp_asm64.S:188: Error: missing operand >> scripts/Makefile.build:294: recipe for target >> 'arch/powerpc/kernel/swsusp_asm64.o' failed >> make[1]: *** [arch/

Re: Missing operand for tlbie instruction on Power7

2015-10-02 Thread Denis Kirjanov
On 10/2/15, Laura Abbott wrote: > Hi, > > We received a report (https://bugzilla.redhat.com/show_bug.cgi?id=1267395) > of bad assembly > when compiling on powerpc with little endian > > [labbott@labbott-redhat-machine linux_upstream]$ make ARCH=powerpc > CROSS_COMPILE=powerpc64-linux-gnu- >CHK

Missing operand for tlbie instruction on Power7

2015-10-02 Thread Laura Abbott
Hi, We received a report (https://bugzilla.redhat.com/show_bug.cgi?id=1267395) of bad assembly when compiling on powerpc with little endian [labbott@labbott-redhat-machine linux_upstream]$ make ARCH=powerpc CROSS_COMPILE=powerpc64-linux-gnu- CHK include/config/kernel.release CHK in